New issue
Advanced search Search tips

Issue 915402 link

Starred by 1 user
Status: Fixed
Owner:
dfried@chromium.org
Closed: Dec 18
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 3
Type: Bug



Sign in to add a comment

Browser frame view minimum layout sizes are not calculated correctly.

Project Member Reported by dfried@chromium.org, Dec 15 
Logic in for example OpaqueBrowserFrameViewLayout::GetMinimumSize() is adding things that should be max'd together (among other problems).

Note that this will NOT solve  issue #842239 , though it will help us get there.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55cde65e3afa4950421e0c8e993118aaec6a2b5f

commit 55cde65e3afa4950421e0c8e993118aaec6a2b5f
Author: Dana Fried <dfried@chromium.org>
Date: Mon Dec 17 23:45:23 2018

Fix browser frame layout logic.

It was erroneously adding the minimum width of the top handle and
rest of the Chrome window rather than using the maximum of the two,
plus frame size.

Bug:  915402 
Change-Id: Iee380c7f676ce320318940b3e96800139c669763
Reviewed-on: https://chromium-review.googlesource.com/c/1379246
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617287}
[modify] https://crrev.com/55cde65e3afa4950421e0c8e993118aaec6a2b5f/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
[modify] https://crrev.com/55cde65e3afa4950421e0c8e993118aaec6a2b5f/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc

Comment 2 by dfried@chromium.org, Dec 18

Status: Fixed (was: Started)
►

Sign in to add a comment