New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 915219
Owner: ----
Closed: Dec 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment
link

Issue 915383: sync_integration_tests failing on chromium.memory/Linux TSan Tests is Flaky (TwoClientPasswordsSyncTest)

Reported by sheriff-...@appspot.gserviceaccount.com, Dec 14 Project Member

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of hongchan@google.com

sync_integration_tests failing on chromium.memory/Linux TSan Tests

Builders failed on: 
- Linux TSan Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests

failures:
USS/TwoClientPasswordsSyncTest.SetPassphraseAndAddPassword_E2ETest/0

Started from:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests/31079
 

Comment 1 by hongchan@chromium.org, Dec 15

Components: Services>Sync
Disabling flaky tests: https://chromium-review.googlesource.com/c/chromium/src/+/1379209

Comment 2 by hongchan@chromium.org, Dec 15

Components: Tests>Flaky
Labels: -Sheriff-Chromium

Comment 3 by bugdroid1@chromium.org, Dec 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b145bbabbaae4e639d70b9f217a8d572f29202f0

commit b145bbabbaae4e639d70b9f217a8d572f29202f0
Author: Hongchan Choi <hongchan@chromium.org>
Date: Sat Dec 15 00:38:52 2018

Disable TwoClientPasswordsSyncTest.SetPassphraseAndAddPassword (flaky)

TBR=hans

Bug:  915383 
Change-Id: If4e475852268863bc2f854cfeb7c253ebf8b348d
Reviewed-on: https://chromium-review.googlesource.com/c/1379209
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616899}
[modify] https://crrev.com/b145bbabbaae4e639d70b9f217a8d572f29202f0/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc

Comment 4 by shimazu@chromium.org, Dec 17

Cc: treib@chromium.org h...@chromium.org
Labels: -Pri-2 Test-Flaky Sheriff-Chromium OS-Linux Pri-1 Type-Bug
Mergedinto: 915219
Status: Duplicate (was: Available)
Summary: sync_integration_tests failing on chromium.memory/Linux TSan Tests is Flaky (TwoClientPasswordsSyncTest) (was: sync_integration_tests failing on chromium.memory/Linux TSan Tests is Flaky)
Other TwoClientPasswordsSyncTests are also failing on TSan bot.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=sync_integration_tests&tests=TwoClientPasswordsSyncTest

In my read of this log, the failure seems happening due to a read of FeatureList on IO thread while it's written on the main thread in the test.
https://chromium-swarm.appspot.com/task?id=41d28b7eec766c10&refresh=10&show_raw=1

I think we need to setup the feature flag before getting the test body started, as  https://crbug.com/915219#c7  mentioned.
https://cs.chromium.org/chromium/src/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc?type=cs&q=TwoClientPasswordsSyncTest&sq=package:chromium&g=0&l=60

Comment 5 by estaab@chromium.org, Jan 24

Components: -Tests>Flaky

Sign in to add a comment