New issue
Advanced search Search tips

Issue 915382 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Xoderunner: Add 'copy-image' feature for failed tests

Project Member Reported by monufriienko@chromium.org, Dec 14

Issue description

Xoderunner: Add 'copy-image' feature for failed tests to make debugging easier.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93e3f30a17f90a97834688835cdf22ff867ff27d

commit 93e3f30a17f90a97834688835cdf22ff867ff27d
Author: git config --global <monufriienko@chromium.org>
Date: Tue Dec 18 22:17:39 2018

Copy screenshots of failed tests to 'test_data' output folder.

Bug:  915382 
Change-Id: I8c9e390589d629a664e571fe81864281d754ea6f
Reviewed-on: https://chromium-review.googlesource.com/c/1379206
Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617653}
[modify] https://crrev.com/93e3f30a17f90a97834688835cdf22ff867ff27d/ios/build/bots/scripts/xcodebuild_runner.py

Components: -Infra Infra>Client>iOS
Cc: linds...@chromium.org
Status: Assigned (was: Untriaged)
Is this considered fixed now Maksym?
Status: Fixed (was: Assigned)
Yes, the feature works.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1f1f2823b4d379fa24e3a48782e40957a25d63d

commit b1f1f2823b4d379fa24e3a48782e40957a25d63d
Author: git config --global <monufriienko@chromium.org>
Date: Wed Dec 19 20:15:25 2018

Added test_cases parameter to SimulatorParallelTestRunner

This allows to filter test_cases and use xcodebuild for swarm-sharding.

Bug:  915382 
Change-Id: Ia78a1a2dbfc14dd7713116eef0f786581087b077
Reviewed-on: https://chromium-review.googlesource.com/c/1384786
Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617923}
[modify] https://crrev.com/b1f1f2823b4d379fa24e3a48782e40957a25d63d/ios/build/bots/scripts/run.py
[modify] https://crrev.com/b1f1f2823b4d379fa24e3a48782e40957a25d63d/ios/build/bots/scripts/xcodebuild_runner.py
[modify] https://crrev.com/b1f1f2823b4d379fa24e3a48782e40957a25d63d/ios/build/bots/scripts/xcodebuild_runner_test.py

Sign in to add a comment