Wrong icon for google.com in site settings |
||
Issue descriptionRepro steps: 1) Launch Android Chrome with empty profile 2) Navigate to www.google.com/flights/ 3) Go to settings>Site settings>All Sites Expected: Either no favicon for google.com or the correct favicon for google.com Actual: See screenshot
,
Dec 14
Assigning to Dominick who introduced the fallback_to_host logic in https://chromium-review.googlesource.com/c/chromium/src/+/846319/
,
Dec 17
The reason why a visit to google.com/flights results in an All Sites entry for google.com is because certain data (i.e. cookies) is ETLD+1 scoped. As soon as the user visits google.com For instance, if you replace google.com with some other site that is less well known, you have the following chain in your repro: 1. I visited some site example.com/flights. It shows a favicon and sets a cookie for example.com 2. I go to All Sites, and see an entry for example.com showing the favicon I saw when I visited example.com/flights This seems like a one-off case given a) how well known the Google favicon is. and b) how often Google hosts sites with different favicons. I think it's more likely than not we'll end up with a good favicon through fallback_to_host than this case. |
||
►
Sign in to add a comment |
||
Comment 1 by pkotw...@chromium.org
, Dec 14