New issue
Advanced search Search tips

Issue 915374 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Wrong icon for google.com in site settings

Project Member Reported by pkotw...@chromium.org, Dec 14

Issue description

Repro steps:
1) Launch Android Chrome with empty profile
2) Navigate to www.google.com/flights/
3) Go to settings>Site settings>All Sites

Expected:
Either no favicon for google.com or the correct favicon for google.com
Actual:
See screenshot
 
Screenshot_20181214-171717.png
99 KB View Download
I found this behaviour as a result of reading through ThumbnailDatabase::FindFirstPageURLForHost().
It would be easy to limit the output of FindFirstPageURLForHost() to page URLs with the format
".*://" + host_url + "/[^/]*"
using REGEXP but I don't know whether that would be desirable.

I do not know about the specifics of the usage of the FaviconServiceImpl::GetRawFaviconForPageURL() fallback_to_host parameter

I looked into this as a result of someone showing interest of using the fallback_to_host logic for "search engines" in settings. It would be weird for the "Google Flights" icon to show up as the icon for the Google search engine
Owner: dominickn@chromium.org
Status: Assigned (was: Untriaged)
Assigning to Dominick who introduced the fallback_to_host logic in https://chromium-review.googlesource.com/c/chromium/src/+/846319/
The reason why a visit to google.com/flights results in an All Sites entry for google.com is because certain data (i.e. cookies) is ETLD+1 scoped. As soon as the user visits google.com

For instance, if you replace google.com with some other site that is less well known, you have the following chain in your repro:

1. I visited some site example.com/flights. It shows a favicon and sets a cookie for example.com
2. I go to All Sites, and see an entry for example.com showing the favicon I saw when I visited example.com/flights

This seems like a one-off case given a) how well known the Google favicon is. and b) how often Google hosts sites with different favicons. I think it's more likely than not we'll end up with a good favicon through fallback_to_host than this case.

Sign in to add a comment