New tab page does not navigate to a data url. |
|||||||
Issue description1. Type the following line to the omnibox: data:text/html,<body style="margin:0"><div style="margin:100px;border:2px solid red;border-radius:20px;width:100px;height:200px;background-color:pink"/></body> 2. Make open the new tab page 3. Click the the page link for the dataurl. Nothing happens.
,
Dec 18
Can you provide more details on this bug? I can enter the data line in the omnibox and hit enter to display a pink box. Then I open a new tab, which shows the new tab page. Then what?
,
Dec 18
Then you should have a tile for the dataurl page under the search box on the new tab page. Click it. It does nothing on click.
,
Dec 18
Can you clarify how do you do the step 2 ?
,
Dec 18
I don't think it matters. I close and reopen Chromium. I think you can just open a new tab. You just need to make it show the dataurl page among the most used pages.
,
Dec 18
I verified that data:text/html,<body style="margin:0"><div style="margin:100px;border:2px solid red;border-radius:20px;width:100px;height:200px;background-color:pink"/></body> works from omnibox but does nothing from custom links. kristipark@ what do you think?
,
Dec 18
data URLs are not supported for Most Visited sites. This is intended behavior, as this protects against potentially malicious sites. The Most Visited tile will still be shown, but it will be unclickable.
,
Dec 18
Does it make sense to add them to the most visited?
,
Dec 18
+mathp Since the tiles are modifiable now, it'll probably be good to revisit the TopSites filter (server suggestions might be okay?). Right now, it uses HistoryBackendClient::IsWebSafe, which does allow data URLs. The filter can be updated to a whitelist of only http, https, ftp, and chrome-extension. WDYT Mathieu?
,
Dec 21
I don't have a strong opinion, but I think it would be reasonable to only support HTTP/HTTPS on new tab page tiles.
,
Dec 21
Should we reopen the issue?
,
Dec 21
Re-opening to only support http, https, ftp, and chrome-extension for TopSites.
,
Dec 21
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by twelling...@chromium.org
, Dec 18