New issue
Advanced search Search tips

Issue 915325 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

chrome://extensions: "Allow on all websites" is confusing

Project Member Reported by ddorwin@chromium.org, Dec 14

Issue description

When an extension only requests permission to run on specific sites, the chrome://extensions UI in M73 says:

Allow on all websites
   <site1>
   <site2>

Each line has a toggle.

It's not obvious that the main toggle ("Allow on all websites") means allow on the sites below. Assuming that is the meaning of this toggle, the string should be updated to clarify this for users.

Much less important: It might be nice to provide more guidance on how to enable specific sites or even change the UI so that it is more natural to find.


Note: The M73 UI is much improved over M70-71, which show:
"Allow this extension to read and change all your data on websites you visit: On all sites"
and provide no indication of the sites to which the extension is restricted.
 
Components: -UI>Settings UI>Browser>ExtensionsManagement
Cc: rdevlin....@chromium.org
Cc: -rdevlin....@chromium.org jawag@chromium.org bklmn@chromium.org
Labels: Proj-Crx-Cts OS-Android OS-Linux OS-Mac OS-Windows
Owner: rdevlin....@chromium.org
Status: Assigned (was: Untriaged)
Agreed - we're looking at rephrasing this.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14b26cddcaa9659bb8a41643633f5aa392726974

commit 14b26cddcaa9659bb8a41643633f5aa392726974
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Thu Dec 27 22:28:28 2018

[Extensions Click-to-Script] Update strings in extensions page

Update the strings in the chrome://extensions page for extensions that
only require access to specific sites. This includes a new heading/
summary describing the section, and rephrasing from "Allow on all sites"
to "Automatically allow access on the following sites" to make it clear
that it can't run everywhere.

Bug:  915325 
Change-Id: Ie052790ef1ca785c259929ce978ce0b6d81db49c
Reviewed-on: https://chromium-review.googlesource.com/c/1391322
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619076}
[modify] https://crrev.com/14b26cddcaa9659bb8a41643633f5aa392726974/chrome/app/md_extensions_strings.grdp
[modify] https://crrev.com/14b26cddcaa9659bb8a41643633f5aa392726974/chrome/browser/resources/md_extensions/host_permissions_toggle_list.html
[modify] https://crrev.com/14b26cddcaa9659bb8a41643633f5aa392726974/chrome/browser/ui/webui/extensions/extensions_ui.cc

Status: Fixed (was: Assigned)

Sign in to add a comment