New issue
Advanced search Search tips

Issue 915311 link

Starred by 1 user
Status: Fixed
Owner:
lamontjones@google.com
Closed: Dec 15
Cc:
lamontjones@chromium.org
zamorzaev@chromium.org
athilenius@google.com
achuith@chromium.org
chromeos-continuous-integration-fire-hose@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

vmtest TypeError: list indices must be integers, not str

Project Member Reported by akes...@chromium.org, Dec 14 
See stacktrace in https://luci-logdog.appspot.com/logs/chromeos/buildbucket/cr-buildbucket.appspot.com/8927169078844037824/+/steps/VMTest__attempt_1_/0/stdout (from https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8927169078844037824)


likely introduced by https://chromium-review.googlesource.com/1357180

 File "/b/swarming/w/ir/cache/cbuild/repository/chromite/cbuildbot/stages/generic_stages.py", line 704, in Run
    self.PerformStage()
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/cbuildbot/stages/vm_test_stages.py", line 290, in PerformStage
    self._RunTest(vm_test, per_test_results_dir)
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/cbuildbot/stages/vm_test_stages.py", line 226, in _RunTest
    RunCrosVMTest(self._current_board, self.GetImageDirSymlink())
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/cbuildbot/stages/vm_test_stages.py", line 780, in RunCrosVMTest
    test.Run()
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/cli/command_vm_test.py", line 265, in Run
    self.SetUp()
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/cli/command_vm_test.py", line 103, in SetUp
    image=self.image_path, board=self.board, updatable=True)
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/lib/vm.py", line 87, in CreateVMImage
    not updatable or VMIsUpdatable(src_path))
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/lib/vm.py", line 53, in VMIsUpdatable
    return table['ROOT-B'].size == table['ROOT-A'].size
TypeError: list indices must be integers, not str

Comment 1 by akes...@chromium.org, Dec 14 

Unclear if this is the root cause of the linked failure, or just another error on top that is making the root cause. Still, this needs to be resolved.

Comment 2 by akes...@chromium.org, Dec 14

Owner: lamontjones@google.com

Comment 3 by akes...@chromium.org, Dec 14

Cc: lamontjones@chromium.org

Comment 4 by lamontjones@google.com, Dec 14 

I believe this was actually introduced in https://chromium-review.googlesource.com/1359008 and the fix is to change the usage in vm.py.  See https://chromium-review.googlesource.com/1378785
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/62f4ccd8000d65ed3640e65465d905ad1bd2d78c

commit 62f4ccd8000d65ed3640e65465d905ad1bd2d78c
Author: LaMont Jones <lamontjones@chromium.org>
Date: Sat Dec 15 06:40:48 2018

vm: GetImageDiskPartitionInfo returns a list now.

Introduced in https://chromium-review.googlesource.com/1359008 when
GetImageDiskPartitionInfo was changed to return a list instead of one of
two differenct dictionaries.

BUG= chromium:915311 
TEST=Manually verified function behaves correctly.

Change-Id: I2480a31160c83132ccf5f38fb3b3f577220e98e0
Reviewed-on: https://chromium-review.googlesource.com/1378785
Commit-Ready: LaMont Jones <lamontjones@chromium.org>
Tested-by: LaMont Jones <lamontjones@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/62f4ccd8000d65ed3640e65465d905ad1bd2d78c/lib/vm.py

Comment 6 by jclinton@chromium.org, Dec 15

Status: Fixed (was: Assigned)
►

Sign in to add a comment