New issue
Advanced search Search tips

Issue 915304 link

Starred by 1 user
Status: Fixed
Owner:
ddorwin@chromium.org
Closed: Jan 12
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 920025



Sign in to add a comment

Remove Gamepad Extensions flag

Project Member Reported by ddorwin@chromium.org, Dec 14 
The Gamepad Extensions flag was originally added for  issue 628417 . Most of the features were only useful with WebVR, and those are obsoleted by WebXR's input solution. The `touched` attributed was added to the main Gamepad spec and is now enabled by default ( issue 830140 ).

Thus, there is no reason for this separate flag. We can move the WebVR-specific extensions to be controlled by the WebVR flag. Other browsers shipped these extensions along with WebVR, so there isn't much point in keeping them separate, and there isn't a risk of committing to these extensions since we are not going to ship WebVR.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0944894943b5e7c500f5d012227a29bf9f78244c

commit 0944894943b5e7c500f5d012227a29bf9f78244c
Author: David Dorwin <ddorwin@chromium.org>
Date: Fri Jan 11 23:37:30 2019

Remove Gamepad Extensions flag

The extensions are now enabled along with the WebVR flag.

There is still a separate Blink runtime feature (renamed to
WebVRGamepadSupport) for clarity in the IDL files, especially until
WebXR moves completely off Gamepad (https://crbug.com/920025).

Bug:  915304 
Test: blink/web_tests/http/tests/origin_trials/webexposed/{vr|xr}/
Change-Id: I8e5893bbb8de089dee8cf574c4bf4bba2206e9ef
Reviewed-on: https://chromium-review.googlesource.com/c/1401613
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622219}
[modify] https://crrev.com/0944894943b5e7c500f5d012227a29bf9f78244c/chrome/browser/about_flags.cc
[modify] https://crrev.com/0944894943b5e7c500f5d012227a29bf9f78244c/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/0944894943b5e7c500f5d012227a29bf9f78244c/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/0944894943b5e7c500f5d012227a29bf9f78244c/chrome/browser/vr/test/webvr_browser_test.h
[modify] https://crrev.com/0944894943b5e7c500f5d012227a29bf9f78244c/content/child/runtime_features.cc
[modify] https://crrev.com/0944894943b5e7c500f5d012227a29bf9f78244c/content/public/common/content_features.cc
[modify] https://crrev.com/0944894943b5e7c500f5d012227a29bf9f78244c/content/public/common/content_features.h
[modify] https://crrev.com/0944894943b5e7c500f5d012227a29bf9f78244c/third_party/blink/public/platform/web_runtime_features.h
[modify] https://crrev.com/0944894943b5e7c500f5d012227a29bf9f78244c/third_party/blink/renderer/modules/gamepad/gamepad.idl
[modify] https://crrev.com/0944894943b5e7c500f5d012227a29bf9f78244c/third_party/blink/renderer/modules/gamepad/gamepad_pose.idl
[modify] https://crrev.com/0944894943b5e7c500f5d012227a29bf9f78244c/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/0944894943b5e7c500f5d012227a29bf9f78244c/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify] https://crrev.com/0944894943b5e7c500f5d012227a29bf9f78244c/third_party/blink/web_tests/http/tests/origin_trials/webexposed/xr/webvr-gamepad-origin-trial-interfaces.html

Comment 2 by ddorwin@chromium.org, Jan 12

Labels: Target-73
Status: Fixed (was: Started)

Comment 3 by ddorwin@chromium.org, Jan 12

Blocking: 920025
►

Sign in to add a comment