Scheduler refactor breaks Lighthouse in DevTools |
||||||||||
Issue descriptionChrome Version: Version 73.0.3640.0 (Official Build) canary (64-bit) OS: Win, Mac, Chrome, Linux What steps will reproduce the problem? (1) Run Chrome with --enable-features=BlinkMainThreadUsesSequenceManager (2) Open google.com, DevTools, Audits panel, run audit. What is the expected result? A number for each category. No audits have Errors. What happens instead? No score for Performance / PWA categories. Many Errors. The "BlinkMainThreadUsesSequenceManager" feature is currently under a Finch trial at 50%, so half of clients across Canary / Dev Chrome will experience this issue with Lighthouse in DevTools. GitHub issue: https://github.com/GoogleChrome/lighthouse/issues/6811 Thread on scheduler-dev: https://groups.google.com/a/chromium.org/forum/#!topic/scheduler-dev/L8bH-sE43X4/discussion
,
Dec 14
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e587cacb10b4b7b703659ed3db46e015767fe7c commit 5e587cacb10b4b7b703659ed3db46e015767fe7c Author: Paul Irish <paulirish@chromium.org> Date: Mon Dec 17 20:10:51 2018 sequence_manager: Add task traceevent for Lighthouse in message pump Bug: 915301, 874982 Change-Id: I1d67781b0a2da5a6682d4d2514feaedbfd641720 Reviewed-on: https://chromium-review.googlesource.com/c/1378815 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#617204} [modify] https://crrev.com/5e587cacb10b4b7b703659ed3db46e015767fe7c/base/task/sequence_manager/thread_controller_with_message_pump_impl.cc
,
Dec 18
Able to reproduce this issue on Windows 10, Mac OS 10.13.6 and Ubuntu 14.04 on the reported version 73.0.3640.0 and the issue is fixed on the latest M-73 build 73.0.3644.0. 1. Launched Chrome from terminal with --enable-features=BlinkMainThreadUsesSequenceManager. 2. Opened google.com, navigated Devtools -> Audits -> run audit. 3. Could observe no error on audits page. Attached is the screen cast for reference. Hence adding TE verified labels as the fix is working as intended. Thanks..
,
Dec 18
,
Dec 18
,
Dec 18
Merge approved for M72 branch: 3626
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba192d3e2ed2368379f858a1c8514ad82680f66b commit ba192d3e2ed2368379f858a1c8514ad82680f66b Author: Paul Irish <paulirish@chromium.org> Date: Tue Dec 18 20:46:13 2018 sequence_manager: Add task traceevent for Lighthouse in message pump TBR=paulirish@chromium.org (cherry picked from commit 5e587cacb10b4b7b703659ed3db46e015767fe7c) Bug: 915301, 874982 Change-Id: I1d67781b0a2da5a6682d4d2514feaedbfd641720 Reviewed-on: https://chromium-review.googlesource.com/c/1378815 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#617204} Reviewed-on: https://chromium-review.googlesource.com/c/1383146 Reviewed-by: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#446} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/ba192d3e2ed2368379f858a1c8514ad82680f66b/base/task/sequence_manager/thread_controller_with_message_pump_impl.cc
,
Dec 19
Able to reproduce this issue on Windows 10, Mac OS 10.13.6 and Ubuntu 14.04 on the reported version 73.0.3640.0 and the issue is still reproducible on the latest M-72 build 72.0.3626.28 on Windows 10 and Ubuntu 14.04. Note: Issues seems to be fixed on Mac OS 10.13.6 on 72.0.3626.28 1. Launched Chrome from terminal with --enable-features=BlinkMainThreadUsesSequenceManager. 2. Opened google.com, navigated Devtools -> Audits -> run audit. 3. Could observe errors on audit page. Attached are the screenshots for reference. paulirish@ Request you to check and confirm if anything is missed and help in verifying the fix on the latest M-72 build. Thanks..
,
Dec 19
paulirish@, seems to be OOO rest of the year. altimin@ (reviewer), can you please validate the c#9? Thank you!
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba192d3e2ed2368379f858a1c8514ad82680f66b Commit: ba192d3e2ed2368379f858a1c8514ad82680f66b Author: paulirish@chromium.org Commiter: paulirish@chromium.org Date: 2018-12-18 20:46:13 +0000 UTC sequence_manager: Add task traceevent for Lighthouse in message pump TBR=paulirish@chromium.org (cherry picked from commit 5e587cacb10b4b7b703659ed3db46e015767fe7c) Bug: 915301, 874982 Change-Id: I1d67781b0a2da5a6682d4d2514feaedbfd641720 Reviewed-on: https://chromium-review.googlesource.com/c/1378815 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#617204} Reviewed-on: https://chromium-review.googlesource.com/c/1383146 Reviewed-by: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#446} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Dec 20
Re #10: The cherry-pick in #11 should do the trick. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by paulir...@chromium.org
, Dec 14Components: -Platform>Apps>DevTools Platform>DevTools
Labels: -Pri-3 Pri-2
Owner: paulir...@chromium.org
Status: Assigned (was: Untriaged)