New issue
Advanced search Search tips

Issue 915288 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 7
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task



Sign in to add a comment

Remove brillo/bind_lambda.h

Project Member Reported by hidehiko@chromium.org, Dec 14

Issue description

By libchrome uprev to r456626, now Bind in libchrome supports binding lambda (without capture), and along with the change, brillo/bind_lambda.h is now empty.
Let's remove it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/ap/+/d76fd4783b336352bd10cb2ffd9f26e01c4b69f8

commit d76fd4783b336352bd10cb2ffd9f26e01c4b69f8
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Wed Dec 19 12:12:47 2018

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/vendor/qca-hal/+/5f4d0e625b24346a71a9f65eb04e489f329663f1

commit 5f4d0e625b24346a71a9f65eb04e489f329663f1
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Wed Dec 19 12:12:47 2018

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/ap-daemons/+/b006320b48775d289ce1a152062ff87fa44f7b04

commit b006320b48775d289ce1a152062ff87fa44f7b04
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Wed Dec 19 12:12:48 2018

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/ap/wireless/+/fb07d748362be4125ac6fb06166c6bb1ec27eb81

commit fb07d748362be4125ac6fb06166c6bb1ec27eb81
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Wed Dec 19 12:12:47 2018

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/platform/drivefs/+/c39dfdfe8c052d1086df22e7c3f3b35ad74d4789

commit c39dfdfe8c052d1086df22e7c3f3b35ad74d4789
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Wed Dec 19 21:03:04 2018

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/5e7cd3195062b38e62ab44c56eba2ca62c8499a4

commit 5e7cd3195062b38e62ab44c56eba2ca62c8499a4
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Thu Dec 20 10:56:01 2018

Remove brillo/bind_lambda.h

The file is now empty.

BUG= chromium:915288 
TEST=Run try.

Change-Id: I2c9c0b96e8e1e6380230f8301584d251bc23d9c7
Reviewed-on: https://chromium-review.googlesource.com/1379630
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>

[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/tpm_manager/server/dbus_service_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/libbrillo/brillo/dbus/dbus_signal_handler.h
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/tpm_manager/client/tpm_nvram_dbus_proxy_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/tpm_manager/server/tpm_manager_service.h
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/trunks/trunks_dbus_proxy_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/cryptohome/tpm_manager_v2.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/vm_tools/notificationd/notification_daemon.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/bluetooth/common/exported_object_manager_wrapper_unittest.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/tpm_manager/client/tpm_ownership_dbus_proxy_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/buffet/manager.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/peerd/avahi_service_discoverer.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/attestation/client/dbus_proxy.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/diagnostics/diagnosticsd/diagnosticsd_grpc_service_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/libbrillo/brillo/message_loops/message_loop_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/libbrillo/brillo/dbus/dbus_signal_handler_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/cryptohome/challenge_credentials/challenge_credentials_test_utils.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/attestation/client/dbus_proxy_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/libbrillo/brillo/http/http_utils_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/trunks/trunks_dbus_service.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/tpm_manager/server/dbus_service.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/attestation/client/main.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/bluetooth/dispatcher/impersonation_object_manager_interface.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/tpm_manager/client/tpm_nvram_dbus_proxy.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/libbrillo/brillo/message_loops/fake_message_loop_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/libbrillo/brillo/dbus/dbus_method_invoker_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/ml/model_impl_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/peerd/avahi_service_publisher.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/bluetooth/common/property_unittest.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/tpm_manager/server/tpm_manager_service.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/libbrillo/brillo/streams/stream_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/diagnostics/dpsl/internal/dpsl_requester_impl.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/attestation/common/tpm_utility_v2.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/attestation/server/attestation_service.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/attestation/server/dbus_service.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/tpm_manager/client/main.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/libbrillo/brillo/streams/fake_stream_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/bluetooth/dispatcher/object_manager_interface_multiplexer_unittest.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/ml/machine_learning_service_impl_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/buffet/socket_stream.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/media_perception/media_perception_impl_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/cryptohome/tpm2_impl.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/diagnostics/diagnosticsd/diagnosticsd_core.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/libbrillo/brillo/http/http_request_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/virtual_file_provider/operation_throttle_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/attestation/server/attestation_service_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/cryptohome/service_unittest.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/trunks/tpm_state_impl.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/libbrillo/brillo/http/http_transport_curl_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/diagnostics/diagnosticsd/fake_browser.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/attestation/server/attestation_service.h
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/tpm_manager/client/tpm_ownership_dbus_proxy.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/ml/graph_executor_impl_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/trunks/trunks_dbus_proxy.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/attestation/server/dbus_service_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/trunks/trunks_factory_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/libbrillo/brillo/process_reaper_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/cryptohome/bootlockbox/tpm2_nvspace_utility.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/trunks/trunks_client_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/bluetooth/dispatcher/impersonation_object_manager_interface_unittest.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/libbrillo/brillo/http/http_transport_fake.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/libbrillo/brillo/message_loops/message_loop_utils.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/libbrillo/brillo/http/http_connection_fake.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/cryptohome/service_distributed.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/diagnostics/diagnosticsd/bind_utils.h
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/libbrillo/brillo/streams/file_stream_test.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/cryptohome/homedirs.cc
[modify] https://crrev.com/5e7cd3195062b38e62ab44c56eba2ca62c8499a4/diagnostics/diagnosticsd/diagnosticsd_core_test.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/update_engine/+/8cb948377fdb159f701ca3fd7513ddcb5ca6f33d

commit 8cb948377fdb159f701ca3fd7513ddcb5ca6f33d
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Thu Dec 20 18:03:55 2018

Remove bind_lambda.h include directive.

Thanks to libchrome uprev, bind_lambda.h is no longer needed.
bind_lambda.h will be removed in upstream (Chrome OS repo),
after this CL is rolled into Chrome OS.

Bug: 121187572
Test: Treehugger.

BUG= chromium:915288 
TEST=Ran try.

Change-Id: Ifd7a89ad109dd09dc922e1cb749fab003e32cd2c
(cherry picked from commit 5a71c6027b962f539cc86f9445efb32a02723fb9)
Reviewed-on: https://chromium-review.googlesource.com/1384825
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>

[modify] https://crrev.com/8cb948377fdb159f701ca3fd7513ddcb5ca6f33d/update_attempter_android.cc
[modify] https://crrev.com/8cb948377fdb159f701ca3fd7513ddcb5ca6f33d/omaha_request_action_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7ef2d51ed181fca416f727402ae01caf77091799

commit 7ef2d51ed181fca416f727402ae01caf77091799
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Wed Jan 02 21:29:03 2019

libbrillo: Remove bind_lambda.h

The feature is supported by libchrome now.
The file is no longer needed.

BUG= chromium:915288 
TEST=Ran try.

Change-Id: I51b6d45a321c1a359163de76e83f8f33d5f07800
Reviewed-on: https://chromium-review.googlesource.com/1387267
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>

[delete] https://crrev.com/ac27a33f9bc81f770e5f2774f578f96769daf5cd/libbrillo/brillo/bind_lambda.h

Status: Fixed (was: Untriaged)

Sign in to add a comment