New issue
Advanced search Search tips

Issue 915284 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MacViews] The Downloads Bar has an Inkdrop Effect on the File-More-Icon and Close Icon

Project Member Reported by meh...@chromium.org, Dec 14

Issue description

Chrome Version: Version 73.0.3640.0 
OS: macOS 10.14.2

What steps will reproduce the problem?
(1) Download something so that the Downloads Bar appears
(2) Now click on the File-More-Icon or the Close Icon

What is the expected result?
The icons should keep their size and have no Inkdrop effect.

What happens instead?
The icons are growing and showing an Inkdrop.

As far as I know and seeing currently on the Mac UI we hide all kind of Inkdrop effects.

Please feel free to close this report, if this is intended on the Downloads Bar for Mac.

Thanks :)
 
Downloads_bar.mov
1.8 MB View Download
Cc: -pbos@chromium.org
Owner: pbos@chromium.org
Status: Assigned (was: Untriaged)
I'll own all gross InkDrop things. :)
This also happen with the Close Button of the Info-Bar. Should I file a separate report for it? Thanks.
No separate thing required, I've a change ongoing that'll do sweeping changes. If you'd check again after I get that in it'd be very useful. :)
Of course, I'll do it then. Many thanks.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2

commit 9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2
Author: Peter Boström <pbos@chromium.org>
Date: Wed Jan 02 23:27:40 2019

Unify ink-drop style to flood fill with masks.

This change makes flood fill the default ink-drop style. Square InkDrops
are currently bugs in the browser that are kind-of hidden by InkDrop
masks.

It makes use of the same path that FocusRing uses for masks to make sure
that the InkDrop and FocusRing are in sync by default. These mismatch
bugs keep popping up, especially on Mac, as testers verify new parts of
the UI.

Follow-up changes will be to reduce the number of classes that override
CreateInkDrop methods and make sure that they explicitly request a
SquareInkDrop when they want it.

Bug: chromium:888204,  chromium:907833 ,  chromium:915284 

Change-Id: I681b93d6f5bdfe7f78421ebc8f2fbd522fb6eee4
Reviewed-on: https://chromium-review.googlesource.com/c/1367186
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619533}
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/download/download_item_view.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/download/download_item_view.h
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/hover_button.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/toolbar/browser_app_menu_button.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/toolbar/browser_app_menu_button.h
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/toolbar/toolbar_action_view.h
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/toolbar/toolbar_button.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/toolbar/toolbar_button.h
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.h
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/animation/ink_drop_host_view.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/animation/ink_drop_host_view.h
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/animation/ink_drop_impl.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/animation/ink_drop_impl.h
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/controls/button/button.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/controls/button/checkbox.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/controls/button/label_button.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/controls/button/label_button.h
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/controls/button/md_text_button.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/controls/button/md_text_button.h
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/controls/focus_ring.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/controls/focus_ring.h

Cc: phanindra.mandapaka@chromium.org
Labels: TE-Verified-M73 TE-Verified-73.0.3660.0
Able to reproduce this issue on Mac OS 10.14.0 on the reported version 73.0.3640.0 and the issue is fixed on the latest M-73 build 73.0.3660.0.

1. Launched Chrome
2. Downloaded one file and clicked on File-More-Icon and the Close Icon
As we have observed that The icons keep their size and have no Inkdrop effect.
Hence adding TE verified labels as the issue is working as expected.

Thanks..!
915284.mp4
632 KB View Download
Status: Verified (was: Assigned)
Thank you!

Sign in to add a comment