The close button of the Omnibox Doorhanger Menu flickers when you click on it |
|||
Issue descriptionChrome Version: Version 73.0.3640.0 OS: macOS 10.14.2 but probably OS=All What steps will reproduce the problem? (1) Click on the Lock icon or the Bookmarks Star icon on the Omnibox, so that the Menu appears (2) Now click and hold the close button (x) at the right top of the menu What is the expected result? The close button should keep the pressed state. What happens instead? The close button changes from the pressed state to the hover state. Not sure if this is intended. If not, then I think this is just only a polishing bug :) Thanks.
,
Dec 14
Am I reading this right as "holding LMB while still over the close-x icon does not sustain the pressed state of the inkdrop"?
,
Dec 14
Yes, correct. If you do the same on Tab Close Button or Toolbar Buttons, it sustain the pressed state while holding LMB. But I think the different here is, that the close button of the Doorhanger Menu has a InkDrop, which behaves this way. So please feel free to close this report :)
,
Dec 14
I think it's right and we shouldn't do that, so I'll keep it. Can't repro outside Mac though, and we do have some configuration differences. :)
,
Dec 14
Great, thank you :)
,
Jan 3
pbos@: Looks like https://chromium-review.googlesource.com/c/1367186 has also fixed this issue - thank you :) One question: Is it intended that the pressed state is now a bit darker (compared to the other elements like Tab Close Button or Bookmarks Bar Button or Toolbar Buttons? Attached a screenshot - the very right pressed button is the one from the doorhanger menu.
,
Jan 3
Sweet. I think it's a bug that they aren't the same, regardless of which final values we end up using (we might make the tab / bookmarks ones the global default). Could you file a new bug for this and assign it to me?
,
Jan 3
Great, thanks. For sure - I'll file one. |
|||
►
Sign in to add a comment |
|||
Comment 1 by meh...@chromium.org
, Dec 14133 KB
133 KB View Download