Why are metrics part of feedback on CrOS? |
||||||||
Issue descriptionSplitting off issue 907867: ... difference in feedback between crOS and desktop. Pranav, we were just talking about changing the feedback info on crOS. Can you speak to why metrics are only on cros and not desktop? Is that easy to change?
,
Jan 3
+afakhry@, +rkc@ for Feedback
,
Jan 7
I have no idea. This predates the time I started working on Feedback. rkc@ might know.
,
Jan 7
Michael, IIRC, you added this feature right?
,
Jan 7
Histograms were added to feedback reports on CrOS in issue 237288 so we could "check for anomalies as compared to median data". Zel made the call to keep the change CrOS-only. TBH, I don't know if anyone has made much use of histograms in feedback reports, so I can't really answer the "why".
,
Jan 7
I don't think anyone is looking at this data. It's theoretically useful, but likely to be pretty noisy. I think we should kill it if we don't have a clear use for it.
,
Jan 7
+1
,
Jan 7
If there's no use of the data and we remove this feature, that would make the other request in crbug.com/907867 less pressing which would be nice.
,
Jan 7
+1 to removing
,
Jan 8
Sounds like there is consensus to remove. Who's the best person to do the actual removal?
,
Jan 8
That would be me. :)
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffc0bb9b43023c171f5669aba5eb1c2911062f36 commit ffc0bb9b43023c171f5669aba5eb1c2911062f36 Author: Ahmed Fakhry <afakhry@chromium.org> Date: Wed Jan 09 01:43:18 2019 Remove histograms from feedback reports Histograms data were added to the feedback reports long time ago, but they're uncommonly checked and no good use for them has been found, hence removed. BUG= 915227 TEST=File a feedback report and make sure it ends up with no histogram data. Change-Id: Ie8e3540e7afa700ebf4b770c1cee7df729268081 Reviewed-on: https://chromium-review.googlesource.com/c/1401563 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#620988} [modify] https://crrev.com/ffc0bb9b43023c171f5669aba5eb1c2911062f36/chrome/app/generated_resources.grd [add] https://crrev.com/ffc0bb9b43023c171f5669aba5eb1c2911062f36/chrome/app/generated_resources_grd/IDS_FEEDBACK_INCLUDE_SYSTEM_INFORMATION_CHKBOX.png.sha1 [add] https://crrev.com/ffc0bb9b43023c171f5669aba5eb1c2911062f36/chrome/app/generated_resources_grd/IDS_FEEDBACK_INCLUDE_SYSTEM_INFORMATION_CHKBOX_ARC.png.sha1 [modify] https://crrev.com/ffc0bb9b43023c171f5669aba5eb1c2911062f36/chrome/browser/extensions/api/feedback_private/chrome_feedback_private_delegate.cc [modify] https://crrev.com/ffc0bb9b43023c171f5669aba5eb1c2911062f36/chrome/browser/resources/feedback/js/feedback.js [modify] https://crrev.com/ffc0bb9b43023c171f5669aba5eb1c2911062f36/components/feedback/feedback_data.cc [modify] https://crrev.com/ffc0bb9b43023c171f5669aba5eb1c2911062f36/components/feedback/feedback_data.h [modify] https://crrev.com/ffc0bb9b43023c171f5669aba5eb1c2911062f36/components/feedback/feedback_data_unittest.cc [modify] https://crrev.com/ffc0bb9b43023c171f5669aba5eb1c2911062f36/extensions/browser/api/feedback_private/feedback_private_api.cc [modify] https://crrev.com/ffc0bb9b43023c171f5669aba5eb1c2911062f36/extensions/browser/api/feedback_private/feedback_private_api.h [modify] https://crrev.com/ffc0bb9b43023c171f5669aba5eb1c2911062f36/extensions/common/api/feedback_private.idl
,
Jan 9
Thanks a lot, Ahmed! Is there any follow-up work to do or can we close out the bug?
,
Jan 9
We can close it out. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by tnagel@chromium.org
, Dec 14