Background of notification inline settings stays white |
|||
Issue descriptionChrome Version: 72.0.3626.14 OS: Linux What steps will reproduce the problem? (1) Show a new style notification (2) Click on the settings icon of the notification What is the expected result? The background should be gray, after a ripple animation. What happens instead? The background stays white. This is a regression, it is working fine in 71.0.3578.98. We do not have new style notifications enabled by default on Linux or Windows, but AFAIK it is used in ChromeOS? I've nailed it down to the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/1308099 Seems like that CL deletes and re-creates ripple effects on size changes, which breaks the way the ripple effect works when expanding the notification view to the inline settings.
,
Dec 14
Should be fixed after https://chromium-review.googlesource.com/c/chromium/src/+/1366492 knollr@ could you verify?
,
Dec 14
thomasanderson@ I just tried with the latest master, unfortunately the issue is still there.. I can try to look into it next week, I guess we should aim to get this into M-72 still? To reproduce this, you just need to set these flags on a Linux machine (I never tried ChromeOS, but it should be the default there): #enable-native-notifications -> Disabled #enable-message-center-new-style-notification -> Enabled
,
Dec 17
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03a2749a974e8ed5b5148768d86f8e7f7e2b70ec commit 03a2749a974e8ed5b5148768d86f8e7f7e2b70ec Author: Richard Knoll <knollr@chromium.org> Date: Wed Jan 09 17:45:04 2019 fix: NotificationViewMD resize ink_drop_layer and ink_drop_mask This is necessary as the default implementation of |InkDropHostView| now recreates its |InkDropRipple|. Bug: 915222 Change-Id: I8e607effccc3aefdfc178be3e7ff5faa512c0b41 Reviewed-on: https://chromium-review.googlesource.com/c/1395885 Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#621211} [modify] https://crrev.com/03a2749a974e8ed5b5148768d86f8e7f7e2b70ec/ui/message_center/views/notification_view_md.cc [modify] https://crrev.com/03a2749a974e8ed5b5148768d86f8e7f7e2b70ec/ui/message_center/views/notification_view_md.h
,
Jan 9
tetsui@ this is now fixed in master, do you think we should get this into M72? It affects inline settings of popup notifications in ChromeOS and got introduced in M72. |
|||
►
Sign in to add a comment |
|||
Comment 1 by knollr@chromium.org
, Dec 1415.0 KB
15.0 KB View Download