Add browser test for Payments upstream dialog in Butter mode |
|
Issue descriptionWe should add browser test coverage for the upstream dialog in Butter mode. Because the SaveCardBubble browsertest currently bypasses the sync setup altogether, this requires a significant refactoring [1], that had to be rolled back, because it introduced an issue on the official builders [2]. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1348335 [2]: https://bugs.chromium.org/p/chromium/issues/detail?id=908787
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c7b888872d7ff52174566eac03e74444dd5ec3a commit 6c7b888872d7ff52174566eac03e74444dd5ec3a Author: Florian Uunk <feuunk@chromium.org> Date: Wed Dec 19 17:39:04 2018 Reland Make SaveCardBubble browsertest use the sync state This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1348335. The additional fix is to turn on features::kAutofillUpstream explicitly in tests, because the flag is default disabled, and official builders don't use the fieldtrial config. Original desciption: The browsertests used to rely on the save manager being hardcoded to upload to Google if the observer_for_testing was set. This makes it impossible to test that the logic for showing the upload prompt works properly. BUG=915216 Change-Id: Ifcb89144a6924783161c2c0bfcf54af466e0ddb7 Reviewed-on: https://chromium-review.googlesource.com/c/1377426 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Florian Uunk <feuunk@chromium.org> Cr-Commit-Position: refs/heads/master@{#617867} [modify] https://crrev.com/6c7b888872d7ff52174566eac03e74444dd5ec3a/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc [modify] https://crrev.com/6c7b888872d7ff52174566eac03e74444dd5ec3a/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc [modify] https://crrev.com/6c7b888872d7ff52174566eac03e74444dd5ec3a/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h [modify] https://crrev.com/6c7b888872d7ff52174566eac03e74444dd5ec3a/components/autofill/core/browser/autofill_experiments.cc [modify] https://crrev.com/6c7b888872d7ff52174566eac03e74444dd5ec3a/components/autofill/core/browser/credit_card_save_manager.cc |
|
►
Sign in to add a comment |
|
Comment 1 by rouslan@chromium.org
, Dec 14