New issue
Advanced search Search tips

Issue 915211 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
dvadym@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

[Password Manager] The new parser doesn't propagate |generation_type| to votes

Project Member Reported by kolos@chromium.org, Dec 14 
|AutofillField::generation_type| stores 
* whether generation was triggered manually or automatically. 
* whether generation happened on a change password form. 
See PasswordGenerationType enum: https://cs.chromium.org/chromium/src/components/autofill/core/browser/proto/server.proto?rcl=cf9d9cc8503c2aaa67c759eaadaf1fc78afc4149&l=235

The ManualGeneration classifier needs |generation_type|.

Comment 1 by kolos@chromium.org, Dec 14 

The problem is that |PasswordManager::SetGenerationElementAndReasonForForm| doesn't support |NewPasswordFormManager|s, only old |PasswordFormManager|s.

Comment 2 by kolos@chromium.org, Dec 14 

Fortunately, the fix is easy: 
Replace |GetMatchingPendingManager| with |GetMatchedManager|.

However, test might be complicated.
►

Sign in to add a comment