New issue
Advanced search Search tips

Issue 915168 link

Starred by 2 users
Status: Assigned
Owner:
taku...@chromium.org
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression

Blocked on:
issue 754101


Sign in to add a comment

Regression : Grey focus highlight is not seen on 'Cast' icon in omnibox on opening cast overlay.

Reported by rp...@virtusa.com, Dec 14 
Chrome Version: 73.0.3639.1 (Official Build) Revision 5c6469ade1252bc3636320e8865710cb1bafa4ce-refs/branch-heads/3639@{#6}(32/64-bit)
OS: Windows (7,8,8.1,10),Mac OS X(10.14.2,10.13.1,10.13.6)and Linux(14.04 LTs).
             
Steps to reproduce:
1. Launch chrome, navigate to NTP and right click on page to open context menu
2. Now select 'Cast' from context menu items and observe 'Cast' icon in omnibox

Actual Result: Grey focus highlight is not seen on 'Cast' icon in omnibox on opening cast overlay
Expected Result: Grey focus highlight should be seen on 'Cast' icon in omnibox on opening cast overlay

This is a regression issue, broken in 'M-73', and will soon update other info :
Good Build:73.0.3638.0 (Revision:615717)
Bad Build: 73.0.3639.1 (Revision:616124)
Actual_video.mov
1.9 MB View Download
Expected_video.mov
2.5 MB View Download

Comment 1 by rp...@virtusa.com, Dec 14

Labels: hasbisect-per-revision
Owner: dfried@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 615968 (known good), but no later than 615969 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/ccb389f869494fa0abbe3e66fe1d181eaebe0e4f..9f1da68eb596d1eb1992c9cd910f2567375a69e1

Suspecting: https://chromium.googlesource.com/chromium/src/+/9f1da68eb596d1eb1992c9cd910f2567375a69e1

@dfried: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.	

Kindly refer the attached screen cast.

Thank You!

Comment 2 by dfried@chromium.org, Dec 18

Status: Started (was: Assigned)

Comment 3 by dfried@chromium.org, Dec 18

Owner: taku...@chromium.org
Status: Unconfirmed (was: Started)
This looks like it doesn't happen in latest? (I can't reproduce on Windows trunk as of about 3PM today.)

I'm not sure the current visual is completely correct (the button disappears immediately when the new dialog is closed) so I'm sending over to takumif@ for further triage.

Comment 4 by mpear...@chromium.org, Dec 18

Components: -UI>Browser>Omnibox Internals>Cast>UI UI>Browser
[omnibox triage; not a traditional omnibox issue]

Comment 5 by taku...@chromium.org, Jan 3

Blockedon: 754101
Labels: -Pri-1 Pri-3
Status: Assigned (was: Unconfirmed)
The Cast icon in the toolbar actions area will be replaced by one in the trusted icons area before M73 (issue 754101) which isn't affected by this bug.
►

Sign in to add a comment