New issue
Advanced search Search tips

Issue 915161 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 27
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Http auth saving should work with new parsing.

Project Member Reported by dvadym@chromium.org, Dec 14

Issue description

NewPasswordFormManager should support filling and saving on http authentication.
 
Labels: Merge-Request-72
We'd like to merge https://chromium-review.googlesource.com/c/chromium/src/+/1375951 to M-72. This is simple and not risky fix. I've tested it in Canary.

That CL was not committed on this bug, sorry, I forgot to add link to this bug in CL description. I'll add link to this bug during merge.
Project Member

Comment 2 by sheriffbot@chromium.org, Dec 19

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
dvadym@ is this change part of a feature going out in M72? 
yes, this is a part of the feature for M72. It's just a small fix for it.
Labels: -Merge-Review-72 Merge-Approved-72
branch:3626
Project Member

Comment 7 by sheriffbot@chromium.org, Dec 25

Cc: abdulsyed@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 27

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ba32a180b7964ad2b63a87f3af5739e6a77eccd

commit 3ba32a180b7964ad2b63a87f3af5739e6a77eccd
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Thu Dec 27 09:23:17 2018

Create PasswordFormManager for non-html forms.

NewPasswordFormManager doesn't support yet forms with non-html schemes.
These forms correspond to http authentication. The full implementation
is in progress
https://chromium-review.googlesource.com/c/chromium/src/+/1369796. This
CL is quick fix, just to use PasswordFormManager for such forms,
that allow to fix saving on http auth forms.

TBR=dvadym@chromium.org

(cherry picked from commit b95f5189e48619c2ee50571fd3c9b5f9aad3cbda)

Bug: 831123,  915161 
Change-Id: Id90f743ec8019df408f6daafa5634f17cdbf9bae
Reviewed-on: https://chromium-review.googlesource.com/c/1375951
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#617090}
Reviewed-on: https://chromium-review.googlesource.com/c/1391365
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#524}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/3ba32a180b7964ad2b63a87f3af5739e6a77eccd/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/3ba32a180b7964ad2b63a87f3af5739e6a77eccd/components/password_manager/core/browser/password_manager.cc

Status: Fixed (was: Started)
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/3ba32a180b7964ad2b63a87f3af5739e6a77eccd

Commit: 3ba32a180b7964ad2b63a87f3af5739e6a77eccd
Author: dvadym@chromium.org
Commiter: dvadym@chromium.org
Date: 2018-12-27 09:23:17 +0000 UTC

Create PasswordFormManager for non-html forms.

NewPasswordFormManager doesn't support yet forms with non-html schemes.
These forms correspond to http authentication. The full implementation
is in progress
https://chromium-review.googlesource.com/c/chromium/src/+/1369796. This
CL is quick fix, just to use PasswordFormManager for such forms,
that allow to fix saving on http auth forms.

TBR=dvadym@chromium.org

(cherry picked from commit b95f5189e48619c2ee50571fd3c9b5f9aad3cbda)

Bug: 831123,  915161 
Change-Id: Id90f743ec8019df408f6daafa5634f17cdbf9bae
Reviewed-on: https://chromium-review.googlesource.com/c/1375951
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#617090}
Reviewed-on: https://chromium-review.googlesource.com/c/1391365
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#524}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment