New issue
Advanced search Search tips

Issue 915155 link

Starred by 1 user
Status: Verified
Owner:
johntlee@chromium.org
Closed: Dec 18
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Search icon is seen misplaced with respect to text field on chrome://settings/content/all page.

Project Member Reported by dipt...@virtusa.com, Dec 14 
Chrome Version: 73.0.3640.0 Revision 5b7e7e2eb0db5bc8e13d3469c910b124225834bf-refs/branch-heads/3640@{#1}(32/64 bit)
OS: Windows(7,8,8.1,10),Mac(10.13.1,10.13.6,10.14.2)

Pre-condition: Enabled 'Site settings' flag from chrome://flags

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://settings/content/all page
(2) Observe text field and Search icon

Actual: Search icon is seen misplaced with respect to text field on chrome://settings/content/all page.

Expected: Search icon should not seen misplaced with respect to text field on chrome://settings/content/all page.

This is a regression issue, broken in 'M73', will soon update the other info:

Good Build:73.0.3638.0
Bad Build:73.0.3639.0
Actual_SearchIcon.mp4
517 KB View Download
Expected_SearchIcon.mp4
193 KB View Download

Comment 1 by dipt...@virtusa.com, Dec 14

Components: UI>Settings
Labels: hasbisect-per-revision
Owner: johntlee@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 615789 (known good), but no later than 615790 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/d867c4377115e2c0841460145ca43b964f13d5dc..f02c0f1a29ee970e07a9ac0d3bd0bb478116b4aa

Suspect: https://chromium.googlesource.com/chromium/src/+/f02c0f1a29ee970e07a9ac0d3bd0bb478116b4aa

@johntlee: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Comment 2 by dipt...@virtusa.com, Dec 14 

Correction:
Chrome Version:73.0.3639.1 (cohort: 71_Win_98)Revision5c6469ade1252bc3636320e8865710cb1bafa4ce-refs/branch-heads/3639@{#6}(32/64 bit)

Thank you.

Comment 3 by johntlee@chromium.org, Dec 14 

Fixed:
Screenshot from 2018-12-14 11-03-11.png
29.7 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b3ee2c10bef4b4690773c43967748cfce9c4a05

commit 4b3ee2c10bef4b4690773c43967748cfce9c4a05
Author: John Lee <johntlee@chromium.org>
Date: Tue Dec 18 03:55:38 2018

WebUI: Fix alignment of search icon on 'All sites' page

Bug:  915155 
Change-Id: I97696432e68f8318dc94892b4c0b0338317a34fb
Reviewed-on: https://chromium-review.googlesource.com/c/1378566
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617372}
[modify] https://crrev.com/4b3ee2c10bef4b4690773c43967748cfce9c4a05/ui/webui/resources/cr_elements/cr_search_field/cr_search_field.html

Comment 5 by dipt...@virtusa.com, Dec 18

Labels: TE-Verified-M73 TE-Verified-73.0.3644.0
Update:
Above issue is fixed on Canary build #73.0.3644.0 using Windows(7,8,8.1,10),Mac(10.13.1,10.13.6,10.14.2) and Linux(14.04 LTS) OS

Kindly refer attached screen cast for the same.

Thank you.
Fix_Issue.mp4
230 KB View Download

Comment 6 by johntlee@chromium.org, Dec 18

Status: Verified (was: Assigned)
►

Sign in to add a comment