Reflection blocking is broken. |
|||||||||
Issue descriptionThe reflection blocking for the invalidations is broken. This caused increase in the messages Sync clients are receiving and might resukt in a crash due to race condition.
,
Dec 14
,
Dec 14
,
Dec 15
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 17
Have you verified this in canary? How safe is the merge?
,
Dec 18
It's safe to merge. Yes, it's verified.
,
Dec 18
,
Dec 18
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10429bf2edd7f2c39a177782bc7244640f19f6e3 commit 10429bf2edd7f2c39a177782bc7244640f19f6e3 Author: Tanja Gornak <melandory@chromium.org> Date: Wed Dec 19 09:37:10 2018 [Tango->FCM] Repopulate client id on change Currently if the client id has changed sync machinery will discover that only after restart. This is bad, because for such clients reflection blocking won't work. This Cl introduce the mechanism to update the client id. Bug: 915152 Change-Id: Idf031aa23bb5a8a4cac7f9a30421e9b636711089 Reviewed-on: https://chromium-review.googlesource.com/c/1379954 Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Sergey Poromov <poromov@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#617778} [modify] https://crrev.com/10429bf2edd7f2c39a177782bc7244640f19f6e3/components/invalidation/impl/fcm_invalidation_service.cc [modify] https://crrev.com/10429bf2edd7f2c39a177782bc7244640f19f6e3/components/invalidation/impl/invalidator_registrar.cc [modify] https://crrev.com/10429bf2edd7f2c39a177782bc7244640f19f6e3/components/invalidation/impl/invalidator_registrar.h [modify] https://crrev.com/10429bf2edd7f2c39a177782bc7244640f19f6e3/components/invalidation/public/invalidation_handler.h [modify] https://crrev.com/10429bf2edd7f2c39a177782bc7244640f19f6e3/components/sync/driver/glue/sync_backend_host_core.cc [modify] https://crrev.com/10429bf2edd7f2c39a177782bc7244640f19f6e3/components/sync/driver/glue/sync_backend_host_core.h [modify] https://crrev.com/10429bf2edd7f2c39a177782bc7244640f19f6e3/components/sync/driver/glue/sync_backend_host_impl.cc [modify] https://crrev.com/10429bf2edd7f2c39a177782bc7244640f19f6e3/components/sync/driver/glue/sync_backend_host_impl.h [modify] https://crrev.com/10429bf2edd7f2c39a177782bc7244640f19f6e3/components/sync/engine/fake_sync_manager.cc [modify] https://crrev.com/10429bf2edd7f2c39a177782bc7244640f19f6e3/components/sync/engine/fake_sync_manager.h [modify] https://crrev.com/10429bf2edd7f2c39a177782bc7244640f19f6e3/components/sync/engine/sync_manager.h [modify] https://crrev.com/10429bf2edd7f2c39a177782bc7244640f19f6e3/components/sync/engine_impl/cycle/sync_cycle_context.h [modify] https://crrev.com/10429bf2edd7f2c39a177782bc7244640f19f6e3/components/sync/engine_impl/sync_manager_impl.cc [modify] https://crrev.com/10429bf2edd7f2c39a177782bc7244640f19f6e3/components/sync/engine_impl/sync_manager_impl.h
,
Dec 24
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 28
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 18
(4 days ago)
,
Today
(10 hours ago)
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 14