New issue
Advanced search Search tips

Issue 915105 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in payments::PaymentRequestState::RecordUseStats

Project Member Reported by ClusterFuzz, Dec 14

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6396634260570112

Fuzzer: mojo_fuzzer
Job Type: linux_asan_chrome_mojo
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  payments::PaymentRequestState::RecordUseStats
  payments::PaymentRequest::Complete
  payments::mojom::PaymentRequestStubDispatch::Accept
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mojo&range=587406:587417

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6396634260570112

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 14

Components: UI>Browser>Payments
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Dec 14

Labels: Test-Predator-Auto-Owner
Owner: leon....@intel.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8 ([OnionSoup] Move payment_{app,request}.mojom into blink/public/mojom/).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: gogerald@chromium.org rouslan@chromium.org
+payments experts for more insights.

I can not access the clusterfuzz page to see more details, but checked around the code logic and got a question which may be related to this bug:

The PaymentRequest::Init() execution may leave |state_| as nullptr at [1] without closing the Mojo binding, through which the other Mojo call PaymentRequest::Complete() may come and run to hit this null |state_|.
Furthermore, I checked all other Mojo calls on this binding, some (like PaymentRequest::Show()) are checking |state_|'s nullibity but some (like PaymentRequest::Abort()) are not. It seems to me we need to always do the check.

[1] https://cs.chromium.org/chromium/src/components/payments/content/payment_request.cc?rcl=60410c267a70f7f6b6013793a93540499c545adb&l=96

Cc: leon....@intel.com
Owner: rouslan@chromium.org
I'm making some improvements to that code's resilience in https://crrev.com/c/1370198. Let's wait for that to land and see how the fuzz-bot reacts. I will take this bug on myself, if you don't mind.
Ah, Nice, Thank you.
Project Member

Comment 6 by ClusterFuzz, Dec 15

ClusterFuzz has detected this issue as fixed in range 616819:616829.

Detailed report: https://clusterfuzz.com/testcase?key=6396634260570112

Fuzzer: mojo_fuzzer
Job Type: linux_asan_chrome_mojo
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  payments::PaymentRequestState::RecordUseStats
  payments::PaymentRequest::Complete
  payments::mojom::PaymentRequestStubDispatch::Accept
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mojo&range=587406:587417
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mojo&range=616819:616829

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6396634260570112

See https://github.com/google/clusterfuzz-tools for instructions to reproduce this bug locally.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Dec 15

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6396634260570112 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment