shaderc needs to be told where to find spirv-cross |
|
Issue descriptionshaderc is gaining a dependence on spirv-cross: https://github.com/google/shaderc/issues/526 In order order work with both the chrome build and the dawn stand-alone build we need a variable in build_overrides that gives the location of spirv-cross.
,
Dec 14
The following revision refers to this bug: https://dawn.googlesource.com/dawn/+/8d7de591f4c989ffdeca73d280ec00d4fb70a16c commit 8d7de591f4c989ffdeca73d280ec00d4fb70a16c Author: Frank Henigman <fjhenigman@chromium.org> Date: Fri Dec 14 20:33:50 2018 Tell shaderc where to find SPIRV-Cross. Set a variable in build_overrides that gives the location of shaderc's new SPIRV-Cross dependency. The variable will take a different value for a chrome build. BUG=chromium:915096 Change-Id: I92d29cee0bac4a968bffba5c2fd9bb02c040de52 Reviewed-on: https://dawn-review.googlesource.com/c/3301 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Frank Henigman <fjhenigman@chromium.org> [modify] https://crrev.com/8d7de591f4c989ffdeca73d280ec00d4fb70a16c/build_overrides/shaderc.gni
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af6c51a434cd28c23dc037296583fa178f1698e8 commit af6c51a434cd28c23dc037296583fa178f1698e8 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Dec 14 23:17:12 2018 Roll src/third_party/dawn 08aa58f8d6ed..8d7de591f4c9 (1 commits) https://dawn.googlesource.com/dawn.git/+log/08aa58f8d6ed..8d7de591f4c9 git log 08aa58f8d6ed..8d7de591f4c9 --date=short --no-merges --format='%ad %ae %s' 2018-12-14 fjhenigman@chromium.org Tell shaderc where to find SPIRV-Cross. Created with: gclient setdep -r src/third_party/dawn@8d7de591f4c9 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:915096 TBR=cwallez@chromium.org Change-Id: Ia4b74641dccd8b4842b2e01dee8de40f26e7f599 Reviewed-on: https://chromium-review.googlesource.com/c/1378828 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#616869} [modify] https://crrev.com/af6c51a434cd28c23dc037296583fa178f1698e8/DEPS |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, Dec 14