Refactor WprProxySimulatorTestRunner code in test_runner to be more modular |
|
Issue descriptionAs per Sergey's comments in https://chromium-review.googlesource.com/c/chromium/src/+/1374453 The loop in _run is very cumbersome and hard to parse, and it would be good to break it into separate components so it is easier to debug and understand. Additionally, we should break out the HTTPS cert installation so that other tests (not on WPR) can use it. We should also consider refactoring how get_launch_command is used so the WPR runner does not diverse so hard from other runners.
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44eaff37f31811d29726da2aeb723fd6bcf5043c commit 44eaff37f31811d29726da2aeb723fd6bcf5043c Author: Eric Aleshire <ericale@google.com> Date: Tue Dec 18 21:07:23 2018 Clean up code in WprProxySimulatorTestRunner. Splits up the _run function into a few smaller functions, making it easier to understand what's going on. Bug: 915055 Change-Id: I2266e85d79efd46812cda2486978110ce9e3a43a Reviewed-on: https://chromium-review.googlesource.com/c/1378807 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#617618} [modify] https://crrev.com/44eaff37f31811d29726da2aeb723fd6bcf5043c/ios/build/bots/scripts/test_runner.py |
|
►
Sign in to add a comment |
|
Comment 1 by jbudorick@chromium.org
, Dec 14