New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 915050 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows
Pri: 3
Type: Compat
Proj-VR



Sign in to add a comment

Convert XRCoordinateSystem/XRFrameOfReference to XRSpace/XRReferenceSpace

Project Member Reported by bajones@chromium.org, Dec 14

Issue description

The names and interaction model for the spatial tracking primitives in WebXR have changed in the spec, and Chrome's implementation needs to be updated to account for it.

See https://immersive-web.github.io/webxr/#spaces for details
 
Cc: jacde@chromium.org
 Issue 915014  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfd2d3689a60320a3df26edc1a2bf02d7fd21334

commit bfd2d3689a60320a3df26edc1a2bf02d7fd21334
Author: Brandon Jones <bajones@chromium.org>
Date: Thu Jan 03 20:47:54 2019

Replace XRCoodinateSystem/FrameOfReference with XRSpace/XRReferenceSpace

Updated to the newer types described by the latest WebXR Device API spec updates.

Bug: 915050
Change-Id: I14f07f922ff2eee046664bd9a6ecf1cf4e954312
Reviewed-on: https://chromium-review.googlesource.com/c/1377711
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619745}
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/chrome/test/data/xr/e2e_test_files/html/test_webxr_poses.html
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/chrome/test/data/xr/e2e_test_files/html/webxr_test_pose_data_unfocused_tab.html
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/chrome/test/data/xr/e2e_test_files/resources/webxr_boilerplate.js
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/event_target_modules_names.json5
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/modules_idl_files.gni
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/BUILD.gn
[add] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_bounded_reference_space.cc
[add] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_bounded_reference_space.h
[add] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_bounded_reference_space.idl
[delete] https://crrev.com/8992761a85d2389083c373c54f14008c8117065a/third_party/blink/renderer/modules/xr/xr_coordinate_system.h
[delete] https://crrev.com/8992761a85d2389083c373c54f14008c8117065a/third_party/blink/renderer/modules/xr/xr_coordinate_system.idl
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_frame.cc
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_frame.h
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_frame.idl
[delete] https://crrev.com/8992761a85d2389083c373c54f14008c8117065a/third_party/blink/renderer/modules/xr/xr_frame_of_reference.cc
[delete] https://crrev.com/8992761a85d2389083c373c54f14008c8117065a/third_party/blink/renderer/modules/xr/xr_frame_of_reference.h
[delete] https://crrev.com/8992761a85d2389083c373c54f14008c8117065a/third_party/blink/renderer/modules/xr/xr_frame_of_reference.idl
[delete] https://crrev.com/8992761a85d2389083c373c54f14008c8117065a/third_party/blink/renderer/modules/xr/xr_frame_of_reference_options.idl
[add] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_reference_space.cc
[add] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_reference_space.h
[add] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_reference_space.idl
[add] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_reference_space_options.idl
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_session.cc
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_session.h
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_session.idl
[rename] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_space.cc
[add] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_space.h
[add] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_space.idl
[add] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_stationary_reference_space.cc
[add] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_stationary_reference_space.h
[add] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_stationary_reference_space.idl
[add] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_unbounded_reference_space.cc
[add] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_unbounded_reference_space.h
[add] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/renderer/modules/xr/xr_unbounded_reference_space.idl
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/web_tests/external/wpt/webxr/idlharness.https.window-expected.txt
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/web_tests/external/wpt/webxr/xrSession_requestAnimationFrame_data_valid.https.html
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/web_tests/external/wpt/webxr/xrSession_requestAnimationFrame_getViewerPose.https.html
[delete] https://crrev.com/8992761a85d2389083c373c54f14008c8117065a/third_party/blink/web_tests/external/wpt/webxr/xrSession_requestFrameOfReference.https.html
[add] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/web_tests/external/wpt/webxr/xrSession_requestReferenceSpace.https.html
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/web_tests/xr/ar_hittest.html
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/web_tests/xr/getInputPose_hand.html
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/web_tests/xr/getInputPose_ray.html
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/web_tests/xr/xrSession_requestAnimationFrame_timestamp.html
[rename] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/web_tests/xr/xrStationaryReferenceSpace_floorlevel_updates.html
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/web_tests/xr/xrView_match.html
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/web_tests/xr/xrView_oneframeupdate.html
[modify] https://crrev.com/bfd2d3689a60320a3df26edc1a2bf02d7fd21334/third_party/blink/web_tests/xr/xrViewport_valid.html

Sign in to add a comment