Testing of building angle with the new toolchain shows no problems.

All four reported bugs are fixed or have fixes in progress.

Note from 915045:

> Go ahead and reland after the holidays (just speaking for this road block). Due to vacation, there will be proper monitoring of the V8 deps rolls first after Jan 6.

This is now ready to land (all known breaks are fixed) but I'm inclined to wait until next week to try landing it. I probably won't wait until the 7th, but waiting until the 2nd seems appropriate.

The CL to reland this is crrev.com/c/1377510

And it looks like we've got another blocker... ( crbug.com/915114 )

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a16f2ba48fc76eeb4a2812cc8f2d774a5c1f8c3

commit 2a16f2ba48fc76eeb4a2812cc8f2d774a5c1f8c3
Author: Bruce Dawson <brucedawson@chromium.org>
Date: Fri Jan 04 18:19:09 2019

Reland "ARM64 capable toolchain hash"

This is a reland of dd8c7b26d4da856b36edba4b2d8dff5a786d3eb4

Original change's description:
> ARM64 capable toolchain hash
>
> This updates Chrome to build with a toolchain based on VS 2017 15.9.3
> and the Windows 10.0.17763.132 SDK, with the ARM64 components included to
> support building for ARM64 for Win32. This adds about 400 MB to the package
> size, a bit less than a 50% increase.
>
> Packaging was done on a Windows Server 2016 VM, cleanly created for this
> purpose.
>
> The package was created by downloading VS 2017 Update 9.3, from
> https://www.visualstudio.com/vs/, and then running the installer like this:
>
> $ PATH_TO_INSTALLER.EXE ^
>     --add Microsoft.VisualStudio.Workload.NativeDesktop ^
>     --add Microsoft.VisualStudio.Component.VC.ATLMFC ^
>     --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^
>     --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^
>     --includeRecommended --passive
>
> Then Add or Remove Programs was used to modify the SDK to add the
> Debuggers package.
>
> Then the packaging script was run like this:
>
>   python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.17763.0
>
> This was tested on two VMs to ensure that the results are consistent.
>
> This should not significantly affect the x86 and x64 builds, although
> there may have been some STL and CRT changes that could cause changes.
>
> Bug: 893460
> Change-Id: I33dd5b915ffaf17f306d804f561d26bf82060b03
> Reviewed-on: https://chromium-review.googlesource.com/c/1342814
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#616123}

Bug: 893460, 915046 
Change-Id: I1f4f8fb7f37785ba935ef698964fa87f9a91e313
Reviewed-on: https://chromium-review.googlesource.com/c/1377510
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620001}
[modify] https://crrev.com/2a16f2ba48fc76eeb4a2812cc8f2d774a5c1f8c3/build/vs_toolchain.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8c851991162df9699b10ae29de9391adfc7eca4

commit b8c851991162df9699b10ae29de9391adfc7eca4
Author: Matthew Wolenetz <wolenetz@chromium.org>
Date: Fri Jan 04 19:35:46 2019

Revert "Reland "ARM64 capable toolchain hash""

This reverts commit 2a16f2ba48fc76eeb4a2812cc8f2d774a5c1f8c3.

Reason for revert: Strongly suspected as culprit for  bug 919163 : angle_deqp_gles2_d3d11_tests failing on chromium.gpu.fyi/Win7 FYI dEQP Release (AMD)

Original change's description:
> Reland "ARM64 capable toolchain hash"
> 
> This is a reland of dd8c7b26d4da856b36edba4b2d8dff5a786d3eb4
> 
> Original change's description:
> > ARM64 capable toolchain hash
> >
> > This updates Chrome to build with a toolchain based on VS 2017 15.9.3
> > and the Windows 10.0.17763.132 SDK, with the ARM64 components included to
> > support building for ARM64 for Win32. This adds about 400 MB to the package
> > size, a bit less than a 50% increase.
> >
> > Packaging was done on a Windows Server 2016 VM, cleanly created for this
> > purpose.
> >
> > The package was created by downloading VS 2017 Update 9.3, from
> > https://www.visualstudio.com/vs/, and then running the installer like this:
> >
> > $ PATH_TO_INSTALLER.EXE ^
> >     --add Microsoft.VisualStudio.Workload.NativeDesktop ^
> >     --add Microsoft.VisualStudio.Component.VC.ATLMFC ^
> >     --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^
> >     --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^
> >     --includeRecommended --passive
> >
> > Then Add or Remove Programs was used to modify the SDK to add the
> > Debuggers package.
> >
> > Then the packaging script was run like this:
> >
> >   python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.17763.0
> >
> > This was tested on two VMs to ensure that the results are consistent.
> >
> > This should not significantly affect the x86 and x64 builds, although
> > there may have been some STL and CRT changes that could cause changes.
> >
> > Bug: 893460
> > Change-Id: I33dd5b915ffaf17f306d804f561d26bf82060b03
> > Reviewed-on: https://chromium-review.googlesource.com/c/1342814
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#616123}
> 
> Bug: 893460, 915046 
> Change-Id: I1f4f8fb7f37785ba935ef698964fa87f9a91e313
> Reviewed-on: https://chromium-review.googlesource.com/c/1377510
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#620001}

TBR=thakis@chromium.org,dpranke@chromium.org,machenbach@chromium.org,brucedawson@chromium.org,scottmg@chromium.org

Change-Id: Ic032ab4307045ada9b2f6e0955bc4ad7dc8e84f8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 893460,  915046 ,  919163 
Reviewed-on: https://chromium-review.googlesource.com/c/1396560
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620030}
[modify] https://crrev.com/b8c851991162df9699b10ae29de9391adfc7eca4/build/vs_toolchain.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fe5e8635c22f578ae96fffbec0047fc4cd5098c

commit 1fe5e8635c22f578ae96fffbec0047fc4cd5098c
Author: Bruce Dawson <brucedawson@chromium.org>
Date: Wed Jan 09 23:51:03 2019

ARM64 capable toolchain with old d3dcompiler

This is a reland of crrev.com/c/1377510, with a new toolchain hash due to
packaging an old version of d3dcompiler_47.dll.

This updates Chrome to build with a toolchain based on VS 2017 15.9.3
and the Windows 10.0.17763.132 SDK, with the ARM64 components included to
support building for ARM64 for Win32. This adds about 400 MB to the package
size, a bit less than a 50% increase. This package contains the 17134 version
of d3dcompiler_47.dll, to avoid gaining a dependency on the universal CRT
which would cause problems for some Windows 7 machines ( bug 919163 ).

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

The package was created by downloading VS 2017 Update 9.3, from
https://www.visualstudio.com/vs/, and then running the installer like this:

$ PATH_TO_INSTALLER.EXE ^
    --add Microsoft.VisualStudio.Workload.NativeDesktop ^
    --add Microsoft.VisualStudio.Component.VC.ATLMFC ^
    --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^
    --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^
    --includeRecommended --passive

Then Add or Remove Programs was used to modify the SDK to add the
Debuggers package.

Then the packaging script was run like this:

  python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.17763.0

This was tested on two VMs to ensure that the results are consistent.

Since the new d3dcompiler_47.dll uses the UCRT and we want to avoid shipping
that the final packaging step was to unzip the package, copy over the two copies
of that DLL from win_sdk\Redist, and then repackage the toolchain with:
  > python package_from_installed.py --repackage=<full-path-to-toolchain-dir>

This should not significantly affect the x86 and x64 builds, although
there may have been some STL and CRT changes that could cause changes.

Bug: 893460,  915046 ,  919163 
Change-Id: I5891479863dd8371505ca9a4439f6939aa564ba8
Reviewed-on: https://chromium-review.googlesource.com/c/1401403
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621376}
[modify] https://crrev.com/1fe5e8635c22f578ae96fffbec0047fc4cd5098c/build/vs_toolchain.py

This seems to be sticking so I'm closing this as fixed. Follow-on work to upgrade d3dcompiler_47.dll is tracked in the newly opened crbug.com/920704