New issue
Advanced search Search tips

Issue 915034 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 877898
issue 907353



Sign in to add a comment

WebApp: Fix WebAppTabHelper edge cases

Project Member Reported by loyso@google.com, Dec 13

Issue description

WebAppTabHelperBase and derived classes maintain WebContents -> AppId association.

Currently, we don't set AppId right for the following cases:
- Tab Restore
- In-page WebApp Install (Uninstall?)
 
Blocking: 907353
Soft blocking 907353 (accuracy for histograms)
BookmarkAppTabHelper::GetExtension():

Always return non-null reference there with a CHECK inside. Provide guarantees that WebAppTabHelperBase::app_id_ is always up-to-date (subscribed to extensions and apps lifecycles, for example. Etc).
Blocking: 877898

Comment 4 by loyso@chromium.org, Yesterday (27 hours ago)

Status: Started (was: Assigned)

Sign in to add a comment