New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 18
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment
link

Issue 915031: Promote settings-subpage-search to cr-search-field

Reported by kelvinjiang@chromium.org, Dec 13 Project Member

Issue description

We should reuse the settings-subpage-search component for searching through activity logs (https://bugs.chromium.org/p/chromium/issues/detail?id=832354) as it provides the styling and functionality needed. As the component will now be used in two chrome:// pages, it will be moved to cr_elements and renamed as cr-search-field.
 

Comment 1 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f9392fa73c44640e4d1270d8d004f34a84badbf

commit 9f9392fa73c44640e4d1270d8d004f34a84badbf
Author: Kelvin Jiang <kelvinjiang@chromium.org>
Date: Fri Dec 14 03:58:29 2018

[WebUI] Promote settings-subpage-search to cr-search-field.

This CL migrates the search component that implements
CrSearchFieldBehavior into a shared component directory. This is
required for the activity log page under
chrome://extensions/?activity=<extension_id> to reuse the component for
searching through logs without having to create a duplicate component.

https://chromium-review.googlesource.com/c/chromium/src/+/1365031 will
be updated once this CL is submitted.

Bug:  915031 
Change-Id: I0da16636757313a5687068630ad2b60310fb7ec5
Reviewed-on: https://chromium-review.googlesource.com/c/1375455
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616579}
[modify] https://crrev.com/9f9392fa73c44640e4d1270d8d004f34a84badbf/chrome/browser/resources/settings/languages_page/BUILD.gn
[modify] https://crrev.com/9f9392fa73c44640e4d1270d8d004f34a84badbf/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
[modify] https://crrev.com/9f9392fa73c44640e4d1270d8d004f34a84badbf/chrome/browser/resources/settings/settings_page/BUILD.gn
[modify] https://crrev.com/9f9392fa73c44640e4d1270d8d004f34a84badbf/chrome/browser/resources/settings/settings_page/settings_subpage.html
[modify] https://crrev.com/9f9392fa73c44640e4d1270d8d004f34a84badbf/chrome/browser/resources/settings/settings_page/settings_subpage.js
[modify] https://crrev.com/9f9392fa73c44640e4d1270d8d004f34a84badbf/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/9f9392fa73c44640e4d1270d8d004f34a84badbf/chrome/browser/resources/settings/site_settings/BUILD.gn
[modify] https://crrev.com/9f9392fa73c44640e4d1270d8d004f34a84badbf/chrome/browser/resources/settings/site_settings/all_sites.html
[modify] https://crrev.com/9f9392fa73c44640e4d1270d8d004f34a84badbf/chrome/browser/resources/settings/site_settings/all_sites.js
[modify] https://crrev.com/9f9392fa73c44640e4d1270d8d004f34a84badbf/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/9f9392fa73c44640e4d1270d8d004f34a84badbf/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js
[add] https://crrev.com/9f9392fa73c44640e4d1270d8d004f34a84badbf/chrome/test/data/webui/cr_elements/cr_search_field_tests.js
[modify] https://crrev.com/9f9392fa73c44640e4d1270d8d004f34a84badbf/chrome/test/data/webui/settings/languages_page_tests.js
[modify] https://crrev.com/9f9392fa73c44640e4d1270d8d004f34a84badbf/chrome/test/data/webui/settings/settings_subpage_test.js
[modify] https://crrev.com/9f9392fa73c44640e4d1270d8d004f34a84badbf/ui/webui/resources/cr_elements/cr_search_field/BUILD.gn
[rename] https://crrev.com/9f9392fa73c44640e4d1270d8d004f34a84badbf/ui/webui/resources/cr_elements/cr_search_field/cr_search_field.html
[rename] https://crrev.com/9f9392fa73c44640e4d1270d8d004f34a84badbf/ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js
[modify] https://crrev.com/9f9392fa73c44640e4d1270d8d004f34a84badbf/ui/webui/resources/cr_elements_resources.grdp

Comment 2 by kelvinjiang@chromium.org, Dec 18

Status: Fixed (was: Untriaged)

Sign in to add a comment