New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 915021 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug
Proj-VR



Sign in to add a comment

Update XRViewerPose to match spec

Project Member Reported by jacde@chromium.org, Dec 13

Issue description

Update XRViewerPose interface to match latest spec outlined at https://immersive-web.github.io/webxr/#xrviewerpose-interface
 
Labels: Proj-XR
Labels: Target-73
Labels: -M-73
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9eb23defc881813572049b8e5903f24241bf55a

commit d9eb23defc881813572049b8e5903f24241bf55a
Author: Jacob DeWitt <jacde@chromium.org>
Date: Mon Jan 14 20:17:22 2019

Move views array from XRFrame to XRViewerPose.

This is to match the latest version of the web XR spec for XRViewerPose.

The getViewerPose method makes a copy of the session's views relative to the reference space it was
queried with and stores it in the returned XRViewerPose object.

Updated the layout tests that need to access the views array.
Some of those tests required further adjustment to get an XRReferenceSpace object to pass to getViewerPose.

Bug: 915021
Change-Id: Ib0a8203034780b3936cf2e2893dc529e240d6a48
Reviewed-on: https://chromium-review.googlesource.com/c/1399304
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622572}
[modify] https://crrev.com/d9eb23defc881813572049b8e5903f24241bf55a/third_party/blink/renderer/modules/xr/xr_frame.cc
[modify] https://crrev.com/d9eb23defc881813572049b8e5903f24241bf55a/third_party/blink/renderer/modules/xr/xr_frame.h
[modify] https://crrev.com/d9eb23defc881813572049b8e5903f24241bf55a/third_party/blink/renderer/modules/xr/xr_frame.idl
[modify] https://crrev.com/d9eb23defc881813572049b8e5903f24241bf55a/third_party/blink/renderer/modules/xr/xr_view.cc
[modify] https://crrev.com/d9eb23defc881813572049b8e5903f24241bf55a/third_party/blink/renderer/modules/xr/xr_view.h
[modify] https://crrev.com/d9eb23defc881813572049b8e5903f24241bf55a/third_party/blink/renderer/modules/xr/xr_view.idl
[modify] https://crrev.com/d9eb23defc881813572049b8e5903f24241bf55a/third_party/blink/renderer/modules/xr/xr_viewer_pose.cc
[modify] https://crrev.com/d9eb23defc881813572049b8e5903f24241bf55a/third_party/blink/renderer/modules/xr/xr_viewer_pose.h
[modify] https://crrev.com/d9eb23defc881813572049b8e5903f24241bf55a/third_party/blink/renderer/modules/xr/xr_viewer_pose.idl
[modify] https://crrev.com/d9eb23defc881813572049b8e5903f24241bf55a/third_party/blink/web_tests/external/wpt/webxr/idlharness.https.window-expected.txt
[modify] https://crrev.com/d9eb23defc881813572049b8e5903f24241bf55a/third_party/blink/web_tests/external/wpt/webxr/xrSession_requestAnimationFrame_data_valid.https.html
[modify] https://crrev.com/d9eb23defc881813572049b8e5903f24241bf55a/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/d9eb23defc881813572049b8e5903f24241bf55a/third_party/blink/web_tests/xr/xrView_match.html
[modify] https://crrev.com/d9eb23defc881813572049b8e5903f24241bf55a/third_party/blink/web_tests/xr/xrView_oneframeupdate.html
[modify] https://crrev.com/d9eb23defc881813572049b8e5903f24241bf55a/third_party/blink/web_tests/xr/xrViewport_valid.html
[modify] https://crrev.com/d9eb23defc881813572049b8e5903f24241bf55a/third_party/blink/web_tests/xr/xrWebGLLayer_viewport_scale.html

Sign in to add a comment