Update the NTP to reflect dark mode 1. Update the NTP background color to #323639 2. Background color of NTP shortcuts to Google grey 900
+Kristi FYI. More info at https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit#slide=id.g48a476f4a5_2_101
Is there a specific feature flag that dark mode is under?
I think on macOS Mojave there are two flags: - --force-dark-mode for dark appearance unconditionally - --enable-feature=DarkMode to track system dark mode status Please see https://bugs.chromium.org/p/chromium/issues/detail?id=850098#c38
Styling for dark mode MV tiles is complete, see attached screencast. Some of the colors for various active states were not specified (reorder, hover, etc), so I made a best guess.
I'll be happy to adjust any colors as necessary. Adjustments for the third-party NTP tiles is WIP.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1bff3ca6ed1e8afad1889a3c53a772c8518ae90 commit f1bff3ca6ed1e8afad1889a3c53a772c8518ae90 Author: Kristi Park <kristipark@chromium.org> Date: Wed Jan 16 22:59:23 2019 [NTP] Support dark mode for Most Visited tiles Add dark most support to the MV tiles. This includes the icons and various active states (i.e. hover, press, reorder, etc). (See bug for screencast) With theme: https://screenshot.googleplex.com/XdoVnwthRxr.png Also update the failed favicon style to match the new fallback monogram. https://screenshot.googleplex.com/DO0UxVUHm0m.png Bug: 914982 Change-Id: Ide7f14eabdf2feb3b697f2c6c05bf8c5b9838106 Reviewed-on: https://chromium-review.googlesource.com/c/1407204 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#623424} [add] https://crrev.com/f1bff3ca6ed1e8afad1889a3c53a772c8518ae90/chrome/browser/resources/local_ntp/icons/add_link_white.svg [modify] https://crrev.com/f1bff3ca6ed1e8afad1889a3c53a772c8518ae90/chrome/browser/resources/local_ntp/most_visited_single.css [modify] https://crrev.com/f1bff3ca6ed1e8afad1889a3c53a772c8518ae90/chrome/browser/resources/local_ntp/most_visited_single.js [modify] https://crrev.com/f1bff3ca6ed1e8afad1889a3c53a772c8518ae90/chrome/browser/resources/local_ntp_resources.grd [modify] https://crrev.com/f1bff3ca6ed1e8afad1889a3c53a772c8518ae90/chrome/browser/search/local_ntp_source.cc [modify] https://crrev.com/f1bff3ca6ed1e8afad1889a3c53a772c8518ae90/chrome/browser/search/most_visited_iframe_source.cc [modify] https://crrev.com/f1bff3ca6ed1e8afad1889a3c53a772c8518ae90/chrome/browser/search/ntp_icon_source.cc [modify] https://crrev.com/f1bff3ca6ed1e8afad1889a3c53a772c8518ae90/chrome/browser/ui/search/local_ntp_browsertest.cc
I noticed that the text and the apps icon on top right is still dark (on dark). Any plans to change it to a lighter font, too? Thanks :)
Yes, that component is part of the One Google Bar and is handled by an external team (tracked in https://crbug.com/918582).
Great, thank you.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0be89bd81621b65c6881a0aa15a6041ce76a8877 commit 0be89bd81621b65c6881a0aa15a6041ce76a8877 Author: Kristi Park <kristipark@chromium.org> Date: Thu Jan 17 22:08:46 2019 [NTP] Adjust MV tile dark mode colors and add color constants Adjust MV tile colors to match dark mode spec. Also add color constants for the Material Design color palette. Bug: 914982 Change-Id: I922c690354a8c40422c79bb282bac09a862a1c92 Reviewed-on: https://chromium-review.googlesource.com/c/1416815 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#623869} [modify] https://crrev.com/0be89bd81621b65c6881a0aa15a6041ce76a8877/chrome/browser/resources/local_ntp/icons/add_link_white.svg [modify] https://crrev.com/0be89bd81621b65c6881a0aa15a6041ce76a8877/chrome/browser/resources/local_ntp/most_visited_single.css
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60188c0c213eef3dc8fedb865921cd2a3461ecd5 commit 60188c0c213eef3dc8fedb865921cd2a3461ecd5 Author: Kristi Park <kristipark@chromium.org> Date: Fri Jan 18 02:49:24 2019 [NTP] Change Material Design colors to color constants Continuation of https://crrev.com/c/1416815. Set Material Design colors as color constants for all NTP components. Bug: 914982 Change-Id: Ia1cb82e221c0f0dc31562b55ccc88ab6e36f480d Reviewed-on: https://chromium-review.googlesource.com/c/1419200 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#623971} [add] https://crrev.com/60188c0c213eef3dc8fedb865921cd2a3461ecd5/chrome/browser/resources/local_ntp/constants.css [modify] https://crrev.com/60188c0c213eef3dc8fedb865921cd2a3461ecd5/chrome/browser/resources/local_ntp/custom_backgrounds.css [modify] https://crrev.com/60188c0c213eef3dc8fedb865921cd2a3461ecd5/chrome/browser/resources/local_ntp/custom_links_edit.css [modify] https://crrev.com/60188c0c213eef3dc8fedb865921cd2a3461ecd5/chrome/browser/resources/local_ntp/custom_links_edit.html [modify] https://crrev.com/60188c0c213eef3dc8fedb865921cd2a3461ecd5/chrome/browser/resources/local_ntp/local_ntp.css [modify] https://crrev.com/60188c0c213eef3dc8fedb865921cd2a3461ecd5/chrome/browser/resources/local_ntp/local_ntp.html [modify] https://crrev.com/60188c0c213eef3dc8fedb865921cd2a3461ecd5/chrome/browser/resources/local_ntp/most_visited_single.css [modify] https://crrev.com/60188c0c213eef3dc8fedb865921cd2a3461ecd5/chrome/browser/resources/local_ntp/most_visited_single.html [modify] https://crrev.com/60188c0c213eef3dc8fedb865921cd2a3461ecd5/chrome/browser/resources/local_ntp_resources.grd [modify] https://crrev.com/60188c0c213eef3dc8fedb865921cd2a3461ecd5/chrome/browser/search/local_ntp_source.cc [modify] https://crrev.com/60188c0c213eef3dc8fedb865921cd2a3461ecd5/chrome/browser/search/most_visited_iframe_source.cc
The NextAction date has arrived: 2019-01-22
Comment 1 by ramyan@chromium.org
, Dec 13Labels: OS-Chrome OS-Linux OS-Mac OS-Windows