+ccameron

I wonder if we just need to mark these as slow as well?  crbug.com/912364  had a very similar failure, after enabling OOP-D the test was timing out. For both cases we couldn't reproduce the failures on a 13" macbook pro running 10.14.

That would be a good way to confirm whether or not we have just made them slower, vs introducing bugs.

It looks like virtual/video-surface-layer/media/controls/modern/scrubbing.html is already marked slow on all platforms. However, I tried marking the other five tests as slow on mac and they no longer timed out in https://crrev.com/c/1382634.

I'm not sure what is going on in virtual/video-surface-layer/media/controls/modern/scrubbing.html yet. That still times out. I cannot reproduce the failure locally at all.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fddbbf41249123377a3c1bcad854e35263f59d1

commit 2fddbbf41249123377a3c1bcad854e35263f59d1
Author: kylechar <kylechar@chromium.org>
Date: Wed Dec 19 14:52:07 2018

Enable OOP-D by default on mac again.

Originally reverted for failing web tests. Mark some some web_tests that
were timing out 10.13 as slow.

For virtual/video-surface-layer/media/controls/modern/scrubbing.html
disable the test on mac. This test case times out even when marked as
slow. There are two other variations of the same test disabled on mac,
so this seems like a pre-existing problem.

Bug:  914981 
Change-Id: Ib0690f5fedf67d9e7736fdbada95a2aa9e73664d
Reviewed-on: https://chromium-review.googlesource.com/c/1382634
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617828}
[modify] https://crrev.com/2fddbbf41249123377a3c1bcad854e35263f59d1/components/viz/common/features.cc
[modify] https://crrev.com/2fddbbf41249123377a3c1bcad854e35263f59d1/third_party/blink/web_tests/SlowTests
[modify] https://crrev.com/2fddbbf41249123377a3c1bcad854e35263f59d1/third_party/blink/web_tests/TestExpectations

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94a4e076b8558595d85cbec6359d5c5931a39d18

commit 94a4e076b8558595d85cbec6359d5c5931a39d18
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu Dec 20 10:52:25 2018

[Sheriff] Turn off overflow-scrollability.html on mac

The test is flaky and times out occasionally.
It was introduced in CL:1382634.

TBR=ccameron@chromium.org,kylechar@chromium.org

Bug:  914981 , 916902
Change-Id: I2785c54c8b1933a221909afde06bf89aeca6412a
Reviewed-on: https://chromium-review.googlesource.com/c/1386145
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618161}
[modify] https://crrev.com/94a4e076b8558595d85cbec6359d5c5931a39d18/third_party/blink/web_tests/SlowTests
[modify] https://crrev.com/94a4e076b8558595d85cbec6359d5c5931a39d18/third_party/blink/web_tests/TestExpectations

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a21b38eea650148efb808817f56aa2e1bd605d9

commit 8a21b38eea650148efb808817f56aa2e1bd605d9
Author: kylechar <kylechar@chromium.org>
Date: Thu Jan 10 17:50:38 2019

OOP-D: Mark layout test as slow on mac.

There is one more layout tests that sometimes hit a timeout after
OOP-D was enabled by default. We already marked other versions of this
test as slow, so do the same for fast/events/no-fake-mousemove.html.

Bug:  914981 
Change-Id: Ieda7bf3c1b14f63493e7e3d9b7aba6bbfac28d98
Reviewed-on: https://chromium-review.googlesource.com/c/1405168
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621628}
[modify] https://crrev.com/8a21b38eea650148efb808817f56aa2e1bd605d9/third_party/blink/web_tests/SlowTests

crbug.com/916902 tracks one last failure but this is otherwise fixed.