New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 914978 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug
Proj-VR



Sign in to add a comment

Rename XRDevicePose to XRViewerPose

Project Member Reported by jacde@chromium.org, Dec 13

Issue description

Rename XRDevicePose to XRViewerPose and XRFrame.getDevicePose to XRFrame.getViewerPose to match the latest web XR public API standards documented at https://github.com/immersive-web/webxr/blob/master/explainer.md#appendix-b-proposed-idl
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0e5777b6203aaebf30596ba76c424626ae4a720

commit b0e5777b6203aaebf30596ba76c424626ae4a720
Author: Jacob DeWitt <jacde@chromium.org>
Date: Tue Dec 18 18:12:02 2018

Rename XRDevicePose to XRViewerPose

Update blink XR code files to rename XRDevicePose to XRViewerPose and
XRFrame.getDevicePose to XRFrame.getViewerPose.
This is one of several changes required to make Chromium conform to the latest
version of the web XR API standards, which are at:
https://github.com/immersive-web/webxr/blob/master/explainer.md#appendix-b-proposed-idl

This also required updating many test and expected test output files.
For example, global-interface-listing-expected.txt expected test output needs to
have interfaces and methods in alphabetical order.

Bug: 914978
Change-Id: I60801cab151ef44d9f88a59c1caed2d65def7b51
Reviewed-on: https://chromium-review.googlesource.com/c/1377142
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617565}
[modify] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/chrome/test/data/xr/e2e_test_files/html/test_webxr_poses.html
[modify] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/chrome/test/data/xr/e2e_test_files/html/webxr_test_pose_data_unfocused_tab.html
[modify] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/chrome/test/data/xr/e2e_test_files/resources/webxr_boilerplate.js
[modify] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/third_party/blink/renderer/modules/modules_idl_files.gni
[modify] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/third_party/blink/renderer/modules/xr/BUILD.gn
[modify] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/third_party/blink/renderer/modules/xr/xr_frame.cc
[modify] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/third_party/blink/renderer/modules/xr/xr_frame.h
[modify] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/third_party/blink/renderer/modules/xr/xr_frame.idl
[modify] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/third_party/blink/renderer/modules/xr/xr_session.cc
[modify] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/third_party/blink/renderer/modules/xr/xr_session.h
[rename] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/third_party/blink/renderer/modules/xr/xr_viewer_pose.cc
[rename] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/third_party/blink/renderer/modules/xr/xr_viewer_pose.h
[rename] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/third_party/blink/renderer/modules/xr/xr_viewer_pose.idl
[modify] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
[modify] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/third_party/blink/web_tests/external/wpt/webxr/idlharness.https.window-expected.txt
[modify] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/third_party/blink/web_tests/external/wpt/webxr/resources/webxr_util.js
[modify] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/third_party/blink/web_tests/external/wpt/webxr/xrSession_requestAnimationFrame_data_valid.https.html
[rename] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/third_party/blink/web_tests/external/wpt/webxr/xrSession_requestAnimationFrame_getViewerPose.https.html
[modify] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/third_party/blink/web_tests/xr/xrFrameOfReference_stage_updates.html
[modify] https://crrev.com/b0e5777b6203aaebf30596ba76c424626ae4a720/third_party/blink/web_tests/xr/xrSession_requestAnimationFrame_timestamp.html

Labels: Proj-XR
Labels: Target-73
Labels: -M-73

Sign in to add a comment