DCHECK in app_list::AppsGridView::IsPointWithinBottomDragBuffer() when dragging app list icon to shelf |
|||||||
Issue descriptionlinux-chromeos at ToT 7935e447796ae74eb3018c6de963a3d3f66e411a ninja -C out/Default -j 1000 -l 80 chrome && out/Default/chrome --ash-debug-shortcuts --ash-dev-shortcuts --ash-host-window-bounds="800+0-1024x768" --user-data-dir=/tmp/udd * Fully open app list * Start dragging any icon (towards the shelf) [138902:138902:1213/123439.898258:FATAL:apps_grid_view.cc(2210)] Check failed: kBottomDragBufferMax - kBottomDragBufferMin >= AppListConfig::instance().page_flip_zone_size() (12 vs. 20) #0 0x7ff7e742049f base::debug::StackTrace::StackTrace() #1 0x7ff7e734e5cb logging::LogMessage::~LogMessage() #2 0x7ff7d677fe5d app_list::AppsGridView::IsPointWithinBottomDragBuffer() #3 0x7ff7d6779bb2 app_list::AppsGridView::MaybeStartPageFlipTimer() #4 0x7ff7d677940a app_list::AppsGridView::UpdateDrag() #5 0x7ff7d677923d app_list::AppsGridView::UpdateDragFromItem() #6 0x7ff7d676c8c2 app_list::AppListItemView::OnMouseDragged() #7 0x7ff7e12b435f views::View::ProcessMouseDragged() #8 0x7ff7e12b3fbb views::View::OnMouseEvent() #9 0x7ff7e2da2b82 ui::ScopedTargetHandler::OnEvent() #10 0x7ff7e2d9cc63 ui::EventDispatcher::ProcessEvent() #11 0x7ff7e2d9ca79 ui::EventDispatcherDelegate::DispatchEventToTarget() #12 0x7ff7e2d9c9d0 ui::EventDispatcherDelegate::DispatchEvent() #13 0x7ff7e12bbdff views::internal::RootView::OnMouseDragged() #14 0x7ff7e12c1f54 views::Widget::OnMouseEvent() #15 0x7ff7e12e052f views::NativeWidgetAura::OnMouseEvent() #16 0x7ff7e2d9cc63 ui::EventDispatcher::ProcessEvent() #17 0x7ff7e2d9ca79 ui::EventDispatcherDelegate::DispatchEventToTarget() #18 0x7ff7e2d9c9d0 ui::EventDispatcherDelegate::DispatchEvent() #19 0x7ff7e2d9e722 ui::EventProcessor::OnEventFromSource() #20 0x7ff7e2d9ecfc ui::EventSource::SendEventToSinkFromRewriter() #21 0x7ff7e0a13ce0 ash::AshWindowTreeHostPlatform::DispatchEventFromQueue() #22 0x7ff7d684fde2 ws::HostEventQueue::DispatchOrQueueEvent() #23 0x7ff7e2da36b9 ui::DispatchEventFromNativeUiEvent() #24 0x7ff7e036f02e ui::X11WindowOzone::DispatchEvent() #25 0x7ff7e64b9933 ui::PlatformEventSource::DispatchEvent() #26 0x7ff7d65d6c79 ui::X11EventSourceLibevent::DispatchPlatformEvent() #27 0x7ff7d65d6721 ui::X11EventSourceLibevent::ProcessXEvent() #28 0x7ff7d65d1ae1 ui::X11EventSource::DispatchXEvents() #29 0x7ff7e74439dc base::MessagePumpLibevent::OnLibeventNotification() #30 0x7ff7e745aecd event_base_loop
,
Dec 13
I recently added this dcheck actually. I'll take a look.
,
Dec 14
I made this dcheck to guaruntee a minimum zone the user could drag an app to switch pages in the launcher. I am going to bump this to P-1 because it means users will have trouble switching pages while dragging apps in the launcher.
,
Dec 14
,
Dec 19
After talking to PM.
,
Dec 26
Removing Shelf component as nothing indicates a relationship to the shelf from the stack trace.
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e22d84179edf3bb043f7f39995877596587ec4e6 commit e22d84179edf3bb043f7f39995877596587ec4e6 Author: Alex Newcomer <newcomer@chromium.org> Date: Mon Jan 14 18:39:29 2019 cros: Remove unnecessary dcheck Removing a dcheck I added after it was not useful. Bug: 914961 Change-Id: Ib72853ec17880611936cf5e64e2d868d0a7cff96 Reviewed-on: https://chromium-review.googlesource.com/c/1407268 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Weidong Guo <weidongg@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#622529} [modify] https://crrev.com/e22d84179edf3bb043f7f39995877596587ec4e6/ash/app_list/views/apps_grid_view.cc
,
Jan 14
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by kaznacheev@chromium.org
, Dec 13Status: Assigned (was: Untriaged)