Per-CL coverage data is wrong |
|||
Issue descriptionCL https://chromium-review.googlesource.com/c/chromium/src/+/1375993/3 File: services/ws/window_tree.cc sky@ confirmed that the test triggers that path, but the code is still rendered as red. sky@ also suggested having some sort of help indicator that says why the text is red.
,
Dec 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/3179d48f73cb1745212be3bd7d496a9516d37057 commit 3179d48f73cb1745212be3bd7d496a9516d37057 Author: Yuke Liao <liaoyuke@chromium.org> Date: Sun Dec 16 20:58:11 2018 [code coverage] Parse coverage json sequentially The stack based segments parse method led to a few data mismatch bugs, so this CL switches to parse segments sequentially by following the the logic in llvm-cov's source code. Bug: 914955 Change-Id: I3cf161d5d23a4d4277e42531b6d7474fc8f8ee9b Reviewed-on: https://chromium-review.googlesource.com/c/1379488 Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/3179d48f73cb1745212be3bd7d496a9516d37057/scripts/slave/recipe_modules/clang_coverage/unittests/generate_coverage_metadata_test.py [modify] https://crrev.com/3179d48f73cb1745212be3bd7d496a9516d37057/scripts/slave/recipe_modules/clang_coverage/resources/generate_coverage_metadata.py
,
Dec 17
,
Dec 19
Chatted with sky@ offline, after the bug fixing, the new data looks correct now. Will close this bug, and open a new one for the "help indicator that says why the text is red" suggestion. |
|||
►
Sign in to add a comment |
|||
Comment 1 by st...@chromium.org
, Dec 13