New issue
Advanced search Search tips

Issue 914954 link

Starred by 2 users
Status: Fixed
Owner:
hiroh@chromium.org
Closed: Dec 14
Cc:
mcasas@chromium.org
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Crash during multiple HWDecoder related tests on chromeos chrome-pfq-informational bots

Project Member Reported by osh...@chromium.org, Dec 13 
(tricky-tot-chrome-pfq-informational, caroline-tot-chrome-pfq-informational)

Build:
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8927283719285139392

Log:
https://stainless.corp.google.com/browse/chromeos-autotest-results/266604510-chromeos-test/
(video_ChromeHWDecodeUsed.h264 is the failed test)

Regression range:
https://chromium.googlesource.com/chromium/src/+log/0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14..124d0d419086705a616b1039fb63067679886069?pretty=full


Here are CLs related to video:

https://chromium-review.googlesource.com/c/1375169 (hiroh@)
https://chromium-review.googlesource.com/c/1368590 (mcasas@)
https://chromium-review.googlesource.com/c/1374951 (mlamouri@)

hiroh@, can you look into this first.

Log message:
12/13 01:25:13.793 ERROR|   logging_manager:0626| tko parser: parsing partial test video_ChromeHWDecodeUsed.h264 video_ChromeHWDecodeUsed.h264
12/13 01:25:13.794 ERROR|   logging_manager:0626| tko parser: RUNNING: RUNNING
12/13 01:25:13.794 ERROR|   logging_manager:0626| Subdir: video_ChromeHWDecodeUsed.h264
12/13 01:25:13.794 ERROR|   logging_manager:0626| Testname: video_ChromeHWDecodeUsed.h264
12/13 01:25:13.794 ERROR|   logging_manager:0626| 
12/13 01:25:13.794 ERROR|   logging_manager:0626| tko parser: update RUNNING reason: GPU Video Decoder Error. Histogram diff: {4: 1}
12/13 01:25:13.794 ERROR|   logging_manager:0626| tko parser: parsing test video_ChromeHWDecodeUsed.h264 video_ChromeHWDecodeUsed.h264
12/13 01:25:13.795 ERROR|   logging_manager:0626| tko parser: ADD: ERROR
12/13 01:25:13.795 ERROR|   logging_manager:0626| Subdir: video_ChromeHWDecodeUsed.h264
12/13 01:25:13.795 ERROR|   logging_manager:0626| Testname: video_ChromeHWDecodeUsed.h264
12/13 01:25:13.795 ERROR|   logging_manager:0626| GPU Video Decoder Error. Histogram diff: {4: 1}
12/13 01:25:13.795 ERROR|   logging_manager:0626| tko parser: parsing test None CLIENT_JOB.0
12/13 01:25:13.795 ERROR|   logging_manager:0626| tko parser: ADD: GOOD
12/13 01:25:13.795 ERROR|   logging_manager:0626| Subdir: None
12/13 01:25:13.796 ERROR|   logging_manager:0626| Testname: CLIENT_JOB.0
12/13 01:25:13.796 ERROR|   logging_manager:0626| 
12/13 01:25:13.796 ERROR|   logging_manager:0626| tko parser: parsing test ---- SERVER_JOB
12/13 01:25:13.845 DEBUG|     ssh_multiplex:0156| Get master ssh connection for root@chromeos6-row2-rack23-host16:22
12/13 01:25:13.846 DEBUG|        servo_host:0839| No servo_args provided, and failed to find overrides.
12/13 01:25:14.283 DEBUG|             utils:0219| Running 'ping -c 3 chromeos6-row2-rack23-host16'
12/13 01:25:16.397 DEBUG|          ssh_host:0310| Running (ssh) 'python -c 'import cPickle, glob, sys;cPickle.dump(glob.glob(sys.argv[1]), sys.stdout, 0)'' from 'get_site_crashdumps|fetch_orphaned_crashdumps|_find_orphaned_crashdumps|list_files_glob|run|run_very_slowly'
12/13 01:25:16.921 INFO | site_crashcollect:0221| There are no orphaned crashes; deleting /usr/local/autotest/results/266604510-chromeos-test/chromeos6-row2-rack23-host16/crashinfo.chromeos6-row2-rack23-host16
12/13 01:25:16.924 INFO | site_crashcollect:0100| Trying to generate stack trace locally for /usr/local/autotest/results/266604510-chromeos-test/chromeos6-row2-rack23-host16/video_ChromeHWDecodeUsed.h264/sysinfo/iteration.1/var/spool/crash/chrome.20181213.012437.29300.dmp
12/13 01:25:16.924 INFO | site_crashcollect:0034| symbol_dir: /usr/local/autotest/server/../../../lib/debug
12/13 01:25:16.924 DEBUG|             utils:0219| Running 'minidump_stackwalk "/usr/local/autotest/results/266604510-chromeos-test/chromeos6-row2-rack23-host16/video_ChromeHWDecodeUsed.h264/sysinfo/iteration.1/var/spool/crash/chrome.20181213.012437.29300.dmp" "/usr/local/autotest/server/../../../lib/debug" > "/usr/local/autotest/results/266604510-chromeos-test/chromeos6-row2-rack23-host16/video_ChromeHWDecodeUsed.h264/sysinfo/iteration.1/var/spool/crash/chrome.20181213.012437.29300.dmp.txt"'
12/13 01:25:16.972 INFO | site_crashcollect:0107| Failed to generate stack trace locally for dump /usr/local/autotest/results/266604510-chromeos-test/chromeos6-row2-rack23-host16/video_ChromeHWDecodeUsed.h264/sysinfo/iteration.1/var/spool/crash/chrome.20181213.012437.29300.dmp (rc=127):
CmdError('minidump_stackwalk "/usr/local/autotest/results/266604510-chromeos-test/chromeos6-row2-rack23-host16/video_ChromeHWDecodeUsed.h264/sysinfo/iteration.1/var/spool/crash/chrome.20181213.012437.29300.dmp" "/usr/local/autotest/server/../../../lib/debug" > "/usr/local/autotest/results/266604510-chromeos-test/chromeos6-row2-rack23-host16/video_ChromeHWDecodeUsed.h264/sysinfo/iteration.1/var/spool/crash/chrome.20181213.012437.29300.dmp.txt"', * Command: 
    minidump_stackwalk "/usr/local/autotest/results/266604510-chromeos-test/c
    hromeos6-row2-rack23-host16/video_ChromeHWDecodeUsed.h264/sysinfo/iteratio
    n.1/var/spool/crash/chrome.20181213.012437.29300.dmp"
    "/usr/local/autotest/server/../../../lib/debug" >
    "/usr/local/autotest/results/266604510-chromeos-test/chromeos6-row2-rack23
    -host16/video_ChromeHWDecodeUsed.h264/sysinfo/iteration.1/var/spool/crash/
    chrome.20181213.012437.29300.dmp.txt"
Exit status: 127
Duration: 0.00209307670593
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57d51cc17e0e2c806d1b03eb6ce0905ed25f4cda

commit 57d51cc17e0e2c806d1b03eb6ce0905ed25f4cda
Author: Hirokazu Honda <hiroh@chromium.org>
Date: Fri Dec 14 00:34:41 2018

Revert "Vaapi: Use GUARDED_BY() static annotations on decoder"

This reverts commit 99e2d9e3cdba89a15ebd4890b2de37336963a0b0.

Reason for revert: This breaks Video Playback on intel devices

Original change's description:
> Vaapi: Use GUARDED_BY() static annotations on decoder
>
> This CL introduces GUARDED_BY() static annotation on VaVDA; not all
> members variables need to be guarded, so it adds on a number of them
> a comment about on which thread it is used.
>
> Bug:  909547 
> Change-Id: I437a82320795aebc56f77cd1254bb7c8c2f2f5da
> Reviewed-on: https://chromium-review.googlesource.com/c/1368590
> Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#616196}

TBR=mcasas@chromium.org,hiroh@chromium.org,dstaessens@chromium.org

Change-Id: I2e6496e9148f12d37f746a7d0b1e0e26cee70341
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  909547 ,  914954 
Reviewed-on: https://chromium-review.googlesource.com/c/1377470
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616522}
[modify] https://crrev.com/57d51cc17e0e2c806d1b03eb6ce0905ed25f4cda/media/gpu/vaapi/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/57d51cc17e0e2c806d1b03eb6ce0905ed25f4cda/media/gpu/vaapi/vaapi_video_decode_accelerator.h
[modify] https://crrev.com/57d51cc17e0e2c806d1b03eb6ce0905ed25f4cda/media/gpu/vaapi/vaapi_video_decode_accelerator_unittest.cc

Comment 2 by hiroh@chromium.org, Dec 14

Status: Fixed (was: Assigned)
I confirmed video playback becomes good after reverting above CL.

Thanks for reporting, oshima@.

Comment 3 by osh...@chromium.org, Dec 14 

Thank you for prompt fix!
►

Sign in to add a comment