New issue
Advanced search Search tips

Issue 914951 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

qscheduler: update accounts when receiving task notifications

Project Member Reported by akeshet@google.com, Dec 13

Issue description

In current behavior, accounts are only updated (via UpdateTime call on scheduler) when:
 - refresh cronjob runs, 1x per minute
 - AssignTasks is called

This means we fail to account for completion of tasks, if the task completion notification comes a bit earlier than the AssignTasks notification.

This can be easily remedied by:
 1) in reconciler.Notify: sort incoming notifications chronologically (if more than 1)
 2) call UpdateTime with the notification time, prior to applying the notification.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 15

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3c47d6e576d85508a1f3ac82a8199d92b1f81fd6

commit 3c47d6e576d85508a1f3ac82a8199d92b1f81fd6
Author: Aviv Keshet <akeshet@chromium.org>
Date: Sat Dec 15 01:08:21 2018

qscheduler: update scheduler time when handling task notifications

BUG= chromium:914951 
TEST=None

Change-Id: Ib2295306d23af37b5eff13175cd4e563232a318c
Reviewed-on: https://chromium-review.googlesource.com/c/1376800
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19584}
[modify] https://crrev.com/3c47d6e576d85508a1f3ac82a8199d92b1f81fd6/go/src/infra/qscheduler/qslib/reconciler/reconciler.go

Status: Fixed (was: Assigned)

Sign in to add a comment