Nebraska should check the platform app specifically when determining whether a request is an update or install. |
||
Issue descriptionAn install request is signaled by update_engine by omitting the update_check tag only in the app request for the platform app. That is, the update_engine sends a request with an update_check tag for every DLC appid that is to be intalled, and a request with no update_check tag for the platform appid. We currently have no way of determining which appid is associated with the platform app based purely on the contents of an incoming request, so we assume that a request is an install request if exactly one appid does not have an associated update_check tag. It may be possible in the future to differentiate the platform appid based on whether it has certain attributes (e.g. hardware_class, see go/omaha-changes-for-dlc). It is preferable to have Nebraska make these decisions using the same mechanisms as Omaha, so we should adopt this strategy here if we decide to implement it.
,
Dec 13
,
Dec 15
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/dev-util/+/7ad53a180b8e2b5865825c002c675f55d3b2b847 commit 7ad53a180b8e2b5865825c002c675f55d3b2b847 Author: Colin Howes <chowes@google.com> Date: Sat Dec 15 06:40:28 2018 nebraska: Clean up TODOs. Created bugs for TODOs and added links in comments. BUG=chromium:914939,chromium:914936 TEST=None Change-Id: I102d4dc5c985b31fbe5cc650d0433c18d397835f Reviewed-on: https://chromium-review.googlesource.com/1376660 Commit-Ready: Colin Howes <chowes@google.com> Tested-by: Colin Howes <chowes@google.com> Reviewed-by: Amin Hassani <ahassani@chromium.org> [modify] https://crrev.com/7ad53a180b8e2b5865825c002c675f55d3b2b847/nebraska/nebraska.py |
||
►
Sign in to add a comment |
||
Comment 1 by chowes@google.com
, Dec 13