New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 914926 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug



Sign in to add a comment

led get-build fails with error calling MarshalJSON for type cookflags.CookMode: unknown CookMode: 0

Project Member Reported by robertocn@google.com, Dec 13

Issue description

Here's the full command output:

[hi on] robertocn@traal:~/scrap/repro$ led get-build 8927287440026792704 > current.json
[I 2018-12-13 11:22:25] getting build definition
[I 2018-12-13 11:22:27] getting build definition: done
[I 2018-12-13 11:22:27] getting task definition: "41be75f63fa64c10"
[I 2018-12-13 11:22:28] getting task definition: done
[E 2018-12-13 11:22:28] original error: json: error calling MarshalJSON for type cookflags.CookMode: unknown CookMode: 0
[E 2018-12-13 11:22:28] 
 
This is blocking some work to more than one of us.

Is this fixable with something as simple as rolling some protos somewhere?
I'm seeing the exact same error:
led get-build 8927273631318906848
There was a change in kitchen protocol last evening; I'll roll a new version of led now, sorry for the trouble.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/f423e051f343631f92cd1f261168c5215f6dacf6

commit f423e051f343631f92cd1f261168c5215f6dacf6
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Dec 13 19:43:37 2018

[led] Update led to latest version.

This removes the '-mode' flag from the emitted job descriptions.

TBR=nodir@chromium.org

Bug:  914196 , 914926 
Change-Id: I94ab67f0969b198164fa3fc3ef64a649dcf941bd
Reviewed-on: https://chromium-review.googlesource.com/c/1376657
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/f423e051f343631f92cd1f261168c5215f6dacf6/cipd_manifest.versions
[modify] https://crrev.com/f423e051f343631f92cd1f261168c5215f6dacf6/cipd_manifest.txt

Give that a try? (in the latest depot_tools)
Status: Fixed (was: Available)
Just tried, it worked! Thank you for the quick fix!
Sorry for the breakage!
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed7a82d8b37fc44ff066bb8803a2c68a5048c0df

commit ed7a82d8b37fc44ff066bb8803a2c68a5048c0df
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Dec 13 22:35:51 2018

Roll src/third_party/depot_tools 7fa4fbc46829..f423e051f343 (2 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7fa4fbc46829..f423e051f343


git log 7fa4fbc46829..f423e051f343 --date=short --no-merges --format='%ad %ae %s'
2018-12-13 iannucci@chromium.org [led] Update led to latest version.
2018-12-13 sergiyb@chromium.org Add a feature to specify branches to be re-based


Created with:
  gclient setdep -r src/third_party/depot_tools@f423e051f343

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:914196 , chromium:914926 
TBR=agable@chromium.org

Change-Id: Icfb8fe0b34863b5961a26bee277c9f5c144fa420
Reviewed-on: https://chromium-review.googlesource.com/c/1376872
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616460}
[modify] https://crrev.com/ed7a82d8b37fc44ff066bb8803a2c68a5048c0df/DEPS

Sign in to add a comment