New issue
Advanced search Search tips

Issue 914924 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

[GCPW] Support update of password changes to sync with Google password.

Project Member Reported by tienmai@google.com, Dec 13

Issue description

When a user signs into their Windows machine using GCPW and their Windows password does not match their Google password, ask them to give their current Windows password so that it can be changed without losing any encrypted data. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e3e8860fdfe6c857adf8006879adedb4e673244

commit 8e3e8860fdfe6c857adf8006879adedb4e673244
Author: Tien Mai <tienmai@chromium.org>
Date: Thu Dec 13 19:55:16 2018

Add password change flow for when user changes their Gaia password.

The UI flow for GCPW is now as follows:
- "Reauth" is enabled for all gaia associated users
- After the user has signed in through gaia, if their gaia password does
not match their windows password, they will be asked to provide their
current windows password so that it can be changed to match the gaia
password.
- The same flow is applied to both logon types (reauth and add person)
- Removed a lot of code that is unnecssary for reauth calculation
- Refactored the flow of code so that WaitForLoginUI only returns the
authentication information gather through the GLS. This information
is passed onto OnUserAuthenticated to further process Windows specific
information used for logon.

Bug:  914924 

Change-Id: I8103bb62620df7322089db734c5e177f0b59dd71
Reviewed-on: https://chromium-review.googlesource.com/c/1363908
Commit-Queue: Tien Mai <tienmai@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616404}
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/DEPS
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/common/gcp_strings.cc
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/common/gcp_strings.h
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/BUILD.gn
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/gaia_credential.cc
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/gaia_credential.h
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/gaia_credential_base.cc
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/gaia_credential_base.h
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/gaia_credential_base_unittests.cc
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/gaia_credential_provider.cc
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/gaia_credential_provider.h
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/gaia_credential_provider_idl.templ
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/gaia_credential_provider_unittests.cc
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/gaia_credential_unittests.cc
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/gaia_resources.grd
[delete] https://crrev.com/f4de53a164a2cdaa596f56663b6702624f71cfed/chrome/credential_provider/gaiacp/gaia_resources_grd/IDS_ERROR_DIALOG_TITLE.png.sha1
[add] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/gaia_resources_grd/IDS_EXISTING_AUTH_FID_PROVIDER_LABEL.png.sha1
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/gaia_resources_grd/IDS_INVALID_PASSWORD.png.sha1
[add] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/gaia_resources_grd/IDS_PASSWORD_UPDATE_NEEDED.png.sha1
[delete] https://crrev.com/f4de53a164a2cdaa596f56663b6702624f71cfed/chrome/credential_provider/gaiacp/gaia_resources_grd/IDS_REAUTH_FID_DESCRIPTION.png.sha1
[delete] https://crrev.com/f4de53a164a2cdaa596f56663b6702624f71cfed/chrome/credential_provider/gaiacp/gaia_resources_grd/IDS_REAUTH_FID_PROVIDER_LABEL.png.sha1
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/os_user_manager.cc
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/os_user_manager.h
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/reauth_credential.cc
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/reauth_credential.h
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/reauth_credential_unittests.cc
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/reg_utils.cc
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/gaiacp/reg_utils.h
[delete] https://crrev.com/f4de53a164a2cdaa596f56663b6702624f71cfed/chrome/credential_provider/gaiacp/win_http_url_fetcher.cc
[delete] https://crrev.com/f4de53a164a2cdaa596f56663b6702624f71cfed/chrome/credential_provider/gaiacp/win_http_url_fetcher.h
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/test/BUILD.gn
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/test/com_fakes.cc
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/test/com_fakes.h
[add] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/test/fake_gls_run_helper.cc
[add] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/test/fake_gls_run_helper.h
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/test/gcp_fakes.cc
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/test/gcp_fakes.h
[add] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/chrome/credential_provider/test/test_credential.h
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x64/gaia_credential_provider.tlb
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x64/gaia_credential_provider_i.h
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x64/gaia_credential_provider_p.c
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x86/gaia_credential_provider.tlb
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x86/gaia_credential_provider_i.h
[modify] https://crrev.com/8e3e8860fdfe6c857adf8006879adedb4e673244/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x86/gaia_credential_provider_p.c

Status: Fixed (was: Started)

Sign in to add a comment