Presubmit script to check eventSender complains even if beginDragWithFiles is used |
||
Issue descriptionrepro: 1. try to upload a web_test that uses eventSender.beginDragWithFiles result: ** Presubmit Warnings ** eventSender is deprecated, please use chrome.gpuBenchmarking.pointerActionSequence instead (see https://crbug.com/711340 and http://goo.gl/BND75q). Files: third_party/blink/web_tests/fast/files/file-list-change-events.html:28 eventSender.mouseMoveTo(rect.left + rect.width / 2, rect.top + rect.height / 2); But reading http://goo.gl/BND75q shows "PointerActionSequence does not support Drag and Drop actions right now." (It also links to issue 722921 which seems incorrect?) It would be nice if the PRESUBMIT detected the use of beginDragWithFiles and did not issue a warning.
,
Jan 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/331073cea46abfd2c4a08a6a17f78c538c669d60 commit 331073cea46abfd2c4a08a6a17f78c538c669d60 Author: Lan Wei <lanwei@chromium.org> Date: Mon Jan 07 20:38:48 2019 Change presubmit function when using eventSender chrome.gpuBenchmarking.pointerActionSequence cannot simulate drag and drop actions now, so we still have to use eventSender, so in _CheckFilesUsingEventSender, when "eventSender.beginDragWithFiles" has been used in the test file, we will skip this file. Bug: 914894 Change-Id: I5b6be798950d13fd3fee105f6776b0e703e093f9 Reviewed-on: https://chromium-review.googlesource.com/c/1398065 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#620455} [modify] https://crrev.com/331073cea46abfd2c4a08a6a17f78c538c669d60/third_party/blink/web_tests/PRESUBMIT.py
,
Jan 7
,
Jan 8
Thanks for fixing! |
||
►
Sign in to add a comment |
||
Comment 1 by bokan@chromium.org
, Dec 20