New issue
Advanced search Search tips

Issue 914869 link

Starred by 1 user
Status: Fixed
Owner:
rohitrao@chromium.org
Closed: Dec 17
Cc:
ajuma@chromium.org
kkhorimoto@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

ios-chrome-unittest are broken

Project Member Reported by javierrobles@chromium.org, Dec 13 
Log:
[ RUN      ] FirstUserActionRecorderTest.OnUserAction_NewTask
[56540:8963:1213/090044.056342:78922770158691:FATAL:web_thread_impl.cc(372)] Check failed: globals.states[identifier_] == WebThreadState::UNINITIALIZED (3 vs. 0)
0   ios_chrome_unittests                0x0000000109eeb2b8 base::debug::StackTrace::StackTrace(unsigned long) + 72
1   ios_chrome_unittests                0x0000000109eeb2ed base::debug::StackTrace::StackTrace(unsigned long) + 29
2   ios_chrome_unittests                0x0000000109cbbd7a base::debug::StackTrace::StackTrace() + 26
3   ios_chrome_unittests                0x0000000109ce2dde logging::LogMessage::~LogMessage() + 142
4   ios_chrome_unittests                0x0000000109ce1d45 logging::LogMessage::~LogMessage() + 21
5   ios_chrome_unittests                0x0000000108656547 web::WebThreadImpl::Initialize() + 599
6   ios_chrome_unittests                0x0000000108656749 web::WebThreadImpl::WebThreadImpl(web::WebThread::ID, base::MessageLoop*) + 201
7   ios_chrome_unittests                0x0000000108f4af4d web::TestWebThreadImpl::TestWebThreadImpl(web::WebThread::ID, base::MessageLoop*) + 45

Failing run:
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/smoke/builds/27601/steps/ios_chrome_unittests%20%28iPad%20Air%20iOS%2012.1%29%20on%20Mac

Comment 1 by javierrobles@chromium.org, Dec 13

Owner: rohitrao@chromium.org
Offending CL was: https://chromium-review.googlesource.com/c/chromium/src/+/1340827

Reverted in: https://chromium-review.googlesource.com/c/chromium/src/+/1375890

Rohit. Can you take a look?

Comment 2 by rohitrao@google.com, Dec 13

Labels: -Pri-3 Pri-1
Status: Started (was: Untriaged)

Comment 3 by rohitrao@google.com, Dec 13 

Per gab's comment on the original CL:

File ios/web/test/test_web_thread_bundle.cc:
Patch Set #8, Line 58: WebThreadImpl::ResetGlobalsForTesting(WebThread::IO);

Ah, these should be in test_web_thread.cc rather than here (or tests that use TestWebThread directly instead of the bundle will be unhappy as per revert)


The trybots were green because these tests passed on retry.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e07395847275faf4e81181dce9e1474f5f85b4d1

commit e07395847275faf4e81181dce9e1474f5f85b4d1
Author: Rohit Rao <rohitrao@chromium.org>
Date: Fri Dec 14 17:28:31 2018

Reland "[ios] Store TaskRunners instead of threads in WebThreadImpl."

This is a reland of 3d3f6bf113b71a9d0d2a259152581a5d65f76a22

The call to ResetGlobalsForTesting() has been moved from
TestWebThreadBundle to TestWebThread, as some unittests instantiate
TestWebThreads directly.

Original change's description:
> [ios] Store TaskRunners instead of threads in WebThreadImpl.
>
> Track thread states explicitly instead of simply checking
> whether a TaskRunner pointer exists or not.
>
> BUG=826465
>
> Change-Id: Id0f84e7eedc6b9f6568aec629abbb86f46979efa
> Reviewed-on: https://chromium-review.googlesource.com/c/1340827
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Commit-Queue: Rohit Rao <rohitrao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#616319}

Bug: 826465, 914869 
Change-Id: I522b1bb46464a17ade84a20857ee7db2cb713a8d
Reviewed-on: https://chromium-review.googlesource.com/c/1377320
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616723}
[modify] https://crrev.com/e07395847275faf4e81181dce9e1474f5f85b4d1/ios/web/public/test/test_web_thread.h
[modify] https://crrev.com/e07395847275faf4e81181dce9e1474f5f85b4d1/ios/web/test/test_web_thread.cc
[modify] https://crrev.com/e07395847275faf4e81181dce9e1474f5f85b4d1/ios/web/web_thread_impl.cc
[modify] https://crrev.com/e07395847275faf4e81181dce9e1474f5f85b4d1/ios/web/web_thread_impl.h

Comment 5 by rohitrao@google.com, Dec 17

Status: Fixed (was: Started)
►

Sign in to add a comment