New issue
Advanced search Search tips

Issue 914822 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 885313



Sign in to add a comment

WebShareTarget: crash when specifying only URL (no text or title)

Project Member Reported by hartma...@chromium.org, Dec 13

Issue description

[original issue filed at https://github.com/WICG/web-share-target/issues/75]

WebAPK crashes when sharing by only specifying the URL in my manifest, like this:

"share_target": {
	...
	"params": {
		"url": "url"
	}
}


Quite possibly related to  issue 914821 .
 
Owner: pkotw...@chromium.org
Status: Assigned (was: Untriaged)
Labels: -M-72 M-73
Sorry, the bug is worse than what I stated.

WebAPKs will crash in two scenarios:
1) All share intents received by a WebAPK created with Web Manifest which specifies neither:
shareParamTitle nor shareParamText (Setting the params in the Web Manifest to empty counts as not specifying the parameter)
Specifying shareParamUrl will not stop the WebAPK from crashing

2) Share intents which do not provide any of the parameters specified by the share target
e.g. WebAPK installed for manifest
"share_target": {
	...
	"params": {
		"title": "title"
	}
}
Share intent does not provide Intent.EXTRA_TITLE (does not matter if intent provides Intent.EXTRA_TEXT)
https://chromium-review.googlesource.com/c/chromium/src/+/1285069 fixes the bug but is not being vended by the WebAPK server

If we plan on delaying increasing the WebAPK version that the server vends, we should modify the server to put in non-empty defaults for shareParamTitle and shareParamUrl.
This will cause WebAPKs to constantly request updates but this is ok if the server tells the WebAPK to relax updates and switch to requesting updates every month

Sign in to add a comment