Umbrella bug.
Moving to P2 to reflect that current milestone is for completing conversion of PO2TS/SigninManager.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97ad3187869d4025a7ea5f94f634f95cc58b98be commit 97ad3187869d4025a7ea5f94f634f95cc58b98be Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Dec 13 17:35:24 2018 Store account image in AccountInfo In order to simplify the API of Identity Service, store the account image into AccountInfo. The class gfx::Image is a smart refcounted wrapper around the image data so it is quite cheap to copy (though it is not thread-safe but the class enforece this via DCHECK so incorrect use will be caught by build with assertion checks enabled). Bug: 914783 Change-Id: I75798e5ff95b2f300467391a4b354ba7256f39d0 Reviewed-on: https://chromium-review.googlesource.com/c/1375729 Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#616354} [modify] https://crrev.com/97ad3187869d4025a7ea5f94f634f95cc58b98be/components/signin/core/browser/BUILD.gn [modify] https://crrev.com/97ad3187869d4025a7ea5f94f634f95cc58b98be/components/signin/core/browser/account_info.h [modify] https://crrev.com/97ad3187869d4025a7ea5f94f634f95cc58b98be/components/signin/core/browser/account_tracker_service.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16a5b10a46d264471b286c211b8a2660bdb9ebc4 commit 16a5b10a46d264471b286c211b8a2660bdb9ebc4 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Jan 08 10:37:25 2019 Remove AccountTrackerService private type AccountState As AccountInfo includes the account image, there is no need for the helper type AccountState (that stored the AccountInfo and its image). This is a followup to https://crrev.com/c/1375729. Bug: 914783 Change-Id: I2eea2142b1ed7d3fb9986a7acee6d329fc447713 Reviewed-on: https://chromium-review.googlesource.com/c/1375931 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#620670} [modify] https://crrev.com/16a5b10a46d264471b286c211b8a2660bdb9ebc4/components/signin/core/browser/account_fetcher_service.cc [modify] https://crrev.com/16a5b10a46d264471b286c211b8a2660bdb9ebc4/components/signin/core/browser/account_tracker_service.cc [modify] https://crrev.com/16a5b10a46d264471b286c211b8a2660bdb9ebc4/components/signin/core/browser/account_tracker_service.h [modify] https://crrev.com/16a5b10a46d264471b286c211b8a2660bdb9ebc4/components/signin/core/browser/fake_account_fetcher_service.cc [modify] https://crrev.com/16a5b10a46d264471b286c211b8a2660bdb9ebc4/services/identity/public/cpp/identity_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfb41cfbc1a49990cdb64d2407c0fd107ac9a276 commit cfb41cfbc1a49990cdb64d2407c0fd107ac9a276 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Jan 11 10:23:03 2019 Remove AccountTrackerService::Observer::OnAccountImageUpdated All observers of that method were UI components that refreshed themselves when notified. Since they then fetch the data from the AccountTrackerService, and does the same refresh when the account is updated, it is simpler to just use OnAccountUpdated for both events. Bug: 914783 Change-Id: I4d085baceb72373eda1c11e169d04ce55a2ac8e2 Reviewed-on: https://chromium-review.googlesource.com/c/1402568 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Thomas Tangl <tangltom@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#621962} [modify] https://crrev.com/cfb41cfbc1a49990cdb64d2407c0fd107ac9a276/chrome/browser/ui/views/profiles/avatar_toolbar_button.cc [modify] https://crrev.com/cfb41cfbc1a49990cdb64d2407c0fd107ac9a276/chrome/browser/ui/views/profiles/avatar_toolbar_button.h [modify] https://crrev.com/cfb41cfbc1a49990cdb64d2407c0fd107ac9a276/chrome/browser/ui/webui/settings/chromeos/account_manager_handler.cc [modify] https://crrev.com/cfb41cfbc1a49990cdb64d2407c0fd107ac9a276/chrome/browser/ui/webui/settings/chromeos/account_manager_handler.h [modify] https://crrev.com/cfb41cfbc1a49990cdb64d2407c0fd107ac9a276/chrome/browser/ui/webui/settings/people_handler.cc [modify] https://crrev.com/cfb41cfbc1a49990cdb64d2407c0fd107ac9a276/chrome/browser/ui/webui/settings/people_handler.h [modify] https://crrev.com/cfb41cfbc1a49990cdb64d2407c0fd107ac9a276/components/signin/core/browser/account_tracker_service.cc [modify] https://crrev.com/cfb41cfbc1a49990cdb64d2407c0fd107ac9a276/components/signin/core/browser/account_tracker_service.h [modify] https://crrev.com/cfb41cfbc1a49990cdb64d2407c0fd107ac9a276/components/signin/core/browser/account_tracker_service_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e3c634b7774c99cd6d4375e096a6dfe57a68af5 commit 3e3c634b7774c99cd6d4375e096a6dfe57a68af5 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Jan 14 17:39:29 2019 Remove unnecessary AccountTrackerService::GetAccountImage As the AccountInfo already stores the account image, remove the now unnecessary GetAccountImage and convert client code to get the image from AccountInfo's account_image field. Remove now unnecessary array of image from DiceAccountsMenu. Bug: 914783 Change-Id: I690d7f5f9be2c9d143ecfabf1355070329139122 Reviewed-on: https://chromium-review.googlesource.com/c/1402759 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Thomas Tangl <tangltom@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#622499} [modify] https://crrev.com/3e3c634b7774c99cd6d4375e096a6dfe57a68af5/chrome/browser/ui/views/profiles/avatar_toolbar_button.cc [modify] https://crrev.com/3e3c634b7774c99cd6d4375e096a6dfe57a68af5/chrome/browser/ui/views/profiles/dice_accounts_menu.cc [modify] https://crrev.com/3e3c634b7774c99cd6d4375e096a6dfe57a68af5/chrome/browser/ui/views/profiles/dice_accounts_menu.h [modify] https://crrev.com/3e3c634b7774c99cd6d4375e096a6dfe57a68af5/chrome/browser/ui/views/profiles/profile_chooser_view.cc [modify] https://crrev.com/3e3c634b7774c99cd6d4375e096a6dfe57a68af5/chrome/browser/ui/views/sync/dice_bubble_sync_promo_view.cc [modify] https://crrev.com/3e3c634b7774c99cd6d4375e096a6dfe57a68af5/chrome/browser/ui/views/sync/dice_bubble_sync_promo_view.h [modify] https://crrev.com/3e3c634b7774c99cd6d4375e096a6dfe57a68af5/chrome/browser/ui/webui/settings/chromeos/account_manager_handler.cc [modify] https://crrev.com/3e3c634b7774c99cd6d4375e096a6dfe57a68af5/chrome/browser/ui/webui/settings/people_handler.cc [modify] https://crrev.com/3e3c634b7774c99cd6d4375e096a6dfe57a68af5/chrome/browser/ui/webui/settings/people_handler.h [modify] https://crrev.com/3e3c634b7774c99cd6d4375e096a6dfe57a68af5/chrome/browser/ui/webui/settings/people_handler_unittest.cc [modify] https://crrev.com/3e3c634b7774c99cd6d4375e096a6dfe57a68af5/components/signin/core/browser/account_tracker_service.cc [modify] https://crrev.com/3e3c634b7774c99cd6d4375e096a6dfe57a68af5/components/signin/core/browser/account_tracker_service.h [modify] https://crrev.com/3e3c634b7774c99cd6d4375e096a6dfe57a68af5/components/signin/core/browser/account_tracker_service_unittest.cc
Comment 1 by blundell@chromium.org
, Dec 13