New issue
Advanced search Search tips

Issue 914765 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

[Tracking] Experiment with fill-on-account-select for password forms served over HTTP

Project Member Reported by jdoerrie@chromium.org, Dec 13

Issue description

This issue tracks development regarding experiments for fill-on-account-select for password forms served over HTTP.

Design Doc: go/http-foas-design-doc
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d54f4e310db569b4293a23877bf34036deaddb7

commit 9d54f4e310db569b4293a23877bf34036deaddb7
Author: jdoerrie <jdoerrie@chromium.org>
Date: Thu Dec 13 14:55:39 2018

[Passwords] Add Fill on Account Select on HTTP Feature Flag

This change adds a feature flag for the Fill on Account Select on HTTP
experiment.

Bug: 914765
Change-Id: I23f7a5c96b5a81c1962b9f327913ac3a6061d697
Reviewed-on: https://chromium-review.googlesource.com/c/1375721
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616316}
[modify] https://crrev.com/9d54f4e310db569b4293a23877bf34036deaddb7/components/password_manager/core/common/password_manager_features.cc
[modify] https://crrev.com/9d54f4e310db569b4293a23877bf34036deaddb7/components/password_manager/core/common/password_manager_features.h

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27ef0bdb5b7ce2f25899c906926b2f050a6479f5

commit 27ef0bdb5b7ce2f25899c906926b2f050a6479f5
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Thu Dec 20 12:26:05 2018

[Passwords] Enable Fill-On-Account-Select for HTTP with Flag

This change enables fill-on-account-select for insecure origins if the
corresponding flag is active. Furthermore, this change introduces a
LikelyFormFilling enum, informing the PasswordFormManager about the kind
of filling that is likely performed in the renderer for the corresponding
form.

Bug: 914765
Change-Id: I5f71df3c9a544f0c855ccd93b8338f669678aa24
Reviewed-on: https://chromium-review.googlesource.com/c/1379958
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618183}
[modify] https://crrev.com/27ef0bdb5b7ce2f25899c906926b2f050a6479f5/components/password_manager/core/browser/new_password_form_manager.cc
[modify] https://crrev.com/27ef0bdb5b7ce2f25899c906926b2f050a6479f5/components/password_manager/core/browser/new_password_form_manager.h
[modify] https://crrev.com/27ef0bdb5b7ce2f25899c906926b2f050a6479f5/components/password_manager/core/browser/new_password_form_manager_unittest.cc
[modify] https://crrev.com/27ef0bdb5b7ce2f25899c906926b2f050a6479f5/components/password_manager/core/browser/password_form_filling.cc
[modify] https://crrev.com/27ef0bdb5b7ce2f25899c906926b2f050a6479f5/components/password_manager/core/browser/password_form_filling.h
[modify] https://crrev.com/27ef0bdb5b7ce2f25899c906926b2f050a6479f5/components/password_manager/core/browser/password_form_filling_unittest.cc
[modify] https://crrev.com/27ef0bdb5b7ce2f25899c906926b2f050a6479f5/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/27ef0bdb5b7ce2f25899c906926b2f050a6479f5/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/27ef0bdb5b7ce2f25899c906926b2f050a6479f5/components/password_manager/core/browser/password_form_manager_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 9

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b38c9521804a3c514cc40ced6eabbbba7421d87

commit 6b38c9521804a3c514cc40ced6eabbbba7421d87
Author: jdoerrie <jdoerrie@chromium.org>
Date: Thu Jan 10 10:33:56 2019

[Passwords] Use PascalCase for HTTP FOAS Flag

This change renames the HTTP FOAS flag from fill-on-account-select-http
to FillOnAccountSelectHttp. Using PascalCase is strongly preferred for
new feature names.

Bug: 914765
Change-Id: Iff8276286091661ac83009342b3e5b16a8c02eeb
Reviewed-on: https://chromium-review.googlesource.com/c/1404080
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621533}
[modify] https://crrev.com/6b38c9521804a3c514cc40ced6eabbbba7421d87/components/password_manager/core/browser/password_form_filling.cc
[modify] https://crrev.com/6b38c9521804a3c514cc40ced6eabbbba7421d87/components/password_manager/core/common/password_manager_features.cc

Sign in to add a comment