New issue
Advanced search Search tips

Issue 914763 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: ----



Sign in to add a comment

Search Accelerator menu should distinguish between copied link and text

Project Member Reported by rkgibson@google.com, Dec 13

Issue description

Search accelerator menu says "Paste and Go" regardless of clipboard content.

Switch it to "Visit Copied Link" or "Search Copied Text" depending on whether it contains a url or not.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/640d842b5c14323ad5919133b12f4714c98eb468

commit 640d842b5c14323ad5919133b12f4714c98eb468
Author: Robbie Gibson <rkgibson@google.com>
Date: Tue Dec 18 11:55:13 2018

[iOS] Handle copied urls vs text in search menu

This CL adds differentiation between a copied url and copied text for the
menu that appears after long-pressing the search accelerator button.

Bug:  914763 
Change-Id: Ib03656341a5ab635be43f69c2ccdf96450b9a6f4
Reviewed-on: https://chromium-review.googlesource.com/c/1375735
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617449}
[modify] https://crrev.com/640d842b5c14323ad5919133b12f4714c98eb468/ios/chrome/app/strings/ios_strings.grd
[add] https://crrev.com/640d842b5c14323ad5919133b12f4714c98eb468/ios/chrome/app/strings/ios_strings_grd/IDS_IOS_TOOLS_MENU_SEARCH_COPIED_TEXT.png.sha1
[add] https://crrev.com/640d842b5c14323ad5919133b12f4714c98eb468/ios/chrome/app/strings/ios_strings_grd/IDS_IOS_TOOLS_MENU_VISIT_COPIED_LINK.png.sha1
[modify] https://crrev.com/640d842b5c14323ad5919133b12f4714c98eb468/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/640d842b5c14323ad5919133b12f4714c98eb468/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/640d842b5c14323ad5919133b12f4714c98eb468/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/640d842b5c14323ad5919133b12f4714c98eb468/ios/chrome/browser/ui/popup_menu/BUILD.gn
[modify] https://crrev.com/640d842b5c14323ad5919133b12f4714c98eb468/ios/chrome/browser/ui/popup_menu/popup_menu_action_handler.mm
[modify] https://crrev.com/640d842b5c14323ad5919133b12f4714c98eb468/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm
[modify] https://crrev.com/640d842b5c14323ad5919133b12f4714c98eb468/ios/chrome/browser/ui/ui_feature_flags.cc
[modify] https://crrev.com/640d842b5c14323ad5919133b12f4714c98eb468/ios/chrome/browser/ui/ui_feature_flags.h

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
This issue has been verified and found fixed in latest M73 canary.
Build Version: 73.0.3665.0 canary
Device: iPhoneX(12.0.1)

Sign in to add a comment