Regression: Blue focus ring is lost from 'Pause'/'Resume' button after pressing 'Enter' key on it on chrome://downloads/ page |
|||
Issue descriptionChrome version: 72.0.3626.17 (Official Build) Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315} (32/64 bit) OS: Windows (7, 8, 8.1, 10), Mac (10.13.1, 10.13.6, 10.14.2) and Linux (14.04 LTS) Test URL : https://speed.hetzner.de/ What steps will reproduce the problem? 1. Launch chrome, navigate to above test URL and download "100MB.bin" file. 2. Click on 'Show All' button (chrome://downloads page will appear). 3. Now traverse the focus to 'Pause' button using 'Tab' key and press 'Enter'. 4. Observe. Actual Result: Blue focus ring is lost from 'Pause'/'Resume' button after pressing 'Enter' key on it. Expected Result: Blue focus ring should always be seen on 'Pause'/'Resume' button after pressing 'Enter' key on it. This is a regression issue broken in ‘M-69’, below is the Manual Regression range: Good build: 69.0.3464.0 (Revision: 567919) Bad build: 69.0.3465.0 (Revision: 568285) Using per-revision script, below is the bisect info: You are probably looking for a change made after 568100 (known good), but no later than 568101 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/b8f7147a8446881dc80c9570183cd4d935e5e63e..4308ace4619507a2502f713746a699636885876f Suspect: https://chromium.googlesource.com/chromium/src/+/4308ace4619507a2502f713746a699636885876f @rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: Issue is also seen on M-71 Stable (build #71.0.3578.98), M-72 Dev (build #72.0.3626.14) and M-73 Canary (build #73.0.3639.0). Kindly refer the attached screen-cast. Thank You..!!
,
Jan 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba6a36099a3a1f795b754f486d64640e1ec62328 commit ba6a36099a3a1f795b754f486d64640e1ec62328 Author: rbpotter <rbpotter@chromium.org> Date: Tue Jan 08 00:17:36 2019 Downloads WebUI: Fix button keyboard focus highlight To leverage styling for action-button for the "Resume" state but not "Pause" state, https://crrev.com/c/1101923 set the class of the button using a data binding. However, this also had the side effect of removing the keyboard-focus class that shows the focus highlight whenever the state of the button changed. Instead, observe the button text and add or remove 'action-button' without modifying the entire classList. Bug: 914761 Change-Id: Ifd0e5c4175ed8497d2cc5c8c9536d5cc687b74ed Reviewed-on: https://chromium-review.googlesource.com/c/1396853 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#620546} [modify] https://crrev.com/ba6a36099a3a1f795b754f486d64640e1ec62328/chrome/browser/resources/md_downloads/item.html [modify] https://crrev.com/ba6a36099a3a1f795b754f486d64640e1ec62328/chrome/browser/resources/md_downloads/item.js
,
Jan 8
Update: Rechecked the above issue on Windows (7, 8, 8.1, 10), Mac (10.13.1, 10.13.6, 10.14.3) and Linux (14.04 LTS) OS using latest Canary version #73.0.3665.0 and the issue is found FIXED. Hence, adding TE-Verified labels. Please refer the attached screen-cast. Thank You..!!
,
Jan 8
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rbpotter@chromium.org
, Jan 5