New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 914747 link

Starred by 1 user
Status: Assigned
Owner:
mastiz@chromium.org
Cc:
sabineb@chromium.org
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 919943



Sign in to add a comment

Sessions should stop syncing in Dice paused

Project Member Reported by mastiz@chromium.org, Dec 13 
What steps will reproduce the problem?
(1) Enable sync.
(2) Use chrome://history to verify there are "tabs from other devices".
(3) Sign out of content area (sync will pause).
(4) Open chrome://history "tabs from other devices". 

What is the expected result?
The UI shouldn't display tabs from other device.

What happens instead?
Tabs from other devices are visible.

Comment 1 by tschumann@google.com, Dec 13 

Hmmm... the current behavior seems in line with the current sync model to me -- i.e., sync is not removing local data when in Pause state. 

Do I understand the expected behavior correctly, that we either should remove remote sessions from the sync storage or at least hide them?
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4c2e22c5e0ba8ef72a059d2f43cfe3a76b1f1a0

commit b4c2e22c5e0ba8ef72a059d2f43cfe3a76b1f1a0
Author: Mikel Astiz <mastiz@chromium.org>
Date: Thu Dec 13 13:01:18 2018

Move ProxyDataTypeController to sync_sessions

Mechanical change without behavioral differences.

We have exactly one proxy datatype and it's about tabs from other
devices (PROXY_TABS). Let's avoid abstraction and move the controller
closer to the feature, under sync_sessions.

Follow-up patches may introduce additional custom logic that is
specific to tab sync.

Bug: 914747
Change-Id: I5afedff030bd455232836f0eb1fbcce6fcfa012b
Reviewed-on: https://chromium-review.googlesource.com/c/1374987
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616283}
[modify] https://crrev.com/b4c2e22c5e0ba8ef72a059d2f43cfe3a76b1f1a0/components/browser_sync/profile_sync_components_factory_impl.cc
[modify] https://crrev.com/b4c2e22c5e0ba8ef72a059d2f43cfe3a76b1f1a0/components/sync/BUILD.gn
[delete] https://crrev.com/f1cd99ffe67f4d5baa29138671853ab2c4baad29/components/sync/driver/proxy_data_type_controller.cc
[delete] https://crrev.com/f1cd99ffe67f4d5baa29138671853ab2c4baad29/components/sync/driver/proxy_data_type_controller.h
[modify] https://crrev.com/b4c2e22c5e0ba8ef72a059d2f43cfe3a76b1f1a0/components/sync_sessions/BUILD.gn
[add] https://crrev.com/b4c2e22c5e0ba8ef72a059d2f43cfe3a76b1f1a0/components/sync_sessions/proxy_tabs_data_type_controller.cc
[add] https://crrev.com/b4c2e22c5e0ba8ef72a059d2f43cfe3a76b1f1a0/components/sync_sessions/proxy_tabs_data_type_controller.h

Comment 3 by mastiz@chromium.org, Dec 13 

tschumann@: my immediate proposal is to hide the data from the UI.

In addition, stopping session sync altogether is safer to prevent history from accidentally syncing.

Comment 4 by mastiz@chromium.org, Jan 8

Blocking: 919943
►

Sign in to add a comment