BookmarkModelTypeProcessor::EstimateMemoryUsage() should check for null bookmark_tracker_ |
|||||||
Issue descriptionBookmarkModelTypeProcessor::EstimateMemoryUsage() doesn't check if bookmark_tracker_ has been created or not yet. If the method is called while the bookmark model is being loaded, it would cause a crash.
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4a35c5f53778450f68bb79cf7bbe03e2107d0da commit b4a35c5f53778450f68bb79cf7bbe03e2107d0da Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Thu Dec 13 14:42:48 2018 [Sync::USS] Fix crash when EstimateMemoryUsage in Bookmarks processor BookmarkModelTypeProcessor::EstimateMemoryUsage() should check bookmark_tracker_ for nullness before estimating the memory usage. The reason is if EstimateMemoryUsage() is called while the model is being loaded, the bookmark_tracker_ wouldn't have been initialized yet. Bug: 914745 Change-Id: I93f6ee0972022d4f72dcfdee5261f5efe51c5239 Reviewed-on: https://chromium-review.googlesource.com/c/1375124 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#616307} [modify] https://crrev.com/b4a35c5f53778450f68bb79cf7bbe03e2107d0da/components/sync_bookmarks/bookmark_model_type_processor.cc
,
Dec 13
,
Dec 13
,
Dec 14
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03b26c2b3af57427e748bc022a272b135507cd01 commit 03b26c2b3af57427e748bc022a272b135507cd01 Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Fri Dec 14 16:41:03 2018 [Sync::USS] Fix crash when EstimateMemoryUsage in Bookmarks processor BookmarkModelTypeProcessor::EstimateMemoryUsage() should check bookmark_tracker_ for nullness before estimating the memory usage. The reason is if EstimateMemoryUsage() is called while the model is being loaded, the bookmark_tracker_ wouldn't have been initialized yet. Bug: 914745 ,914780 Change-Id: I93f6ee0972022d4f72dcfdee5261f5efe51c5239 Reviewed-on: https://chromium-review.googlesource.com/c/1375124 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#616307}(cherry picked from commit b4a35c5f53778450f68bb79cf7bbe03e2107d0da) Reviewed-on: https://chromium-review.googlesource.com/c/1378142 Cr-Commit-Position: refs/branch-heads/3626@{#359} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/03b26c2b3af57427e748bc022a272b135507cd01/components/sync_bookmarks/bookmark_model_type_processor.cc
,
Dec 14
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03b26c2b3af57427e748bc022a272b135507cd01 Commit: 03b26c2b3af57427e748bc022a272b135507cd01 Author: mamir@chromium.org Commiter: mastiz@chromium.org Date: 2018-12-14 16:41:03 +0000 UTC [Sync::USS] Fix crash when EstimateMemoryUsage in Bookmarks processor BookmarkModelTypeProcessor::EstimateMemoryUsage() should check bookmark_tracker_ for nullness before estimating the memory usage. The reason is if EstimateMemoryUsage() is called while the model is being loaded, the bookmark_tracker_ wouldn't have been initialized yet. Bug: 914745 ,914780 Change-Id: I93f6ee0972022d4f72dcfdee5261f5efe51c5239 Reviewed-on: https://chromium-review.googlesource.com/c/1375124 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#616307}(cherry picked from commit b4a35c5f53778450f68bb79cf7bbe03e2107d0da) Reviewed-on: https://chromium-review.googlesource.com/c/1378142 Cr-Commit-Position: refs/branch-heads/3626@{#359} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mamir@chromium.org
, Dec 13