New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocked on:
issue 924024

Blocking:
issue 921130



Sign in to add a comment
link

Issue 914739: Split FetchContext into multiple well-organized classes

Reported by yhirano@chromium.org, Dec 13 Project Member

Issue description

To reduce the number of functions attached to the interface.
 

Comment 1 by yhirano@chromium.org, Dec 19

Components: Blink>Loader

Comment 2 by yhirano@chromium.org, Dec 19

Labels: -Type-Bug Type-Task

Comment 5 by bugdroid1@chromium.org, Dec 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51cfffb11897944fe1da6e6d504b99955be27d96

commit 51cfffb11897944fe1da6e6d504b99955be27d96
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Dec 21 12:21:39 2018

Remove FetchContext::ApplicationCacheHostId

Bug: 914739
Change-Id: I8575979a29159821e187ebf3476e181fc5e1197b
Reviewed-on: https://chromium-review.googlesource.com/c/1388353
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618506}
[modify] https://crrev.com/51cfffb11897944fe1da6e6d504b99955be27d96/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc
[modify] https://crrev.com/51cfffb11897944fe1da6e6d504b99955be27d96/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/51cfffb11897944fe1da6e6d504b99955be27d96/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/51cfffb11897944fe1da6e6d504b99955be27d96/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/51cfffb11897944fe1da6e6d504b99955be27d96/third_party/blink/renderer/core/loader/worker_fetch_context.h
[modify] https://crrev.com/51cfffb11897944fe1da6e6d504b99955be27d96/third_party/blink/renderer/core/workers/dedicated_worker.cc
[modify] https://crrev.com/51cfffb11897944fe1da6e6d504b99955be27d96/third_party/blink/renderer/platform/loader/fetch/fetch_context.h

Comment 6 by bugdroid1@chromium.org, Dec 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/373675a360a060361fc286aa12c8a1cf1f8b232e

commit 373675a360a060361fc286aa12c8a1cf1f8b232e
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Dec 26 07:11:20 2018

Remove FetchContext::DispatchDidLoadResourceFromMemoryCache

Move the logic to DispatchDidReceiveResponse.

Bug: 914739
Change-Id: I0f45c9b814527ab4d1c903ad1332b5341b9cc853
Reviewed-on: https://chromium-review.googlesource.com/c/1388352
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618910}
[modify] https://crrev.com/373675a360a060361fc286aa12c8a1cf1f8b232e/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/373675a360a060361fc286aa12c8a1cf1f8b232e/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/373675a360a060361fc286aa12c8a1cf1f8b232e/third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
[modify] https://crrev.com/373675a360a060361fc286aa12c8a1cf1f8b232e/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/373675a360a060361fc286aa12c8a1cf1f8b232e/third_party/blink/renderer/core/loader/worker_fetch_context.h
[modify] https://crrev.com/373675a360a060361fc286aa12c8a1cf1f8b232e/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/373675a360a060361fc286aa12c8a1cf1f8b232e/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/373675a360a060361fc286aa12c8a1cf1f8b232e/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/373675a360a060361fc286aa12c8a1cf1f8b232e/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc

Comment 7 by bugdroid1@chromium.org, Dec 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d0a752703b8c49110b747cf733e0c6e42ec719d

commit 8d0a752703b8c49110b747cf733e0c6e42ec719d
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Dec 27 03:52:31 2018

Introduce ConsoleLogger

Create a dedicated interface for Add(Info|Warning|Error)ConsoleMessage
functions in FetchContext. Now ResourceFetcher has a getter for the
interface, not FetchContext.

Bug: 914739
Change-Id: I56dc9b7ce2aa0c1fe78633f04d39c9fc84a16748
Reviewed-on: https://chromium-review.googlesource.com/c/1375186
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618999}
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/core/execution_context/execution_context.cc
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/core/execution_context/execution_context.h
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/core/frame/frame_console.cc
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/core/frame/frame_console.h
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/core/loader/BUILD.gn
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/core/loader/base_fetch_context.cc
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/core/loader/base_fetch_context.h
[add] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/core/loader/console_logger_impl_base.cc
[add] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/core/loader/console_logger_impl_base.h
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/core/workers/worker_classic_script_loader.cc
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/platform/loader/BUILD.gn
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/platform/loader/allowed_by_nosniff.cc
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/platform/loader/allowed_by_nosniff.h
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/platform/loader/allowed_by_nosniff_test.cc
[add] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/platform/loader/fetch/console_logger.h
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.h
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler_test.cc
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[modify] https://crrev.com/8d0a752703b8c49110b747cf733e0c6e42ec719d/third_party/blink/renderer/platform/loader/fetch/resource_loader.h

Comment 8 by bugdroid1@chromium.org, Dec 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6007e062656231be2fd934d19777c7082604b939

commit 6007e062656231be2fd934d19777c7082604b939
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Dec 27 04:04:21 2018

Refactor ResourceFetcher factory functions in FrameFetchContext

 - FrameFetchContext::CreateFetcherFromDocument sounds too generic. It's
   for HTML imports, so rename it to
   FrameFetchContext::CreateFetcherForImportedDocument.
 - Rename FrameFetchContext::CreateFetcherFromDocumentLoader to
   FrameFetchContext::CreateFetcher because it is the default path.
 - FrameFetchContext::FrameFetchContext(DocumentLoader*, Document*)
   expects exactly one of its two arguments is non-null. Split it to
   two for readability.

Bug: 914739
Change-Id: I50343f067d1b7687849ea348fadcd365567fcd6a
Reviewed-on: https://chromium-review.googlesource.com/c/1388354
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619000}
[modify] https://crrev.com/6007e062656231be2fd934d19777c7082604b939/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/6007e062656231be2fd934d19777c7082604b939/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/6007e062656231be2fd934d19777c7082604b939/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/6007e062656231be2fd934d19777c7082604b939/third_party/blink/renderer/core/loader/frame_fetch_context.h

Comment 9 by bugdroid1@chromium.org, Jan 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87789eb9d43b8038c7b0ba0a59a7df66c642c042

commit 87789eb9d43b8038c7b0ba0a59a7df66c642c042
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Jan 08 04:57:36 2019

Remove FrameFetchContext::GetLoadingTaskRunner

FrameFetchContext::GetLoadingTaskRunner has overwritten
FetchContext::GetLoadingTaskRunner because when it was introduced a
frame-bound task runner stopped working after it is detached while we
wanted to post some tasks even after the frame is detached.

According to [1] the situation has changed and now it's safe to assume
that we can post a task after the frame is detached.

1: https://crrev.com/c7d8259df9b28da303535314e5094963c7a59e5a

Change-Id: I4a09a44242378795aa7e74ee72459d2a18689c3a
Bugs: 914739
Reviewed-on: https://chromium-review.googlesource.com/c/1391648
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620627}
[modify] https://crrev.com/87789eb9d43b8038c7b0ba0a59a7df66c642c042/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/87789eb9d43b8038c7b0ba0a59a7df66c642c042/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/87789eb9d43b8038c7b0ba0a59a7df66c642c042/third_party/blink/renderer/platform/loader/fetch/fetch_context.h

Comment 10 by bugdroid1@chromium.org, Jan 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84357c739d0fbbd2a6bb8cf04d6dcba613345941

commit 84357c739d0fbbd2a6bb8cf04d6dcba613345941
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Jan 08 23:55:05 2019

Remove FetchContext::CreateResourceLoadingTaskRunner

It's used only used in (Frame|Worker)FetchContext::CreateURLLoader, so
move the function to each implementation.

Bug: 914739
Change-Id: If275b26c91e7e6cd911afe429ea7da27460eeeab
Reviewed-on: https://chromium-review.googlesource.com/c/1399687
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620944}
[modify] https://crrev.com/84357c739d0fbbd2a6bb8cf04d6dcba613345941/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/84357c739d0fbbd2a6bb8cf04d6dcba613345941/third_party/blink/renderer/core/loader/worker_fetch_context.h
[modify] https://crrev.com/84357c739d0fbbd2a6bb8cf04d6dcba613345941/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/84357c739d0fbbd2a6bb8cf04d6dcba613345941/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h

Comment 12 by bugdroid1@chromium.org, Jan 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5b2aa63543ff98b926378a7a2c7fefac046cab5

commit e5b2aa63543ff98b926378a7a2c7fefac046cab5
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Jan 11 01:48:53 2019

Introduce ResourceFetcherProperties

This is a first step to cleanup FetchContext. This CL introduces
ResourceFetcherProperties for "global properties" mentioned in the
design doc[1] and move one property, IsMainFrame, to the interface.

1: https://docs.google.com/document/u/1/d/1nXH2uEZLp3UEcMFNKBMlNUcJmssrPhPWtM1d86j_HCM

Bug: 914739
Change-Id: I9829265b6a4bd41ff6b79db622c29bb4f21175de
Reviewed-on: https://chromium-review.googlesource.com/c/1388056
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621859}
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/core/loader/BUILD.gn
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/core/loader/frame_fetch_context.h
[add] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/core/loader/frame_resource_fetcher_properties.cc
[add] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/core/loader/frame_resource_fetcher_properties.h
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/core/loader/resource/font_resource_test.cc
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/core/loader/resource/image_resource_test.cc
[add] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/core/loader/worker_resource_fetcher_properties.h
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/core/workers/worklet_module_responses_map_test.cc
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/platform/loader/BUILD.gn
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/platform/loader/fetch/memory_cache_correctness_test.cc
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/platform/loader/fetch/memory_cache_test.cc
[add] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/platform/loader/fetch/null_resource_fetcher_properties.h
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h
[add] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_properties.h
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.h
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler_test.cc
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/platform/loader/fetch/resource_loader_defer_loading_test.cc
[modify] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/platform/loader/fetch/resource_loader_test.cc
[add] https://crrev.com/e5b2aa63543ff98b926378a7a2c7fefac046cab5/third_party/blink/renderer/platform/loader/testing/test_resource_fetcher_properties.h

Comment 13 by bugdroid1@chromium.org, Jan 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec997a35cf9aae0a66fc95f58c8b3a13d791a5ca

commit ec997a35cf9aae0a66fc95f58c8b3a13d791a5ca
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Jan 11 02:51:13 2019

Introduce ResourceFetcherInit

... to get more flexibility on ResourceFetcher construction. Also remove
Archive() and InitialThrottlingPolicy() from FetchContext because they
are used only in ResourceFetcher construction.

Bug: 914739
Change-Id: I14e822632c0ceab32c6e0c161f63f32a44e9d517
Reviewed-on: https://chromium-review.googlesource.com/c/1391036
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621880}
[modify] https://crrev.com/ec997a35cf9aae0a66fc95f58c8b3a13d791a5ca/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/ec997a35cf9aae0a66fc95f58c8b3a13d791a5ca/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/ec997a35cf9aae0a66fc95f58c8b3a13d791a5ca/third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
[modify] https://crrev.com/ec997a35cf9aae0a66fc95f58c8b3a13d791a5ca/third_party/blink/renderer/core/loader/resource/image_resource_test.cc
[modify] https://crrev.com/ec997a35cf9aae0a66fc95f58c8b3a13d791a5ca/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/ec997a35cf9aae0a66fc95f58c8b3a13d791a5ca/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/ec997a35cf9aae0a66fc95f58c8b3a13d791a5ca/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/ec997a35cf9aae0a66fc95f58c8b3a13d791a5ca/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h
[modify] https://crrev.com/ec997a35cf9aae0a66fc95f58c8b3a13d791a5ca/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc
[modify] https://crrev.com/ec997a35cf9aae0a66fc95f58c8b3a13d791a5ca/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.h
[modify] https://crrev.com/ec997a35cf9aae0a66fc95f58c8b3a13d791a5ca/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler_test.cc
[modify] https://crrev.com/ec997a35cf9aae0a66fc95f58c8b3a13d791a5ca/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h

Comment 14 by bugdroid1@chromium.org, Jan 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89b2665274dd45001ebbbdc5bb63e109e6cf8b3e

commit 89b2665274dd45001ebbbdc5bb63e109e6cf8b3e
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Jan 11 09:49:41 2019

Introduce FrameOrImportedDocument

FrameFetchContext works for a frame and an imported document.
I'm planning to split more classes from FrameFetchContext
which will need the same logic.

This CL introduces FrameOrImportedDocument for the shared logic to avoid
future code duplication.

Bug: 914739
Change-Id: I75d59e5e53ae99cd945ed5e160142681d7f5f5c0
Reviewed-on: https://chromium-review.googlesource.com/c/1404902
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621956}
[modify] https://crrev.com/89b2665274dd45001ebbbdc5bb63e109e6cf8b3e/third_party/blink/renderer/core/loader/BUILD.gn
[modify] https://crrev.com/89b2665274dd45001ebbbdc5bb63e109e6cf8b3e/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/89b2665274dd45001ebbbdc5bb63e109e6cf8b3e/third_party/blink/renderer/core/loader/frame_fetch_context.h
[add] https://crrev.com/89b2665274dd45001ebbbdc5bb63e109e6cf8b3e/third_party/blink/renderer/core/loader/frame_or_imported_document.cc
[add] https://crrev.com/89b2665274dd45001ebbbdc5bb63e109e6cf8b3e/third_party/blink/renderer/core/loader/frame_or_imported_document.h

Comment 15 by bugdroid1@chromium.org, Jan 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5482b1af097242d0b7c66360c00bd22979d91ff4

commit 5482b1af097242d0b7c66360c00bd22979d91ff4
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Jan 11 10:57:23 2019

Provide FrameOrImportedDocument to FrameResourceFetcherProperties

As a preparation to move more properties to
FrameResourceFetcherProperties, this CL passes FrameOrImportedDocument,
not LocalFrame, to FrameResourceFetcherProperties.

Bug: 914739
Change-Id: Ib56c7013eeb2c7cb66d5d6651e832f7d475bd58c
Reviewed-on: https://chromium-review.googlesource.com/c/1405161
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621967}
[modify] https://crrev.com/5482b1af097242d0b7c66360c00bd22979d91ff4/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/5482b1af097242d0b7c66360c00bd22979d91ff4/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/5482b1af097242d0b7c66360c00bd22979d91ff4/third_party/blink/renderer/core/loader/frame_resource_fetcher_properties.cc
[modify] https://crrev.com/5482b1af097242d0b7c66360c00bd22979d91ff4/third_party/blink/renderer/core/loader/frame_resource_fetcher_properties.h

Comment 16 by bugdroid1@chromium.org, Jan 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27263fe37b22af1f5d54fe2f9dfb3831608eec2a

commit 27263fe37b22af1f5d54fe2f9dfb3831608eec2a
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Sat Jan 12 04:34:07 2019

Remove VirtualTimePauser set-up logic from WillFollowRedirect

VirtualTimePauser is set in ResourceLoader::WillFollowRedirect but it
doesn't make sense because

 - It's already set in ResourceFetcher::StartLoad, and
 - There's no logic unpausing the timer on redirect.

Let's remove the logic from WillFollowRedirect.

Bug: 914739
Change-Id: I100a5201284a56da482a72ad08b1aee4bbcf86f6
Reviewed-on: https://chromium-review.googlesource.com/c/1402386
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622289}
[modify] https://crrev.com/27263fe37b22af1f5d54fe2f9dfb3831608eec2a/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc

Comment 17 by bugdroid1@chromium.org, Jan 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b692d1c749e806b4bfa82689a284297fc5aad07

commit 3b692d1c749e806b4bfa82689a284297fc5aad07
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Jan 15 06:43:41 2019

Move "global properties" to ResourceFetcherProperties, part 1

Add the following properties from ResourceFetcherProperties.
 - GetControllerServiceWorkerMode (renamed from
   IsControlledByServiceWorker)
 - ServiceWorkerId (renamed from ServiceWorkerID)
 - IsPaused (renamed from DefersLoading)
 - IsLoadComplete
 - ShouldBlockLoadingMainResource (from ShouldLoadNewResource)
 - ShouldBlockLoadingSubResource (from ShouldLoadNewResource)

This CL keeps the FrameFetchContext functions to keep the CL small.

This CL has subtle behavior changes for IsPaused and IsLoadComplete
after detached.

Bug: 914739
Change-Id: I2980a409b64c4e95b4607ab0162d19d142a7802b
Reviewed-on: https://chromium-review.googlesource.com/c/1406492
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622759}
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/core/loader/BUILD.gn
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/core/loader/frame_resource_fetcher_properties.cc
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/core/loader/frame_resource_fetcher_properties.h
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/core/loader/resource/font_resource_test.cc
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/core/loader/resource/image_resource_test.cc
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/core/loader/worker_fetch_context.h
[add] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/core/loader/worker_resource_fetcher_properties.cc
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/core/loader/worker_resource_fetcher_properties.h
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/core/workers/worklet_module_responses_map_test.cc
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/platform/loader/allowed_by_nosniff_test.cc
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/platform/loader/fetch/memory_cache_correctness_test.cc
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/platform/loader/fetch/memory_cache_test.cc
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/platform/loader/fetch/null_resource_fetcher_properties.h
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_properties.h
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler_test.cc
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/platform/loader/fetch/resource_loader_defer_loading_test.cc
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/platform/loader/fetch/resource_loader_test.cc
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/platform/loader/subresource_integrity_test.cc
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h
[modify] https://crrev.com/3b692d1c749e806b4bfa82689a284297fc5aad07/third_party/blink/renderer/platform/loader/testing/test_resource_fetcher_properties.h

Comment 18 by bugdroid1@chromium.org, Jan 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d

commit 9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Jan 15 08:03:10 2019

Move "global properties" to ResourceFetcherProperties, part 2

Introduce ResourceFetcherProperties::GetFetchClientSettingsObject.
Move FrameFetchContext::ProvideDocumentToContext to
ResourceFetcher::UpdateDocument, and delete
FetchContext::IsFrameFetchContext as it existed only for
ProvideDocumentToContext.

Bug: 914739
Change-Id: I5bdfd3f1af400c78ff8afd4cda91075eadbfa230
Reviewed-on: https://chromium-review.googlesource.com/c/1405961
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622775}
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/core/loader/base_fetch_context.cc
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/core/loader/base_fetch_context.h
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/core/loader/base_fetch_context_test.cc
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/core/loader/document_loader.h
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/core/loader/frame_resource_fetcher_properties.cc
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/core/loader/frame_resource_fetcher_properties.h
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/core/loader/worker_fetch_context.h
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/core/loader/worker_resource_fetcher_properties.cc
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/core/loader/worker_resource_fetcher_properties.h
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/platform/loader/BUILD.gn
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/platform/loader/allowed_by_nosniff_test.cc
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/platform/loader/fetch/memory_cache_correctness_test.cc
[add] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/platform/loader/fetch/null_resource_fetcher_properties.cc
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/platform/loader/fetch/null_resource_fetcher_properties.h
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_properties.h
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/platform/loader/fetch/resource_loader_test.cc
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h
[add] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/platform/loader/testing/test_resource_fetcher_properties.cc
[modify] https://crrev.com/9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d/third_party/blink/renderer/platform/loader/testing/test_resource_fetcher_properties.h

Comment 19 by bugdroid1@chromium.org, Jan 15

Project Member

Comment 20 by battre@chromium.org, Jan 15

commit 9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d breaks the jumbo builders. 

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8924280673330739408/+/steps/compile/0/stdout
[1048/1703] LINK ./v8_context_snapshot_generator
FAILED: v8_context_snapshot_generator 
python "../../build/toolchain/gcc_link_wrapper.py" --output="./v8_context_snapshot_generator" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,--icf=all -Wl,--color-diagnostics -m64 -Werror -Wl,-O2 -Wl,--gc-sections -rdynamic -nostdlib++ --sysroot=../../build/linux/debian_sid_amd64-sysroot -L../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -pie -Wl,-rpath-link=. -Wl,--disable-new-dtags -Wl,--icf=none -o "./v8_context_snapshot_generator" -Wl,--start-group @"./v8_context_snapshot_generator.rsp"  -Wl,--end-group   -ldl -lpthread -lrt -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lglib-2.0 -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -lresolv -lgio-2.0 -lX11 -lX11-xcb -lxcb -lXcomposite -lXcursor -lXdamage -lXext -lXfixes -lXi -lXrender -lXtst -lexpat -luuid -lXrandr -lpangocairo-1.0 -lpango-1.0 -lcairo -lXss -lasound -lm -lz -lpci -ldbus-1 
ld.lld: error: undefined symbol: blink::FrameFetchContext::ProvideDocumentToContext(blink::Document*)
>>> referenced by dom_jumbo_2.cc
>>>               dom/dom_jumbo_2.o:(blink::Document::Document(blink::DocumentInit const&, unsigned char)) in archive obj/third_party/blink/renderer/core/dom/libdom.a
clang: error: linker command failed with exit code 1 (use -v to see invocation)

First error in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-jumbo-rel/11441

Comment 21 by bugdroid1@chromium.org, Jan 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dfc0d7059d83afeb323863b68147040cc78403a

commit 9dfc0d7059d83afeb323863b68147040cc78403a
Author: Dominic Battré <battre@chromium.org>
Date: Tue Jan 15 09:58:15 2019

Revert "Move "global properties" to ResourceFetcherProperties, part 2"

This reverts commit 9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d.

Reason for revert: Breaks jumbo builders. See crbug.com/914739

Original change's description:
> Move "global properties" to ResourceFetcherProperties, part 2
> 
> Introduce ResourceFetcherProperties::GetFetchClientSettingsObject.
> Move FrameFetchContext::ProvideDocumentToContext to
> ResourceFetcher::UpdateDocument, and delete
> FetchContext::IsFrameFetchContext as it existed only for
> ProvideDocumentToContext.
> 
> Bug: 914739
> Change-Id: I5bdfd3f1af400c78ff8afd4cda91075eadbfa230
> Reviewed-on: https://chromium-review.googlesource.com/c/1405961
> Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622775}

TBR=yhirano@chromium.org,hiroshige@chromium.org,nhiroki@chromium.org

Change-Id: I31f88696e8f96a1c1dcee5784bf38cfc51997fbf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 914739
Reviewed-on: https://chromium-review.googlesource.com/c/1411338
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622795}
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/core/loader/base_fetch_context.cc
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/core/loader/base_fetch_context.h
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/core/loader/base_fetch_context_test.cc
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/core/loader/document_loader.h
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/core/loader/frame_resource_fetcher_properties.cc
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/core/loader/frame_resource_fetcher_properties.h
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/core/loader/worker_fetch_context.h
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/core/loader/worker_resource_fetcher_properties.cc
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/core/loader/worker_resource_fetcher_properties.h
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/platform/loader/BUILD.gn
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/platform/loader/allowed_by_nosniff_test.cc
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/platform/loader/fetch/memory_cache_correctness_test.cc
[delete] https://crrev.com/ab41c2866ed57abc1f778496440e84a7023a787c/third_party/blink/renderer/platform/loader/fetch/null_resource_fetcher_properties.cc
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/platform/loader/fetch/null_resource_fetcher_properties.h
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_properties.h
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/platform/loader/fetch/resource_loader_test.cc
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h
[delete] https://crrev.com/ab41c2866ed57abc1f778496440e84a7023a787c/third_party/blink/renderer/platform/loader/testing/test_resource_fetcher_properties.cc
[modify] https://crrev.com/9dfc0d7059d83afeb323863b68147040cc78403a/third_party/blink/renderer/platform/loader/testing/test_resource_fetcher_properties.h

Comment 22 by yhirano@chromium.org, Jan 15

It seems the linker wants a function I deleted.

Comment 23 by yhirano@chromium.org, Jan 15

Cc: battre@chromium.org
battre@, have you experienced a similar error?

Comment 24 by hirosh...@chromium.org, Jan 15

Perhaps  Issue 921967 ?

Comment 25 by kbr@chromium.org, Jan 15

Blockedon: 921130

Comment 26 by bugdroid1@chromium.org, Jan 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67

commit aa22a756cddafb23f8ba69ba9e33b858c4c2eb67
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Jan 16 02:45:46 2019

Reland "Move "global properties" to ResourceFetcherProperties, part 2"

This reverts commit 9dfc0d7059d83afeb323863b68147040cc78403a.

Reason for revert: The jumbo builders seem broken.

Original change's description:
> Revert "Move "global properties" to ResourceFetcherProperties, part 2"
> 
> This reverts commit 9b5a2b3afcf75f114f5fa2e67b00d445fbb7d39d.
> 
> Reason for revert: Breaks jumbo builders. See crbug.com/914739
> 
> Original change's description:
> > Move "global properties" to ResourceFetcherProperties, part 2
> > 
> > Introduce ResourceFetcherProperties::GetFetchClientSettingsObject.
> > Move FrameFetchContext::ProvideDocumentToContext to
> > ResourceFetcher::UpdateDocument, and delete
> > FetchContext::IsFrameFetchContext as it existed only for
> > ProvideDocumentToContext.
> > 
> > Bug: 914739
> > Change-Id: I5bdfd3f1af400c78ff8afd4cda91075eadbfa230
> > Reviewed-on: https://chromium-review.googlesource.com/c/1405961
> > Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#622775}
> 
> TBR=yhirano@chromium.org,hiroshige@chromium.org,nhiroki@chromium.org
> 
> Change-Id: I31f88696e8f96a1c1dcee5784bf38cfc51997fbf
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 914739
> Reviewed-on: https://chromium-review.googlesource.com/c/1411338
> Reviewed-by: Dominic Battré <battre@chromium.org>
> Commit-Queue: Dominic Battré <battre@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622795}

TBR=battre@chromium.org,yhirano@chromium.org,hiroshige@chromium.org,nhiroki@chromium.org

Change-Id: I2ea03f9ac2c0826cf365da87f850fb0444e4b110
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 914739
Reviewed-on: https://chromium-review.googlesource.com/c/1414052
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623065}
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/core/loader/base_fetch_context.cc
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/core/loader/base_fetch_context.h
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/core/loader/base_fetch_context_test.cc
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/core/loader/document_loader.h
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/core/loader/frame_resource_fetcher_properties.cc
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/core/loader/frame_resource_fetcher_properties.h
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/core/loader/worker_fetch_context.h
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/core/loader/worker_resource_fetcher_properties.cc
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/core/loader/worker_resource_fetcher_properties.h
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/platform/loader/BUILD.gn
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/platform/loader/allowed_by_nosniff_test.cc
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/platform/loader/fetch/memory_cache_correctness_test.cc
[add] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/platform/loader/fetch/null_resource_fetcher_properties.cc
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/platform/loader/fetch/null_resource_fetcher_properties.h
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_properties.h
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/platform/loader/fetch/resource_loader_test.cc
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h
[add] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/platform/loader/testing/test_resource_fetcher_properties.cc
[modify] https://crrev.com/aa22a756cddafb23f8ba69ba9e33b858c4c2eb67/third_party/blink/renderer/platform/loader/testing/test_resource_fetcher_properties.h

Comment 27 by bugdroid1@chromium.org, Jan 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd3ffcd67a4ba9b8f71c7f9b59a377a3234f5e16

commit cd3ffcd67a4ba9b8f71c7f9b59a377a3234f5e16
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Jan 16 03:56:49 2019

Make ResourceFetcher constructor accept only ResourceFetcherInit

Bug: 914739
Change-Id: I53935786b6ad9df8294a5ce051c36dab05562d2c
Reviewed-on: https://chromium-review.googlesource.com/c/1404762
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623086}
[modify] https://crrev.com/cd3ffcd67a4ba9b8f71c7f9b59a377a3234f5e16/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/cd3ffcd67a4ba9b8f71c7f9b59a377a3234f5e16/third_party/blink/renderer/core/loader/base_fetch_context_test.cc
[modify] https://crrev.com/cd3ffcd67a4ba9b8f71c7f9b59a377a3234f5e16/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/cd3ffcd67a4ba9b8f71c7f9b59a377a3234f5e16/third_party/blink/renderer/core/loader/resource/font_resource_test.cc
[modify] https://crrev.com/cd3ffcd67a4ba9b8f71c7f9b59a377a3234f5e16/third_party/blink/renderer/core/loader/resource/image_resource_test.cc
[modify] https://crrev.com/cd3ffcd67a4ba9b8f71c7f9b59a377a3234f5e16/third_party/blink/renderer/core/workers/worklet_module_responses_map_test.cc
[modify] https://crrev.com/cd3ffcd67a4ba9b8f71c7f9b59a377a3234f5e16/third_party/blink/renderer/platform/loader/fetch/memory_cache_correctness_test.cc
[modify] https://crrev.com/cd3ffcd67a4ba9b8f71c7f9b59a377a3234f5e16/third_party/blink/renderer/platform/loader/fetch/memory_cache_test.cc
[modify] https://crrev.com/cd3ffcd67a4ba9b8f71c7f9b59a377a3234f5e16/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h
[modify] https://crrev.com/cd3ffcd67a4ba9b8f71c7f9b59a377a3234f5e16/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
[modify] https://crrev.com/cd3ffcd67a4ba9b8f71c7f9b59a377a3234f5e16/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler_test.cc
[modify] https://crrev.com/cd3ffcd67a4ba9b8f71c7f9b59a377a3234f5e16/third_party/blink/renderer/platform/loader/fetch/resource_loader_defer_loading_test.cc
[modify] https://crrev.com/cd3ffcd67a4ba9b8f71c7f9b59a377a3234f5e16/third_party/blink/renderer/platform/loader/fetch/resource_loader_test.cc

Comment 28 by yhirano@chromium.org, Jan 16

Summary: Split FetchContext into multiple well-organized classes (was: Random FetchContext cleanup)

Comment 29 by kbr@chromium.org, Jan 16

Blocking: 921130

Comment 30 by kbr@chromium.org, Jan 16

Blockedon: -921130

Comment 31 by bugdroid1@chromium.org, Jan 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12c199ee65d6c040fa096a85b111598f7cf6f080

commit 12c199ee65d6c040fa096a85b111598f7cf6f080
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Jan 16 17:31:50 2019

Move "global properties" to ResourceFetcherProperties, part 3

This CL introduces ResourceFetcherProperties::IsDetached.
FetchContext::IsDetached remains, but it is no longer public.

Change-Id: I54f4515929fe497719a5ac8791ea7c5e6c922a64
Bug: 914739
Reviewed-on: https://chromium-review.googlesource.com/c/1406728
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623276}
[modify] https://crrev.com/12c199ee65d6c040fa096a85b111598f7cf6f080/third_party/blink/renderer/core/loader/frame_resource_fetcher_properties.h
[modify] https://crrev.com/12c199ee65d6c040fa096a85b111598f7cf6f080/third_party/blink/renderer/core/loader/worker_resource_fetcher_properties.h
[modify] https://crrev.com/12c199ee65d6c040fa096a85b111598f7cf6f080/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/12c199ee65d6c040fa096a85b111598f7cf6f080/third_party/blink/renderer/platform/loader/fetch/null_resource_fetcher_properties.h
[modify] https://crrev.com/12c199ee65d6c040fa096a85b111598f7cf6f080/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/12c199ee65d6c040fa096a85b111598f7cf6f080/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_properties.h
[modify] https://crrev.com/12c199ee65d6c040fa096a85b111598f7cf6f080/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[modify] https://crrev.com/12c199ee65d6c040fa096a85b111598f7cf6f080/third_party/blink/renderer/platform/loader/testing/test_resource_fetcher_properties.h

Comment 32 by bugdroid1@chromium.org, Jan 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f7e0f92892be931b27cb3e176b27140b57389d4

commit 1f7e0f92892be931b27cb3e176b27140b57389d4
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Jan 18 08:00:12 2019

Move task runner from FetchContext to ResourceFetcher

As part of FetchContext cleanup, this CL moves the loading task runner
from FetchContext::GetLoadingTaskRunner() to
ResourceFetcher::GetTaskRunner(), because "for loading" part is
apparent, and there is no other task runners in ResourceFetcher.

Bug: 914739
Change-Id: I1e0af9ddac1ce35b95bd0deb13e0bfc2572b7a0f
Reviewed-on: https://chromium-review.googlesource.com/c/1411713
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624033}
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/core/loader/base_fetch_context.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/core/loader/base_fetch_context.h
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/core/loader/base_fetch_context_test.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/core/loader/resource/font_resource_test.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/core/loader/resource/image_resource_test.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/core/loader/resource/script_resource.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/core/workers/worklet_module_responses_map_test.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/platform/loader/allowed_by_nosniff_test.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/platform/loader/fetch/memory_cache_correctness_test.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/platform/loader/fetch/memory_cache_test.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler_test.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/platform/loader/fetch/resource_loader_defer_loading_test.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/platform/loader/fetch/resource_loader_test.cc
[modify] https://crrev.com/1f7e0f92892be931b27cb3e176b27140b57389d4/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h

Comment 33 by bugdroid1@chromium.org, Jan 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b06109490928adae220fc5c5add22a7a96e9e30

commit 8b06109490928adae220fc5c5add22a7a96e9e30
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Jan 18 14:34:38 2019

Move "global properties" to ResourceFetcherProperties, part 4

Remove the following methods from FetchContext:
 - GetFetchClientSettingsObject
 - IsControlledByServiceWorker
 - ServiceWorkerID
 - IsMainFrame
 - DefersLoading
 - IsLoadComplete
 - GetSecurityOrigin

Add tests for ResourceFetcher::DetachableProperties in
resource_fetcher_test.cc.

Bug: 914739
Change-Id: I04fbdb95023a3d9f5b4b0f414149321d5af1f059
Reviewed-on: https://chromium-review.googlesource.com/c/1406789
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624114}
[modify] https://crrev.com/8b06109490928adae220fc5c5add22a7a96e9e30/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/8b06109490928adae220fc5c5add22a7a96e9e30/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc
[modify] https://crrev.com/8b06109490928adae220fc5c5add22a7a96e9e30/third_party/blink/renderer/core/loader/base_fetch_context.cc
[modify] https://crrev.com/8b06109490928adae220fc5c5add22a7a96e9e30/third_party/blink/renderer/core/loader/base_fetch_context_test.cc
[modify] https://crrev.com/8b06109490928adae220fc5c5add22a7a96e9e30/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/8b06109490928adae220fc5c5add22a7a96e9e30/third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
[modify] https://crrev.com/8b06109490928adae220fc5c5add22a7a96e9e30/third_party/blink/renderer/core/loader/mixed_content_checker.cc
[modify] https://crrev.com/8b06109490928adae220fc5c5add22a7a96e9e30/third_party/blink/renderer/core/loader/modulescript/module_script_loader.cc
[modify] https://crrev.com/8b06109490928adae220fc5c5add22a7a96e9e30/third_party/blink/renderer/core/loader/threadable_loader.cc
[modify] https://crrev.com/8b06109490928adae220fc5c5add22a7a96e9e30/third_party/blink/renderer/core/workers/dedicated_worker.cc
[modify] https://crrev.com/8b06109490928adae220fc5c5add22a7a96e9e30/third_party/blink/renderer/core/workers/worker_classic_script_loader.cc
[modify] https://crrev.com/8b06109490928adae220fc5c5add22a7a96e9e30/third_party/blink/renderer/core/workers/worklet.cc
[modify] https://crrev.com/8b06109490928adae220fc5c5add22a7a96e9e30/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc
[modify] https://crrev.com/8b06109490928adae220fc5c5add22a7a96e9e30/third_party/blink/renderer/platform/loader/allowed_by_nosniff.cc
[modify] https://crrev.com/8b06109490928adae220fc5c5add22a7a96e9e30/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/8b06109490928adae220fc5c5add22a7a96e9e30/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/8b06109490928adae220fc5c5add22a7a96e9e30/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/8b06109490928adae220fc5c5add22a7a96e9e30/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
[modify] https://crrev.com/8b06109490928adae220fc5c5add22a7a96e9e30/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc
[modify] https://crrev.com/8b06109490928adae220fc5c5add22a7a96e9e30/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[modify] https://crrev.com/8b06109490928adae220fc5c5add22a7a96e9e30/third_party/blink/renderer/platform/loader/testing/test_resource_fetcher_properties.h

Comment 34 by bugdroid1@chromium.org, Jan 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae427c902dfc8dc3cf6318f3d2d0b9249cec1b62

commit ae427c902dfc8dc3cf6318f3d2d0b9249cec1b62
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Jan 18 16:07:51 2019

Move WebScopedVirtualTimePauser creation to FrameFetchContext

In order to remove FetchContext::FrameSchduler, this CL moves
WebScopedVirtualTimePauser creation code from
ResourceFetcher::StartLoad to FrameFetchContext::PrepareRequest.

WorkerFetchContext is not affected because
WorkerFetchContext::GetFrameScheduler always returns null.

Bug: 914739
Change-Id: I9fbdf9809272ab0c0497b816cd8fe3ff029a45ae
Reviewed-on: https://chromium-review.googlesource.com/c/1415237
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624145}
[modify] https://crrev.com/ae427c902dfc8dc3cf6318f3d2d0b9249cec1b62/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/ae427c902dfc8dc3cf6318f3d2d0b9249cec1b62/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/ae427c902dfc8dc3cf6318f3d2d0b9249cec1b62/third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
[modify] https://crrev.com/ae427c902dfc8dc3cf6318f3d2d0b9249cec1b62/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/ae427c902dfc8dc3cf6318f3d2d0b9249cec1b62/third_party/blink/renderer/core/loader/worker_fetch_context.h
[modify] https://crrev.com/ae427c902dfc8dc3cf6318f3d2d0b9249cec1b62/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/ae427c902dfc8dc3cf6318f3d2d0b9249cec1b62/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/ae427c902dfc8dc3cf6318f3d2d0b9249cec1b62/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/ae427c902dfc8dc3cf6318f3d2d0b9249cec1b62/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h
[modify] https://crrev.com/ae427c902dfc8dc3cf6318f3d2d0b9249cec1b62/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc

Comment 35 by yhirano@chromium.org, Jan 22

Blockedon: 924024

Comment 36 by domfarolino@gmail.com, Jan 23

Cc: domfarolino@gmail.com

Comment 37 by bugdroid, Jan 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7d715dc6f67f777d12eea9e72cababb8d60863e

commit c7d715dc6f67f777d12eea9e72cababb8d60863e
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Jan 29 04:34:48 2019

Set "origin" header from ResourceRequest::RequestorOrigin

In BaseFetchContext, "origin" header is set from
 - FetchContext's security origin, or
 - the referrer string.

On the other hand,
https://fetch.spec.whatwg.org/#http-network-or-cache-fetch says:

  If the CORS flag is set, httpRequest’s method is neither `GET` nor
  `HEAD`, or httpRequest’s mode is "websocket", then append
  `Origin`/the result of serializing a request origin with
  httpRequest, to httpRequest’s header list.

This CL makes it a bit more spec conformant by setting the header based
on ResourceRequest::RequestorOrigin.

Bug: 914739
Change-Id: Ia911ca1f2efaf2be080d891b1258f87230d57f2d
Reviewed-on: https://chromium-review.googlesource.com/c/1388344
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626889}
[modify] https://crrev.com/c7d715dc6f67f777d12eea9e72cababb8d60863e/third_party/blink/renderer/core/loader/base_fetch_context.cc
[modify] https://crrev.com/c7d715dc6f67f777d12eea9e72cababb8d60863e/third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
[modify] https://crrev.com/c7d715dc6f67f777d12eea9e72cababb8d60863e/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc

Comment 38 by bugdroid, Jan 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcb7fe211335d4635a66a844fc40b29731ae685c

commit fcb7fe211335d4635a66a844fc40b29731ae685c
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Jan 30 00:19:57 2019

Introduce ResourceFetcher::LoaderFactory

Introduce ResourceFetcher::LoaderFactory to migrate
FetchContext::CreateURLLoader and FetchContext::CreateCodeCacheLoader.
Move the implementations from FetchContext subclasses to LoaderFactory
subclasses. Remove the FetchContext::GetLoadingTaskRunner as the moved
functions were the last users.

Bug: 914739
Change-Id: Id887bff75652ea39cc93d231b32ec2a749be2f87
Reviewed-on: https://chromium-review.googlesource.com/c/1414744
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#627239}
[modify] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/core/loader/BUILD.gn
[modify] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/core/loader/frame_fetch_context.h
[add] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/core/loader/loader_factory_for_frame.cc
[add] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/core/loader/loader_factory_for_frame.h
[add] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/core/loader/loader_factory_for_worker.cc
[add] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/core/loader/loader_factory_for_worker.h
[modify] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/core/loader/resource/font_resource_test.cc
[modify] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/core/loader/resource/image_resource_test.cc
[modify] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/core/loader/worker_fetch_context.h
[modify] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/core/workers/worklet_module_responses_map_test.cc
[modify] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/platform/loader/BUILD.gn
[modify] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/platform/loader/allowed_by_nosniff_test.cc
[modify] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h
[modify] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
[modify] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[modify] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/platform/loader/fetch/resource_loader_defer_loading_test.cc
[modify] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/platform/loader/fetch/resource_loader_test.cc
[modify] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h
[add] https://crrev.com/fcb7fe211335d4635a66a844fc40b29731ae685c/third_party/blink/renderer/platform/loader/testing/test_loader_factory.h

Comment 39 by bugdroid, Jan 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf66fa912e09b29740b2deb35a3060863acf9125

commit bf66fa912e09b29740b2deb35a3060863acf9125
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Jan 30 01:44:29 2019

Replace FetchContext::Bind with Init

FetchContext::Bind and FetchContext::Unbind were introduced to make
splitting FetchContext smoother, but their semantics were complex and
somewhat conflicting with FetchContext::Detach. Also, we want use
GetFetchResourceProperties() in FetchContext after detached, which
is not possible with the current implementation because |fetcher_|
is cleared when Unbind is called.

This CL introduces Init and removes Bind and Unbind. Now
ResourceFetcherProperties, not ResourceFetcher, is stored in
FetchContext. As ResourceFetcherProperties is safe to be
accessed after detached, we don't clear
the ResourceFetcherProperties when detached. Also,
FetchContext::IsDetached is removed as we can use
GetFetchResourceProperties().IsDetached now.

Bug: 914739
Change-Id: Ia1a41c0d7f8d8a47288868b5165a3ee08c106de9
Reviewed-on: https://chromium-review.googlesource.com/c/1424103
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#627268}
[modify] https://crrev.com/bf66fa912e09b29740b2deb35a3060863acf9125/third_party/blink/renderer/core/loader/base_fetch_context.cc
[modify] https://crrev.com/bf66fa912e09b29740b2deb35a3060863acf9125/third_party/blink/renderer/core/loader/base_fetch_context_test.cc
[modify] https://crrev.com/bf66fa912e09b29740b2deb35a3060863acf9125/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/bf66fa912e09b29740b2deb35a3060863acf9125/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/bf66fa912e09b29740b2deb35a3060863acf9125/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/bf66fa912e09b29740b2deb35a3060863acf9125/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/bf66fa912e09b29740b2deb35a3060863acf9125/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc

Comment 40 by bugdroid, Jan 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09b3f006afb6302dce95a875114ddd305c938d7a

commit 09b3f006afb6302dce95a875114ddd305c938d7a
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Jan 30 03:19:58 2019

Move BaseFetchContext::GetAddressSpace to FetchClientSettingsObject

"Client's address space" is defined as [1], so it's good to have the
property in FetchClientSettingsObject.

1: https://wicg.github.io/cors-rfc1918/#address-space

Bug: 914739
Change-Id: I81c0fd1c07af86a3a1c73624620d121a28475163
Reviewed-on: https://chromium-review.googlesource.com/c/1424685
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#627294}
[modify] https://crrev.com/09b3f006afb6302dce95a875114ddd305c938d7a/third_party/blink/renderer/core/loader/base_fetch_context.cc
[modify] https://crrev.com/09b3f006afb6302dce95a875114ddd305c938d7a/third_party/blink/renderer/core/loader/base_fetch_context.h
[modify] https://crrev.com/09b3f006afb6302dce95a875114ddd305c938d7a/third_party/blink/renderer/core/loader/base_fetch_context_test.cc
[modify] https://crrev.com/09b3f006afb6302dce95a875114ddd305c938d7a/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/09b3f006afb6302dce95a875114ddd305c938d7a/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/09b3f006afb6302dce95a875114ddd305c938d7a/third_party/blink/renderer/core/loader/frame_resource_fetcher_properties.cc
[modify] https://crrev.com/09b3f006afb6302dce95a875114ddd305c938d7a/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/09b3f006afb6302dce95a875114ddd305c938d7a/third_party/blink/renderer/core/loader/worker_fetch_context.h
[modify] https://crrev.com/09b3f006afb6302dce95a875114ddd305c938d7a/third_party/blink/renderer/core/script/fetch_client_settings_object_impl.cc
[modify] https://crrev.com/09b3f006afb6302dce95a875114ddd305c938d7a/third_party/blink/renderer/core/script/fetch_client_settings_object_impl.h
[modify] https://crrev.com/09b3f006afb6302dce95a875114ddd305c938d7a/third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object.h
[modify] https://crrev.com/09b3f006afb6302dce95a875114ddd305c938d7a/third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object_snapshot.cc
[modify] https://crrev.com/09b3f006afb6302dce95a875114ddd305c938d7a/third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object_snapshot.h
[modify] https://crrev.com/09b3f006afb6302dce95a875114ddd305c938d7a/third_party/blink/renderer/platform/loader/fetch/null_resource_fetcher_properties.cc
[modify] https://crrev.com/09b3f006afb6302dce95a875114ddd305c938d7a/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
[modify] https://crrev.com/09b3f006afb6302dce95a875114ddd305c938d7a/third_party/blink/renderer/platform/loader/testing/test_resource_fetcher_properties.cc

Comment 41 by bugdroid, Jan 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fc22ace5f617cdba922415ce0883a23d009fa8a

commit 5fc22ace5f617cdba922415ce0883a23d009fa8a
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Jan 30 03:33:52 2019

Remove FetchContext::GetFrameScheduler

Remove FetchContext::GetFrameScheduler calls from
ResourceLoadScheduler.
 - AddLifecycleObserver is called at the construction time, so
   provide the frame scheduler via ResourceFetcherInit.
 - GetFrameStatus calls are replaced by
   ResourceFetcherProperties::GetFrameStatus.

ResourceLoadScheduler was the only user of
FetchContext::GetFrameScheduler, so we can remove it now.

Bug: 914739
Change-Id: I367cf96e06aadf7006b631a32fe3aa671fe69af9
Reviewed-on: https://chromium-review.googlesource.com/c/1402303
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#627299}
[modify] https://crrev.com/5fc22ace5f617cdba922415ce0883a23d009fa8a/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/5fc22ace5f617cdba922415ce0883a23d009fa8a/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/5fc22ace5f617cdba922415ce0883a23d009fa8a/third_party/blink/renderer/core/loader/frame_resource_fetcher_properties.cc
[modify] https://crrev.com/5fc22ace5f617cdba922415ce0883a23d009fa8a/third_party/blink/renderer/core/loader/frame_resource_fetcher_properties.h
[modify] https://crrev.com/5fc22ace5f617cdba922415ce0883a23d009fa8a/third_party/blink/renderer/core/loader/resource/image_resource_test.cc
[modify] https://crrev.com/5fc22ace5f617cdba922415ce0883a23d009fa8a/third_party/blink/renderer/core/loader/worker_resource_fetcher_properties.h
[modify] https://crrev.com/5fc22ace5f617cdba922415ce0883a23d009fa8a/third_party/blink/renderer/platform/loader/allowed_by_nosniff_test.cc
[modify] https://crrev.com/5fc22ace5f617cdba922415ce0883a23d009fa8a/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/5fc22ace5f617cdba922415ce0883a23d009fa8a/third_party/blink/renderer/platform/loader/fetch/null_resource_fetcher_properties.h
[modify] https://crrev.com/5fc22ace5f617cdba922415ce0883a23d009fa8a/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/5fc22ace5f617cdba922415ce0883a23d009fa8a/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h
[modify] https://crrev.com/5fc22ace5f617cdba922415ce0883a23d009fa8a/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_properties.h
[modify] https://crrev.com/5fc22ace5f617cdba922415ce0883a23d009fa8a/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
[modify] https://crrev.com/5fc22ace5f617cdba922415ce0883a23d009fa8a/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc
[modify] https://crrev.com/5fc22ace5f617cdba922415ce0883a23d009fa8a/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.h
[modify] https://crrev.com/5fc22ace5f617cdba922415ce0883a23d009fa8a/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler_test.cc
[modify] https://crrev.com/5fc22ace5f617cdba922415ce0883a23d009fa8a/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h
[modify] https://crrev.com/5fc22ace5f617cdba922415ce0883a23d009fa8a/third_party/blink/renderer/platform/loader/testing/test_resource_fetcher_properties.h

Comment 42 by bugdroid, Feb 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6abe439b0e02f37be499c87abd791e00e91df77

commit e6abe439b0e02f37be499c87abd791e00e91df77
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Feb 14 07:12:51 2019

Introduce probe::PrepareRequest

Split probe::PrepareRequest from probe::WillSendRequest.

 - probe::PrepareRequest is called from FetchContext::PrepareRequest.
 - probe::WillSendRequest does not modify the given request.
 - probe::WillSendRequest is called from
   FetchContext::DispatchWillSendRequest.

There are some behavior changes.
 - The call site for FetchContext::PrepareRequest and
   FetchContext::DispatchWillSendRequest are somewhat distant. For
   example, now the "disable cache" option in devtools takes effect
   for MemoryCache as the modification is done in PrepareRequest which
   precedes ResourceFetcher::DetermineRevalidationPolicy.

I updated
http/tests/devtools/network/network-memory-cached-resource.js because
it is affected by the "disable cache" behavior change.

Bug: 924024, 914739, 632580
Change-Id: Ie25dc899b21a0588fac1a52209bd4f8e6ecae5aa
Reviewed-on: https://chromium-review.googlesource.com/c/1426250
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632117}
[modify] https://crrev.com/e6abe439b0e02f37be499c87abd791e00e91df77/third_party/blink/renderer/core/inspector/inspector_emulation_agent.cc
[modify] https://crrev.com/e6abe439b0e02f37be499c87abd791e00e91df77/third_party/blink/renderer/core/inspector/inspector_emulation_agent.h
[modify] https://crrev.com/e6abe439b0e02f37be499c87abd791e00e91df77/third_party/blink/renderer/core/inspector/inspector_network_agent.cc
[modify] https://crrev.com/e6abe439b0e02f37be499c87abd791e00e91df77/third_party/blink/renderer/core/inspector/inspector_network_agent.h
[modify] https://crrev.com/e6abe439b0e02f37be499c87abd791e00e91df77/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/e6abe439b0e02f37be499c87abd791e00e91df77/third_party/blink/renderer/core/inspector/inspector_trace_events.h
[modify] https://crrev.com/e6abe439b0e02f37be499c87abd791e00e91df77/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/e6abe439b0e02f37be499c87abd791e00e91df77/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/e6abe439b0e02f37be499c87abd791e00e91df77/third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
[modify] https://crrev.com/e6abe439b0e02f37be499c87abd791e00e91df77/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/e6abe439b0e02f37be499c87abd791e00e91df77/third_party/blink/renderer/core/loader/worker_fetch_context.h
[modify] https://crrev.com/e6abe439b0e02f37be499c87abd791e00e91df77/third_party/blink/renderer/core/probe/core_probes.json5
[modify] https://crrev.com/e6abe439b0e02f37be499c87abd791e00e91df77/third_party/blink/renderer/core/probe/core_probes.pidl
[modify] https://crrev.com/e6abe439b0e02f37be499c87abd791e00e91df77/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/e6abe439b0e02f37be499c87abd791e00e91df77/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/e6abe439b0e02f37be499c87abd791e00e91df77/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/e6abe439b0e02f37be499c87abd791e00e91df77/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[modify] https://crrev.com/e6abe439b0e02f37be499c87abd791e00e91df77/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h
[modify] https://crrev.com/e6abe439b0e02f37be499c87abd791e00e91df77/third_party/blink/web_tests/http/tests/devtools/network/network-memory-cached-resource-expected.txt
[modify] https://crrev.com/e6abe439b0e02f37be499c87abd791e00e91df77/third_party/blink/web_tests/http/tests/devtools/network/network-memory-cached-resource.js
[modify] https://crrev.com/e6abe439b0e02f37be499c87abd791e00e91df77/third_party/blink/web_tests/http/tests/devtools/network/resources/memory-cached-resource.html

Comment 43 by bugdroid, Feb 20 (3 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb6e5281c42c8364318bc8444ca86211f1054b89

commit fb6e5281c42c8364318bc8444ca86211f1054b89
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Feb 20 19:13:00 2019

Remove a ResourceType check in FrameFetchContext::DidLoadResource

This is a preliminary change followed by https://crrev.com/c/1474887.
Document::CheckCompleted should be immune to excessive calls, so this
should not be a problem.

Bug: 914739
Change-Id: I3b33b01fc434d04f328865777166e30c9abddf55
Reviewed-on: https://chromium-review.googlesource.com/c/1478318
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633820}
[modify] https://crrev.com/fb6e5281c42c8364318bc8444ca86211f1054b89/third_party/blink/renderer/core/loader/frame_fetch_context.cc

Sign in to add a comment