Issue metadata
Sign in to add a comment
|
Regression : 'Gallery' option is seen instead of 'Open with Gallery...' in Files App context menu |
||||||||||||||||||||||
Issue descriptionChrome Version: 72.0.3626.15/11316.18.0 Kip,Daisy and Reks, OS: Chrome What steps will reproduce the problem? 1)Sign into User -> press 'Ctrl+F5(Overview Mode Button)' for screenshot -> go to Files App-> Right click for context menu (2)Now observe 'Gallery' option is seen instead of 'Open with Gallery...' (Please refer Screenshot) Expected: 'Open with Gallery...' should be seen Actual: Instead 'Gallery' option is seen This is Regression Issue as same is working fine in M-68 Note : Issue is also seen on M-69,M-70, M-71 and M-73
,
Dec 13
The problematic code:
if (defaultTask.taskId === FileTasks.ZIP_ARCHIVER_UNZIP_TASK_ID)
this.ui_.fileContextMenu.defaultTaskMenuItem.label = str('TASK_OPEN');
else
this.ui_.fileContextMenu.defaultTaskMenuItem.label = defaultTask.title;
I guess we should be using defaultTask.label
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c463db43d98d7cb261f7e461fa628af0c5c532df commit c463db43d98d7cb261f7e461fa628af0c5c532df Author: Stuart Langley <slangley@google.com> Date: Fri Dec 14 01:27:22 2018 Fix regression when showing open tasks in context menus. When showing open tasks for files they should be displayed as "Open with XXX" not just XXX. This appears to be a regression introduced in https://chromium-review.googlesource.com/1116878 Bug: 914737 Change-Id: I39c33575ceb215fe46c0fccc7ba218dae311ac40 Reviewed-on: https://chromium-review.googlesource.com/c/1377469 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#616547} [modify] https://crrev.com/c463db43d98d7cb261f7e461fa628af0c5c532df/ui/file_manager/file_manager/foreground/js/task_controller.js [modify] https://crrev.com/c463db43d98d7cb261f7e461fa628af0c5c532df/ui/file_manager/file_manager/test/crostini_tasks.js
,
Dec 14
,
Dec 15
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 17
Does this change require string translation? String translation deadline has already passed.
,
Dec 17
,
Dec 17
A string translation should not be required as this fixes the current string to the previously existing string.
,
Dec 17
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9488fab9141042e51457a2b467f268c87f91f5cf commit 9488fab9141042e51457a2b467f268c87f91f5cf Author: Stuart Langley <slangley@google.com> Date: Mon Dec 17 22:35:42 2018 Fix regression when showing open tasks in context menus. When showing open tasks for files they should be displayed as "Open with XXX" not just XXX. This appears to be a regression introduced in https://chromium-review.googlesource.com/1116878 Bug: 914737 Change-Id: I39c33575ceb215fe46c0fccc7ba218dae311ac40 Reviewed-on: https://chromium-review.googlesource.com/c/1377469 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#616547}(cherry picked from commit c463db43d98d7cb261f7e461fa628af0c5c532df) Reviewed-on: https://chromium-review.googlesource.com/c/1381171 Reviewed-by: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#412} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/9488fab9141042e51457a2b467f268c87f91f5cf/ui/file_manager/file_manager/foreground/js/task_controller.js [modify] https://crrev.com/9488fab9141042e51457a2b467f268c87f91f5cf/ui/file_manager/file_manager/test/crostini_tasks.js
,
Dec 17
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9488fab9141042e51457a2b467f268c87f91f5cf Commit: 9488fab9141042e51457a2b467f268c87f91f5cf Author: slangley@google.com Commiter: slangley@chromium.org Date: 2018-12-17 22:35:42 +0000 UTC Fix regression when showing open tasks in context menus. When showing open tasks for files they should be displayed as "Open with XXX" not just XXX. This appears to be a regression introduced in https://chromium-review.googlesource.com/1116878 Bug: 914737 Change-Id: I39c33575ceb215fe46c0fccc7ba218dae311ac40 Reviewed-on: https://chromium-review.googlesource.com/c/1377469 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#616547}(cherry picked from commit c463db43d98d7cb261f7e461fa628af0c5c532df) Reviewed-on: https://chromium-review.googlesource.com/c/1381171 Reviewed-by: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#412} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Dec 19
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 9488fab9141042e51457a2b467f268c87f91f5cf was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required -- |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by slangley@chromium.org
, Dec 13Status: Assigned (was: Untriaged)