New issue
Advanced search Search tips

Issue 914712 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

V8 DEPS roll is broken due to syntax error

Project Member Reported by machenb...@chromium.org, Dec 13

Issue description

Cc: ehmaldonado@chromium.org
Cc: -ehmaldonado@chromium.org
Components: -Infra Infra>Client>V8
Labels: -Infra-Troopers -Pri-0 Pri-2
Summary: V8 DEPS roll is broken due to syntax error (was: All V8 bot_update is purple on CQ)
Actually this is just one broken roll it seems...

https://chromium-review.googlesource.com/c/v8/v8/+/1374994
Cc: ehmaldonado@chromium.org
Components: Infra>SDK
@Edward: What is the correct way to use gclient setdep for a cipd package? I'm not able to get it right on cmd line. I want to change the entry for luci_go e.g. in:
https://cs.chromium.org/chromium/src/DEPS?q=DEPS&sq=package:chromium&dr=C&l=99

How can I do that with setdep?
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c4fdb272bcd0f092563bdd197ca9e34eacac560e

commit c4fdb272bcd0f092563bdd197ca9e34eacac560e
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Dec 13 10:09:20 2018

[build] Manually roll luci-go

This ports:
https://crrev.com/c/1374050

TBR=sergiyb@chromium.org

Bug:  chromium:914712 
Change-Id: Ia5eccd9b689ca103d819e65706b4c8ad062a677d
Reviewed-on: https://chromium-review.googlesource.com/c/1375653
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58208}
[modify] https://crrev.com/c4fdb272bcd0f092563bdd197ca9e34eacac560e/DEPS

Owner: ehmaldonado@chromium.org
Status: Assigned (was: Untriaged)
I didn't get around to implement variables support when setting CIPD deps, since there was no need for it at the time.
I'll look into it.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/a1e4d48a104af8e96b34eaa436138920f029469c

commit a1e4d48a104af8e96b34eaa436138920f029469c
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Mon Dec 17 19:01:03 2018

setdep: Add support for variables when setting CIPD vars.

Bug:  914712 
Change-Id: I13db57af519bb254389bc6bd1f1f81ad1d497e42
Reviewed-on: https://chromium-review.googlesource.com/c/1377295
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/a1e4d48a104af8e96b34eaa436138920f029469c/gclient_eval.py
[modify] https://crrev.com/a1e4d48a104af8e96b34eaa436138920f029469c/tests/gclient_eval_unittest.py

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f78ca8dd16df06993425c3ad83e421dd04a21472

commit f78ca8dd16df06993425c3ad83e421dd04a21472
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Dec 17 20:37:36 2018

Roll src/third_party/depot_tools 27c6e44188fb..a1e4d48a104a (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/27c6e44188fb..a1e4d48a104a


git log 27c6e44188fb..a1e4d48a104a --date=short --no-merges --format='%ad %ae %s'
2018-12-17 ehmaldonado@chromium.org setdep: Add support for variables when setting CIPD vars.


Created with:
  gclient setdep -r src/third_party/depot_tools@a1e4d48a104a

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:914712 
TBR=agable@chromium.org

Change-Id: Iba0e05f930e2aa30764b413b3b12122d028fdfb6
Reviewed-on: https://chromium-review.googlesource.com/c/1380751
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#617214}
[modify] https://crrev.com/f78ca8dd16df06993425c3ad83e421dd04a21472/DEPS

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/fb8c1a203db839a0dbbed99af3617056139bad82

commit fb8c1a203db839a0dbbed99af3617056139bad82
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Mon Dec 17 20:44:18 2018

gclient eval: Replace monorail with crbug.com in error message.

Tbr: tandrii@chromium.org
Bug:  914712 
Change-Id: Iff8aecff346692ef36fd653f226b48270fefa304
Reviewed-on: https://chromium-review.googlesource.com/c/1380972
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/fb8c1a203db839a0dbbed99af3617056139bad82/gclient_eval.py

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67318799acf2d05731bb5f9389d13d115d567ef7

commit 67318799acf2d05731bb5f9389d13d115d567ef7
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Dec 17 21:50:33 2018

Roll src/third_party/depot_tools a1e4d48a104a..fb8c1a203db8 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a1e4d48a104a..fb8c1a203db8


git log a1e4d48a104a..fb8c1a203db8 --date=short --no-merges --format='%ad %ae %s'
2018-12-17 ehmaldonado@chromium.org gclient eval: Replace monorail with crbug.com in error message.


Created with:
  gclient setdep -r src/third_party/depot_tools@fb8c1a203db8

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:914712 
TBR=agable@chromium.org

Change-Id: Ic9ffb13dcc49c2e40e0cc3c97ee0e4ce7403554e
Reviewed-on: https://chromium-review.googlesource.com/c/1380654
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#617243}
[modify] https://crrev.com/67318799acf2d05731bb5f9389d13d115d567ef7/DEPS

Comment 10 by ehmaldonado@chromium.org, Jan 16 (6 days ago)

Status: Fixed (was: Assigned)

Comment 11 by machenbach@google.com, Jan 17 (5 days ago)

Thanks for fixing!

Sign in to add a comment